fde87ff06eeb2e8723ec91222a15fe2d4a72d3d3
Replace infinite polling loops with base::test::RunUntil() to prevent test timeouts. The WaitDistilled(), WaitDistillable(), WaitOriginal(), and WaitToolbarVisibility() functions used NonBlockingDelay() in infinite while loops, which could run forever if the expected state was never reached. Using base::test::RunUntil() provides a built-in 1-second timeout and returns false on timeout, allowing tests to fail gracefully instead of hanging indefinitely. This addresses the intermittent timeout failures in SpeedReaderBrowserTest.EnableDisableSpeedreaderB. Also modernize the ShowOriginalPage test to use base::test::RunUntil() instead of the old NonBlockingDelay() polling pattern when waiting for the "View original" link to appear in the DOM. This maintains consistency with the helper function improvements. Fixes: brave/brave-browser#51693
[Android] Fixes a crash in FaviconUtils.getIconDrawableWithFilter when an icon is not available for a particular URL by falling back to the default globe icon. (#33569)
[Android] Fixes a crash in FaviconUtils.getIconDrawableWithFilter when an icon is not available for a particular URL by falling back to the default globe icon. (#33569)
…
…
…
…
…
…
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack
Languages
C++
36.9%
HTML
31.6%
Swift
9.4%
TypeScript
9%
Java
4.8%
Other
8.1%