Fix typos and amend PR template (#5227)

This commit is contained in:
Lucas Manuel Rodriguez
2022-04-19 18:09:55 -03:00
committed by GitHub
parent bda31e254b
commit 29a902960e
5 changed files with 5 additions and 6 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
If some of the following don't apply, delete the relevant line.
- [ ] Changes file added (for user-visible changes)
- [ ] Changes file added for user-visible changes (in `changes/` and/or `orbit/changes/`).
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md)
- [ ] Documented any permissions changes
- [ ] Ensured that input data is properly validated, SQL injection is prevented (using placeholders for values in statements)
+1 -1
View File
@@ -219,7 +219,7 @@ Orbit captures and streams osqueryd's stdout/stderr into its own stdout/stderr o
Following are the destination of logs for each platform (to access such locations the user will need administrative permissions on the host):
- Linux: Orbit and osqueryd stdout/stderr output is sent to syslog (`/var/log/syslog` on Debian systems and `/var/log/messages` on CentOS).
- macOS: `/private/var/log/orbit/orbit.std{out|err}.log`.
- Windows: `C:\Windows\system32\config\systemprofile\AppData\Local\FleetDM\Orbit\Logs\orbit-osquery.lg` (the log file is rotated).
- Windows: `C:\Windows\system32\config\systemprofile\AppData\Local\FleetDM\Orbit\Logs\orbit-osquery.log` (the log file is rotated).
#### Debug
+1 -1
View File
@@ -531,7 +531,7 @@ func (d *desktopRunner) actor() (func() error, func(error)) {
// execute makes sure the fleet-desktop application is running.
//
// We have to support the scenario where the user closes its sessions (log out).
// To support this, we add retries to execuser.Run. Basically retry execuser.Run until it succeds,
// To support this, we add retries to execuser.Run. Basically retry execuser.Run until it succeeds,
// which will happen when the user logs in.
// Once fleet-desktop is started, the process is monitored (user processes get killed when the user
// closes all its sessions).
+1 -2
View File
@@ -78,8 +78,7 @@ func policyDB(ctx context.Context, q sqlx.QueryerContext, id uint, teamID *uint)
// SavePolicy updates some fields of the given policy on the datastore.
//
// Currently SavePolicy does not allow updating the team or platform of an existing policy,
// such functionality will be implemented in #3220.
// Currently SavePolicy does not allow updating the team of an existing policy.
func (ds *Datastore) SavePolicy(ctx context.Context, p *fleet.Policy) error {
sql := `
UPDATE policies
+1 -1
View File
@@ -76,7 +76,7 @@ function create_repository() {
rm desktop.app.tar.gz
fi
# Add Fleet Desktop application on (if enabled).
# Add Fleet Desktop application on windows (if enabled).
if [[ $system == "windows" && -n "$FLEET_DESKTOP" ]]; then
FLEET_DESKTOP_VERSION=42.0.0 \
make desktop-windows