UI – Replace overflow-x: scroll with ...auto; remove redundant local declarations (#15054)

## Addresses #11753 

Fixed:
![Screenshot 2023-11-08 at 5 45
09 PM](https://github.com/fleetdm/fleet/assets/61553566/55570f5b-eb7d-4974-96e3-0304eef30b87)
(Was also occurring on queries page)
![Screenshot 2023-11-08 at 5 45
16 PM](https://github.com/fleetdm/fleet/assets/61553566/139d1ac6-e1e7-4b22-87d5-8cb43d00005d)

## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
This commit is contained in:
Jacob Shandling
2023-11-09 09:16:22 -08:00
committed by GitHub
co-authored by Jacob Shandling
parent 407c1a537a
commit 29b3da14f3
10 changed files with 3 additions and 28 deletions
+1
View File
@@ -0,0 +1 @@
- Fix a UI bug in data tables where scrollbars would continue to be present despite no overflowing content
@@ -14,6 +14,7 @@ $shadow-transition-width: 10px;
margin-top: $pad-small;
flex-grow: 1;
width: 100%;
overflow-x: auto;
// Shadow
background-image:
@@ -2,9 +2,6 @@
margin-top: $pad-large;
position: relative;
.data-table__wrapper {
overflow-x: auto;
}
.component__tabs-wrapper .table-container__header {
display: none;
}
@@ -2,10 +2,6 @@
margin-top: $pad-large;
position: relative;
.data-table__wrapper {
overflow-x: auto;
}
.hosts-cell__wrapper {
display: flex;
align-items: center;
@@ -33,6 +29,6 @@
&__os-empty-table.empty-table__container {
// overriding base component styles so this look correct for this card
margin-top: $pad-large
margin-top: $pad-large;
}
}
@@ -13,9 +13,6 @@
outline: 1px solid $core-vibrant-blue;
}
}
.data-table__wrapper {
overflow-x: auto;
}
.form-field--dropdown {
margin: 0;
}
@@ -196,9 +196,6 @@
.table-container__data-table-block {
.data-table-block {
.data-table {
&__wrapper {
overflow-x: scroll;
}
&__table {
tbody {
.issues {
@@ -1,5 +1,4 @@
.query-results {
.info-banner {
margin: 2rem auto 1.25rem;
}
@@ -14,10 +13,6 @@
}
}
.data-table__wrapper {
overflow-x: scroll;
}
.data-table-block .data-table thead th {
min-width: 140px;
padding-left: 0px;
@@ -98,7 +98,6 @@
.data-table-block {
.data-table {
&__wrapper {
overflow-x: scroll;
overflow-y: hidden;
}
&__table {
@@ -9,10 +9,6 @@
margin-bottom: 44px; // Fills space where filter is removed
}
}
.data-table__wrapper {
overflow-x: scroll;
}
}
&__results-cta {
@@ -23,10 +23,6 @@
}
}
.data-table__wrapper {
overflow-x: scroll;
}
.data-table-block .data-table thead th {
min-width: 140px;
padding-left: 0px;