Discharge7443/fleet
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

Stop validating query syntax (#1090)

Browse Source
This commit is contained in:
Mike Stone
2017-01-24 17:23:20 -05:00
committed by Jason Meller
parent 949b9b53b1
commit 8749633b85
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/components/forms/validators/validate_query/index.js
+3 -1
View File
@@ -26,7 +26,9 @@ export const validateQuery = (queryText) => {
return validQueryResponse;
} catch (error) {
return invalidQueryResponse(error.message);
// FIXME: return invalidQueryResponse(error.message);
// when SQL parsing has been fixed.
return { valid: true, error: null };
}
};
frontend/components/forms/validators/validate_query/validate_query.tests.js
+6 -2
View File
@@ -11,8 +11,10 @@ describe('validateQuery', () => {
it('rejects malformed queries', () => {
const { error, valid } = validateQuery(malformedQuery);
expect(valid).toEqual(false);
expect(error).toEqual('Syntax error found near WITH Clause (Statement)');
// FIXME: expect(valid).toEqual(false);
expect(valid).toEqual(true);
// FIXME: expect(error).toEqual('Syntax error found near WITH Clause (Statement)');
expect(error).toEqual(null);
});
it('rejects blank queries', () => {
@@ -24,12 +26,14 @@ describe('validateQuery', () => {
it('rejects create queries', () => {
const { error, valid } = validateQuery(createQuery);
expect(valid).toEqual(false);
expect(error).toEqual('Cannot INSERT or CREATE in osquery queries');
});
it('rejects insert queries', () => {
const { error, valid } = validateQuery(insertQuery);
expect(valid).toEqual(false);
expect(error).toEqual('Cannot INSERT or CREATE in osquery queries');
});