Use the query tag name instead of the field name (#33369)

#33244
This commit is contained in:
Dante Catalfamo
2025-09-24 10:51:39 -04:00
committed by GitHub
parent 25bcd0f36a
commit aadbb7dc8a
3 changed files with 7 additions and 2 deletions
@@ -0,0 +1 @@
- Fixed required query parameters using field name instead of parameter name in error messages
@@ -6926,8 +6926,12 @@ func (s *integrationEnterpriseTestSuite) TestRunBatchScript() {
0,
)
// List pending hosts
var batchPendingHostsResp batchScriptExecutionHostResultsResponse
res := s.Do("GET", fmt.Sprintf("/api/latest/fleet/scripts/batch/%s/host-results", batchRes.BatchExecutionID), nil, http.StatusBadRequest)
errMsg := extractServerErrorText(res.Body)
require.Contains(t, errMsg, "Param status is required")
// List pending hosts
s.DoJSON("GET", fmt.Sprintf("/api/latest/fleet/scripts/batch/%s/host-results?status=pending", batchRes.BatchExecutionID), nil, http.StatusOK, &batchPendingHostsResp)
require.Len(t, batchPendingHostsResp.Hosts, 2)
require.Equal(t, batchPendingHostsResp.Count, uint(2))
@@ -186,7 +186,7 @@ func DecodeQueryTagValue(r *http.Request, fp fieldPair) error {
if optional {
return nil
}
return &fleet.BadRequestError{Message: fmt.Sprintf("Param %s is required", fp.Sf.Name)}
return &fleet.BadRequestError{Message: fmt.Sprintf("Param %s is required", queryTagValue)}
}
field := fp.V
if field.Kind() == reflect.Ptr {