Discharge7443/fleet
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Update JS password validation (#1213)

Browse Source 
Fixes #1212
This commit is contained in:
Zachary Wasserman
2017-02-13 15:34:24 -08:00
committed by GitHub
parent b32e489716
commit e0c767bc1e
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/components/forms/validators/valid_password/index.js
+1 -6
View File
@@ -1,14 +1,9 @@
const LETTER_PRESENT = /[a-z]+/i;
const NUMBER_PRESENT = /[0-9]+/;
const SYMBOL_PRESENT = /[!@#\$%\^&\*\(\)]+/i;
const noWhitespace = (password) => {
return password.indexOf(' ') === -1;
};
const SYMBOL_PRESENT = /\W+/;
export default (password = '') => {
return password.length >= 7 &&
noWhitespace(password) &&
LETTER_PRESENT.test(password) &&
NUMBER_PRESENT.test(password) &&
SYMBOL_PRESENT.test(password);
frontend/components/forms/validators/valid_password/valid_password.tests.js
+6 -3
View File
@@ -11,9 +11,8 @@ describe('validPassword', () => {
const allLetters = 'mypassword';
const allNumbers = '123456789';
const allSymbols = '!@#$%^&*()';
const containsSpace = 'p@ ssw0rd';
const invalidPasswords = [tooShort, noSymbols, noLetters, noNumbers, allLetters, allNumbers, allSymbols, containsSpace];
const invalidPasswords = [tooShort, noSymbols, noLetters, noNumbers, allLetters, allNumbers, allSymbols];
invalidPasswords.map((password) => {
return expect(validPassword(password)).toEqual(false, `expected ${password} to not be valid`);
@@ -21,6 +20,10 @@ describe('validPassword', () => {
});
it('is valid if the password is at least 7 characters and includes a number and a symbol', () => {
expect(validPassword('p@ssw0rd')).toEqual(true, 'expected p@ssw0rd to be valid');
const validPasswords = ['p@assw0rd', 'This should be v4lid!', 'admin123.', 'pRZ\'bW,6\'6o}HnpL62'];
validPasswords.map((password) => {
return expect(validPassword(password)).toEqual(true, `expected ${password} to be valid`);
});
});
});