Commit Graph
14995 Commits
Author SHA1 Message Date
jacobshandlingandJacob Shandling 338a00a693 UI: only setEditingExistingQuery in the edit query form if the query has been modified (#25115)
## #24653 

- This bug was more generally that live query runs from the Edit query
form did not include the `query_id` in the `run` API call.


![ezgif-6-8ef29273dc](https://github.com/user-attachments/assets/d6792037-5d91-4f6f-84d9-640133df0522)


- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-01-03 10:46:03 -08:00
Luke Heath b1446b1ad8 Change deadline to next Tuesday (#25129) 2025-01-03 12:34:49 -06:00
Ian Littman 4fa2ef04f3 Repoint link to existing software install automation guide (#25116)
For #25076 (unreleased bug)
2025-01-03 12:20:05 -06:00
Gabriel Hernandez 69cef7c20b Chore UI more fixes scoped software label (#25118)
relates to #25067, #25061

includes two fixes for the scoped software via labels feature:

1. update the delete label modal copy
2. don't show the confirm changes modal if only the self service value
has changed.

- [x] Manual QA for all new/changed functionality
2025-01-03 17:36:42 +00:00
Eric ecab28b000 MSP Dashboard: Add Entra SSO Hook (#24740)
Related to: #24688

Changes:
- Added two new dependencies: `jsonwebtoken` and `@azure/msal-node`
- Added a new hook: `entra-sso`. A hook that replaces the default
authentication mechanism with Microsoft Entra SSO.
- Added a new action: signup-sso-user-or-redirect. This action finds or
creates user records for authenticated SSO users and attaches the user
record to the user's session.
- updated the is-logged-in policy to check if an SSO user's token is
still valid.
- Added a link to the account page to the app's header navigation.
2025-01-03 10:14:13 -06:00
Gabriel Hernandez b193f2dc1c add software_title_id to added_app_store_app activity (#25119)
relates to #24120

adds the `software_title_id` to the `added_app_store_activity`

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
2025-01-03 16:03:13 +00:00
RachelElysia 58afb100af Unreleased bug fix: Hide install options from editing software modal (#25122) 2025-01-03 10:24:51 -05:00
Gabriel Hernandez c237857f26 guide for automatical install for fleet maintinaed apps (#25042)
relates to #24681

Docs for the automatical install for fleet maintained apps.
2025-01-03 14:33:05 +00:00
RachelElysia 5eace25c69 Fleet UI: Fix software actions dropdown styling bug (#25102) 2025-01-03 09:32:31 -05:00
RachelElysia 645d4d8c25 Fleet UI: Clarify VPP app teams (#25111) 2025-01-03 09:31:25 -05:00
RachelElysia ece080fbe3 Fleet UI: Fix app id link not row id (#25113) 2025-01-03 09:30:59 -05:00
RachelElysia 97fc14da72 Fleet UI: Fix radio help text font size (#25105) 2025-01-03 09:29:56 -05:00
RachelElysia 486357326e Fleet UI: Update bad links in setup experience (#25110) 2025-01-03 09:29:38 -05:00
RachelElysia 4c076aef5b Fleet UI: Fix whatsapp icon being off 1px (#25112) 2025-01-03 09:28:43 -05:00
Ian Littman 40da87a7b5 Mention configurable query result set cap in query docs (#25082)
Noticed this hole in #25068. Fingers crossed the wording here matches
what folks will search when they need to bump the cap.

Also added query data discard config instructions for the UI, and moved
how-to-disable instructions to the bottom of the "View a query report"
section since users won't need those disclaimers until they have a few
queries set up.

Finally, dropped the mention of where an old UI was 25+ minor releases
ago.
2025-01-02 17:03:19 -06:00
Ian Littman 5892edf466 Add "should have a QA plan on the associated ticket" to PR checklist (#25053) 2025-01-02 15:41:19 -06:00
Victor Lyuboslavsky 0b9f36ad03 Enable MySQL 9.1 Go tests (#25055)
Enable MySQL 9 tests in the nightly Go test run.

The tests passed in my run:
https://github.com/fleetdm/fleet/actions/runs/12552738253/job/34999129651
2025-01-02 15:36:10 -06:00
Ian Littman 6014908ab6 Correct fix for long MSI interned strings (#25104)
h/t https://github.com/binref/refinery/issues/72, for #24720. No changes
file as this is an unreleased bug.

Also added output for version in the custom package parser tool.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2025-01-02 14:43:36 -06:00
jacobshandlingandJacob Shandling d3e6311989 UI – Fix team changing on queries table search query change (#25103)
## #25057 


![ezgif-6-d7867ea6c2](https://github.com/user-attachments/assets/462df801-389e-489e-8339-3b252bf24745)


- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-01-02 12:10:58 -08:00
Ian Littman 9eb115cf7c Ignore CVE-2024-10327 since it's iOS-only (#25083)
For #25075

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2025-01-02 13:07:02 -06:00
jacobshandlingandJacob Shandling 495fddc4e6 UI - Improve validation of SMTP settings form (#25051)
## #25009 

- Update validation to match pattern defined in
`frontend/docs/patterns.md`
- Validate email even when not enabling the feature, since we allow
setting it
- Remove "CONFIGURED" and "NOT CONFIGURED" copy

<img width="838" alt="Screenshot 2024-12-30 at 11 27 08 AM"
src="https://github.com/user-attachments/assets/42132ea2-3364-412a-bb35-2c35f9f6caea"
/>

<img width="838" alt="Screenshot 2024-12-30 at 11 27 16 AM"
src="https://github.com/user-attachments/assets/f9f3c1c0-a166-4ea0-aaa6-b356e7cf9c69"
/>

<img width="838" alt="Screenshot 2024-12-30 at 11 27 24 AM"
src="https://github.com/user-attachments/assets/8685d01d-b2ae-4bc5-addc-80b326f18863"
/>

<img width="706" alt="Screenshot 2024-12-30 at 11 44 10 AM"
src="https://github.com/user-attachments/assets/af8f0f5f-588f-4226-b7e7-8cf753f4822b"
/>



- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-01-02 10:30:41 -08:00
jacobshandlingandJacob Shandling 120f01ad1e Fix verify fleetd-base files > verify-fleetd-base-msi powershell script (#25064)
See failed workflow run
[here](https://github.com/fleetdm/fleet/actions/runs/12555703803)

- Fix the powershell script that was broken by `.yml` auto-format
- Exclude github workflow `.yml` files from prettier autoformating,
since they often contain non-yaml code as part of job definitions

- [ ] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2025-01-02 10:24:25 -08:00
Gabriel Hernandez 631af6b8bf Update secret error messages across the UI (#25085)
relates to #24550

more updates to the various secret error messages after some API changes

- [x] Manual QA for all new/changed functionality
2025-01-02 18:06:23 +00:00
Gabriel Hernandez f2a15bcec8 UI fixes to scoped software labels (#25094)
relates to #25062, 25063

quick fixes for UI issues with scoped software via labels feature.

- [x] Manual QA for all new/changed functionality
2025-01-02 18:06:13 +00:00
Ian Littman bbc35cb76b Include pre-releases when building osquery version list constant (#25089)
Also updates said constant via this script to include 5.15.0. Idea for
this is that including pre-releases as they're published ensures that by
the time the corresponding Fleet release ships we have a current list,
without having to cherry-pick these updates.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2025-01-02 11:38:15 -06:00
Ian Littman 425182c896 Cherry-Pick: Handle long interned strings in MSI parsing (#25096)
For #24720, merged into `main` via #25079.
2025-01-02 10:46:07 -06:00
Ian Littman 5beeb248f7 Handle long interned strings in MSI parsing (#25079)
For #24720. Used
https://github.com/ChaelChu/msi-props-reader/blob/master/src/msiPropsReader.ts
as inspiration. Not sure why the shift is 17 bits rather than 16 here
but confirmed that 17 works and 16 doesn't.

Tested against both existing GDrive MSIs for regression testing, plus
the one mentioned in the ticket.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2025-01-02 10:41:08 -06:00
Victor Lyuboslavsky 4c463b6c2f Use Render Redis service (#23056)
Use Render's Redis service in `render.yaml`

Successfully deployed on Render:
<img width="1009" alt="image"
src="https://github.com/user-attachments/assets/fdb79286-3336-4747-97c0-b75c7578c0e8"
/>
2025-01-02 10:07:54 -06:00
github-actions[bot]andlucasmrod 7ac39e23c9 Update versions of fleetd components in Fleet's TUF [automated] (#25088)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2025-01-02 11:43:29 -03:00
Lucas Manuel Rodriguez b73876878a Release osqueryd 5.15.0 (#25087) 2025-01-02 11:41:03 -03:00
Victor Lyuboslavsky eef175756a Removed invalid UUID error from Apple MDM UDID. (#25074)
#24961 

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2025-01-01 18:44:09 -06:00
Victor Lyuboslavsky feedb5070a Fix bug where DDM/Windows profiles with secrets were not being marked Verified. (#25065)
Fixing unreleased secret variables bug where DDM and Windows profiles
were not transitioning to Verified.
#23238 

# Checklist for submitter

- [x] Added/updated tests
- [x] If database migrations are included, checked table schema to
confirm autoupdate
- [x] Manual QA for all new/changed functionality
2025-01-01 18:43:02 -06:00
Ian Littman 5a30b477c6 Fall back to FileVersion when an EXE installer has FileVersion but not ProductVersion (#25070)
For #23541

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
2024-12-31 14:28:15 -06:00
Marko Lisica 43aec4722e Update docs codeowners while Rachael is out (#25058) 2024-12-31 16:11:57 +01:00
Victor Lyuboslavsky e7458b9daa Improve secret variables error on software upload. (#25052) 2024-12-30 18:46:42 -06:00
Victor Lyuboslavsky bd51e858ac Update Apple config/DDM profiles if secret variables changed (#24995)
#24900 

This PR includes and depends on PR #25012, which should be
reviewed/merged before this one.

Windows profiles are not included in this PR due to issue #25030

This PR adds the following functionality: Apple config/DDM profile is
resent to the device when the profile contains secret variables, and the
values of those variables have changed. For example.
- Upload secret variables
- Upload profile
- Device gets profile
- Upload the same profile
- Nothing happens
- Upload a different secret variable value
- Upload the same profile
- Device gets updated profile

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [x] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [x] Manual QA for all new/changed functionality
2024-12-30 17:58:39 -06:00
Luke Heath a42189e50d Update product group struture and capacity (#24800) 2024-12-30 15:34:07 -06:00
jacobshandlingandJacob Shandling 055c9a6e28 UI: Never show Software Details Modal > 'Install details' tab on My device page (#25029)
## Follow up for #23315

Since the `results` endpoint that the "Install details" tab for this
modal currently doesn't support device authentication (see below), only
show that tab on the host details page. Since the [original
request](https://github.com/fleetdm/fleet/issues/23252) for this feature
is for the "end user to be able to see the file path at which vulnerable
software is installed", delivering this work without the "Install
details" tab will still provide immediate value.

Once product weighs in on wether or not to include the Install details
tab here as well (requires opening up the `results` endpoint for device
authenticated requests), can add that functionality in a future
iteration. Figma for this ticket did not include the tab, so this PR is
assuming that's the intended funcitonality.

**Broken install details on My device page:**

<img width="966" alt="Screenshot 2024-12-27 at 12 13 11 PM"
src="https://github.com/user-attachments/assets/918ccd61-c792-4196-b348-749fc2839a66"
/>
 
**Same view with Install details removed:**
<img width="966" alt="Screenshot 2024-12-27 at 12 14 19 PM"
src="https://github.com/user-attachments/assets/2507d2df-21cb-4cd0-aaa1-53ad1b113135"
/>

**Confirmed "Install details" tab still available on host details
page:**
<img width="1224" alt="Screenshot 2024-12-27 at 12 21 40 PM"
src="https://github.com/user-attachments/assets/1d4631b9-9a61-42ba-8153-f390890b206a"
/>

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-12-30 13:07:35 -08:00
jacobshandlingandJacob Shandling fea4dd791a UI - Update targeted platforms display logic in the queries table (#25037)
### Unreleased bug where queries targeting all platforms display as
targeting no platforms in the Queries table.

The below query is set to target _all_ platforms.

**Bug:**
<img width="1248" alt="Screenshot 2024-12-29 at 8 24 50 PM"
src="https://github.com/user-attachments/assets/90c9a498-f7d8-4d86-88f1-061c985fb4fa"
/>

**Fix:**
Targeting all platforms, frequency set, displays platform icons:
<img width="1248" alt="Screenshot 2024-12-29 at 8 25 25 PM"
src="https://github.com/user-attachments/assets/d03c1bba-e5ea-461a-b506-1840cf4ffa8e"
/>

Targeting all paltforms but no frequency set (i.e., no schedule), no
targeted platforms displayed:
<img width="1248" alt="Screenshot 2024-12-29 at 8 25 38 PM"
src="https://github.com/user-attachments/assets/9b08a8c3-b682-4eb0-aeb4-59a6e0144e14"
/>

- [x] Manual QA for all new/changed functionality
- [x] Updated tests

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-12-30 13:06:59 -08:00
jacobshandlingandJacob Shandling ca37183e5c generate Slack notfication if any of the 3 verify fleetd-base steps fail (#25049)
## #24531 

These changes were approved by @lucasmrod
[here](https://github.com/fleetdm/fleet/pull/25019)

"<test - ignore me>" will not be present in real notifications 
<img width="652" alt="398807048-d208c9f8-999e-4c0a-a818-5e72570481ab"
src="https://github.com/user-attachments/assets/a06f63a8-e5b7-4b5a-881d-606b3e66c6d9"
/>

- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-12-30 12:46:50 -08:00
RachelElysia f0f6172ab7 Fleet UI: Delete policy copy change (#25050) 2024-12-30 14:24:06 -05:00
RachelElysia 0d7b3d70e2 Fleet docs: Update queries guides (#24991) 2024-12-30 14:14:34 -05:00
Victor LyuboslavskyandGabriel Hernandez 5f4400b55f Added ability to upload profiles with secret variables using the /configuration_profiles endpoint. (#25012)
Added ability to upload profiles with secret variables using the
/configuration_profiles endpoint.
#25011

# Checklist for submitter

- [x] If database migrations are included, checked table schema to
confirm autoupdate
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Gabriel Hernandez <ghernandez345@gmail.com>
2024-12-30 13:07:32 -06:00
Harrison RavazzoloandHarrison John 1b0a4466c8 Fleet Article: Using bioutil to verify Touch ID/biometric utilization (#25035)
Co-authored-by: Harrison John <harrisonjohn@Harrisons-MacBook-Pro.local>
2024-12-30 11:57:28 -07:00
Gabriel Hernandez 1a0d8409c9 integrate target selector with custom package form (#25041)
relates to #25040

quick integration on the custom package form with the new install type
section

- [x] Manual QA for all new/changed functionality
2024-12-30 18:18:21 +00:00
Jahziel Villasana-Espinoza bb44890f06 feat: add documentation for upcoming label scoping software feature (#25045)
> Related issue: #24555

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Manual QA for all new/changed functionality
2024-12-30 17:31:39 +00:00
jacobshandlingandJacob Shandling 47271bc284 UI - Prevent losing focus when searching queries by name (#25031)
## Follow up for #21855 


https://github.com/user-attachments/assets/b364a662-e2bc-4d3d-a4bc-de3d204c15c0

- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-12-30 08:17:56 -08:00
jacobshandlingandJacob Shandling c2bd802fa4 UI - Refactor to TooltipWrapper and add offset to the tooltips on hover of the profile aggregate status indicators (#25039)
## #25038 

Refactor to TooltipWrapper and add offset to the tooltips on hover of
the profile aggregate status indicators.

<img width="1345" alt="Screenshot 2024-12-29 at 9 00 38 PM"
src="https://github.com/user-attachments/assets/3bf5cf3c-e9fc-47dc-aa07-9cef42edcae0"
/>

- [x] Changes file added for user-visible changes in `changes/`, 
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2024-12-30 08:17:12 -08:00
Ian Littman 1725eff39c Allow software uninstalls, script-based lock/unlock/wipe, while scripts are globally disabled (#24815)
For #22875.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated tests
- [x] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [x] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [x] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [x] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [x] Manual QA for all new/changed functionality
2024-12-30 08:32:48 -06:00
Lucas Manuel Rodriguez 16d309ae40 Update policy queries for RPM/Debian based systems (#25026)
Docs update for #25021/#24385.
2024-12-30 10:17:40 -03:00