Commit Graph
1048 Commits
Author SHA1 Message Date
Zachary Wasserman 66e720d34d Reduce port scanning possibilities via SMTP configuration
The SMTP configuration could be used by an admin user to port scan the network
the Fleet server was running on. This commit reduces the information possible
to determine via this technique. A malicious admin can no longer determine
whether any TCP server is listening on a given port/address. They can only
determine ports and addresses where SMTP servers are running.

Thanks to 'quikke' for reporting this vulnerability.
2018-09-18 14:56:25 -04:00
Zachary Wasserman 7e26b915c5 Refactoring and fixes in user authorization
- Simplify/fix logic for authorization
- Rename/refactor for clarity
- Add tests for auth related code
2018-09-18 14:56:25 -04:00
Zachary Wasserman 5cbaa9cb9f Prevent non-admin users from modifying other users
An incorrect authorization check allowed non-admin users to modify the details of other users. We now enforce the appropriate authorization so that unprivileged users can only modify their own details.

Thanks to 'Quikke' for the report.
2018-09-18 14:56:25 -04:00
Zachary Wasserman 21269b1dd8 Prevent escalation of user privileges via ModifyUser method
The ability to modify a users admin and enabled status was erroneously left in
place during development of https://github.com/kolide/fleet/pull/959. To
mitigate a privilege escalation vulnerability we need to ensure those values
can only be modified through the explicit methods.

This patch includes a unit test and fix for the vulnerability.

Thanks to 'Quikke' for submitting this vulnerability.
2018-09-18 14:56:25 -04:00
Zachary Wasserman e011cfc464 Delete packs that have already been soft-deleted (#1924)
We no longer use soft deletion, so this commit introduces a migration that hard
deletes existing deleted packs.

Fixes #1923
2018-09-12 17:50:30 -07:00
Zachary Wasserman 94f5ee7832 Fix bug preventing rename of queries scheduled in packs (#1921)
Change the foreign key constraint to automatically update the query name as
appropriate.

Fixes #1917
2018-09-12 11:25:35 -07:00
Zachary Wasserman 686e8516e6 Add MySQl version information to infra docs (#1919) 2018-09-11 10:56:14 -07:00
Zachary Wasserman 79b2249e69 Allow update of settings page without enabling SMTP (#1903)
Fixes #1871
2018-09-07 15:37:35 -07:00
Thordur Bjornsson 832365c1d4 Fleetctl query improvements (#1888)
- Exit when all targeted hosts have responded
- Pause the spinner when outputting logs so that output is cleaner
2018-09-07 15:37:10 -07:00
Allen Golbig cf84bd9d8e Added KeepAlive and ThrottleInterval (#1916) 2018-09-05 16:18:51 +00:00
Caleb Coy 60bd9157b6 convert rocker button to standard buttons (#1906) 2018-08-29 10:38:43 -04:00
Zachary Wasserman b220aa23e6 Remove reference to quickstart in documentation (#1905) 2018-08-17 09:21:11 -07:00
Jeremy Rossi 473dc3e265 Add --quiet and --exit arguments for fleetctl query (#1887)
--quiet will disable all printing other than errors and results
--exit will quit and exit when 100% online hosts have returned results
2018-08-16 15:31:18 -07:00
Zachary Wasserman bb789b4932 Display errors on password reset page (#1902)
Fixes #1885
2018-08-16 11:25:42 -07:00
Zachary Wasserman 71e8e3917e Update changelog for RC4 release (#1901) 2018-08-14 16:54:23 -07:00
Zachary Wasserman ece5e6cda9 Fix pack targets handling in UI (#1898)
Now targets should be updated to exactly what is displayed in the UI.

Fixes #1827
2018-08-14 12:14:24 -07:00
Zachary Wasserman dfac039422 Fix targeting packs to individual hosts (#1897)
Packs can be targeted to individual hosts through the UI. This was supported
previously and was broken with refactoring in Fleet 2.0.

There is currently no support in the fleetctl format for targeting individual
hosts, but this could be added at a later date.

Fixes #1878
2018-08-13 10:07:10 -07:00
Chris Helming 4729789943 Trim whitespace from X509 certificate (#1900) 2018-08-10 12:42:35 -07:00
Zachary Wasserman 386bb8a9b9 Add fleetctl to generated Docker images (#1896) 2018-08-08 16:21:49 -07:00
Zachary Wasserman 54f62183ee Run make generate before make docker-build-release (#1891)
Ensure that assets are compiled before building Docker images. In the past we
have accidentally published images that were lacking assets.
2018-08-06 10:55:32 -07:00
Mike Arpaia ea4ede299a Add osquery table data from master (#1884)
This was generated via:

```
python ~/git/osquery/tools/codegen/genapi.py > ~/go/src/github.com/kolide/fleet/frontend/osquery_tables.json
```

close #1883
2018-08-06 11:30:50 -06:00
Zachary Wasserman 45ab398a6e Add kolide-fleet-chart to community section of README (#1889)
Closes #1874
2018-08-03 11:38:08 -07:00
Caleb Coy e4b076acc6 Update color scheme to match Kolide branding (#1879) 2018-07-30 06:01:27 -07:00
Zachary Wasserman 6bdddfacf0 Expose API Token in UI (#1868)
Useful for SAML login users who cannot log in with `fleetctl login`. Instead
they can pull their session token from the UI and configure the fleetctl client
to use it.

Closes #1865
2018-07-17 11:27:30 -07:00
Zachary Wasserman ea744709e0 Fix handling of missing scheduled query parameters in UI (#1870)
The UI previously expected these parameters to be set, but instead we can
massage the data appropriately (because they are not required to be set by
fleetctl).

Fixes #1869
2018-07-17 10:03:31 -07:00
Zachary Wasserman 614fc9d3c5 Confirm password on setup (#1866) 2018-07-16 10:03:50 -07:00
Zachary Wasserman e62d2f57df Improve error message when client is not logged in (#1867) 2018-07-16 09:35:21 -07:00
Mike Arpaia 626cda2d4f Add the scheduling queries doc back to the repo (#1862) 2018-07-12 10:08:37 -06:00
Zachary Wasserman a7dd64fb0b Fix newline handling in fleetctl convert (#1856)
Previously we stripped all non-word characters which worked for some cases, but
removed necessary characters in others. What we really want (and now do) is to
remove only whitespace characters.

Fixes #1854
2018-06-28 12:02:46 -07:00
Zachary Wasserman 88cc73e4ca Fix errors and clarify docs on config platform overrides (#1855)
Closes #1846
2018-06-28 12:02:31 -07:00
Zachary Wasserman 293ca56040 Fix error when migrating packs and scheduled query has been deleted. (#1851)
Fixes #1850
2018-06-26 09:54:45 -07:00
Zachary Wasserman 87fd9a2c8b Update favicon with flat Kolide logo (#1849) 2018-06-26 09:13:40 -07:00
Zachary Wasserman 06832697d0 Fix deletion of labels in UI (#1848)
- Add endpoint for deletion of label by ID
- Use ID endpoint from frontend JS

Fixes #1847
2018-06-25 13:56:59 -07:00
Mike Arpaia 8b7edf759d Add release notes for 2.0.0-rc3 (#1844) 2018-06-21 18:33:03 -06:00
Zachary Wasserman 08a2dc73cd Fix bugs with packs created in UI (#1843)
- Delete duplicate queries in packs created by the UI (because the duplicates
  were causing undefined behavior). Now it is not possible to schedule
  duplicates in the UI (but is in fleetctl).
- Fix bug in which packs created in UI could not be loaded by fleetctl.
2018-06-21 17:06:44 -07:00
Zachary Wasserman 4ade65b4c1 Fix deletion of queries referenced by foreign key (#1842)
- Add cascading deletes for scheduled_queries when queries are deleted
- Also add cascading deletes for scheduled_queries when packs are deleted

Fixes #1837
2018-06-20 17:32:43 -07:00
Zachary Wasserman de4e744b80 Fix All Hosts label in docs (#1841) 2018-06-20 10:07:42 -07:00
Zachary Wasserman c4f2850e38 Remove erroneously committed API binary (#1835) 2018-06-18 11:26:11 -07:00
Zachary Wasserman 738f3d0195 Update changelog for Fleet 2.0 RC2 release (#1834) 2018-06-18 11:19:48 -07:00
Zachary Wasserman 6424a029ee Fix labels UI issues in Fleet 2.0 (#1830)
Replaces the UI endpoints for creating and modifying labels. These were removed
in #1686 because we thought we were killing the UI.

Now labels can be created and edited in the UI again.
2018-06-18 10:09:08 -07:00
Zachary Wasserman 34a8b9ee53 Fix newline handling while converting osquery JSON (#1831)
Fixes #1828
2018-06-18 10:08:23 -07:00
Fritz ece499d2f6 Add workspace preparation instructions (#1833)
Individuals unaccustomed to building Go projects from source may encounter difficulties cloning into the repo if they choose an arbitrary directory not in ~/go/src. Attempting to build the repo elsewhere will result in the `make deps` command failing. This change adds workspace prep instructions.
2018-06-18 09:23:52 -06:00
Adam Guenther 8f0131cc1d Update fleet-on-centos.md (#1832)
-Updated cp to reflect addition of fleetctl to archive
-Updated MySQL setup to reflect setting root password when installed from .rpm and taking into account password validation requirement defaults.
-Updated echo command with sudo tee due to permission denied
2018-06-17 10:00:26 -06:00
Caleb Coy cc11ba1deb Fix link to readme for osquery configuration(#1826) 2018-06-15 11:26:34 -04:00
adamguenther ead1a1bdab Update fleet-on-ubuntu.md (#1825)
- Updat binary names to reflect binaries in latest archive
- Add line to 'sudo cp fleet/linux/fleetctl  /usr/bin/fleetctl
- Change echo string for enroll_secret to use sudo tee due to permission denied
2018-06-15 11:24:41 -04:00
Zachary Wasserman 0b7747bef0 Fix pack and query UI issues in Fleet 2.0 (#1829)
Replaces (and appropriately refactors) a number of endpoints that were removed long ago when we decided to kill the UI with the fleetctl release. We turned out not to do this, and now need to restore these missing endpoints.

This is not a straight up replacement of the existing code because of refactoring to the DB schemas that was also done in the migration.

Most of the replaced code was removed in #1670 and #1686.

Fixes #1811, fixes #1810
2018-06-15 10:13:11 -04:00
Zachary Wasserman 6eecaa1019 Update redigo import (#1821)
- Use new repo path (old repo archived)
- Update version to 2.0.0

Closes #1820
2018-06-11 12:14:21 -07:00
Mike Arpaia c91a031d3e Attempt 2 at returning a serializable config (#1819) 2018-06-11 11:34:05 -06:00
Zachary Wasserman f8796bc55b Fix timezone in MySQL connection string (#1818)
Fixes #1643
2018-06-11 07:31:39 -07:00
Mike Arpaia 4ddb691524 Remove -f from fleetctl query (#1814)
close #1812
2018-06-04 22:28:49 -06:00