Commit Graph
903 Commits
Author SHA1 Message Date
Ian Littman fdc0c0b92d Clarify GitOps changes checkboxes in story template (#30411)
Also swaps some items to TODO so it's easier to search for "TODO" to
spot when a story isn't fully filled out.
2025-06-30 11:17:36 -05:00
Martin Angers 639cbb510b Prevent starting browser in fleetctl preview (#30424) 2025-06-30 10:41:42 -04:00
Ian Littman dfaad610d9 Remove unneeded exposed ports on osquery-in-a-box minio to avoid host-port conflicts (#30416)
Also ensures we run integration tests when docker-compose files used by
`fleetctl preview` are changed, so we don't merge any more test failures
due to those.
2025-06-29 12:40:17 -05:00
Lucas Manuel Rodriguez b81c6b7940 Release osqueryd 5.18.1 (#30348) 2025-06-26 18:35:50 -03:00
Lucas Manuel Rodriguez 3630c777d6 Pin version of cloudflared to 2025.5.0 (#30179)
CI is failing with:
```
Selecting previously unselected package cloudflared.
(Reading database ... 219352 files and directories currently installed.)
Preparing to unpack cloudflared-linux-amd64.deb ...
Unpacking cloudflared (2025.6.1) ...
Setting up cloudflared (2025.6.1) ...
Processing triggers for man-db (2.12.0-4build2) ...
error parsing tunnel ID: fleet-test-81a7ab03-3e62-43a2-bdc0-8470dbdca600 is neither the ID nor the name of any of your tunnels
Awaiting tunnel ready...
failed to create tunnel: Unknown output format 'default'
Awaiting tunnel ready...
Awaiting tunnel ready...
[...]
```
E.g.:
https://github.com/fleetdm/fleet/actions/runs/15746535584/job/44417207764?pr=30140

It's hard to troubleshoot what's going on with the latest version
without good credentials, so we will pin the version for now as a
workaround.
2025-06-20 13:20:19 -03:00
Ian Littman 79d5e605ed Fail CI if Markdown files have "here" or "click here" as link anchors (#30027)
Also includes fixes for outstanding failing links. See earlier builds
for proof that this is catching problems.

For #30019.
2025-06-19 10:12:31 -05:00
Benjamin EdwardsandHarrison Ravazzolo e3711d0b11 added env vars for webhook osquery results logging destination (#29809)
Update dogfood deployment to utilize webhooks for the osquery results
logging destination configuration

@BCTBB already added a tines.io webhook URL to the repo secrets
`DOGFOOD_WEBHOOK_URL` where the value was provided by @harrisonravazzolo

Co-authored-by: Harrison Ravazzolo <38767391+harrisonravazzolo@users.noreply.github.com>
2025-06-16 10:22:31 -05:00
Luke Heath 5dc0171124 Move GitHub token to correct step (#30022) (#30023) 2025-06-14 14:36:03 -05:00
Luke Heath 442b66b87f Update goreleaser env vars (#30021) 2025-06-14 13:31:30 -05:00
Lucas Manuel Rodriguez ad0038f319 Update dependency-review-action (#29910)
Action is currently broken on all PRs.
2025-06-11 11:15:48 -03:00
Sam Pfluger f86883532d Fix label (#29913) 2025-06-11 08:56:14 -05:00
Jahziel Villasana-Espinoza 9d2b07f76f add a test that checks collation on new migrations (#29309)
> closes #26403

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [x] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
2025-05-29 17:00:30 -04:00
Lucas Manuel Rodriguez a674a01144 Use build date for version for local TUF orbits (#29442)
Two new improvements for local TUF after feedback from @iansltx and QA
folks:

1. The static `42` was confusing when making or sharing several builds
of locally built fleetd. Locally TUF-built version of orbit will now be:
`YY.MM.XXXXX`, e.g. `25.5.56178` (patch version is a 16-bit number made
from day, hour and minute).
2. Also prompting user to delete `test_tuf` which is usually a source of
confusion/errors.
2025-05-28 17:13:58 -03:00
Scott Gress 8c21f1c35b Add GitOps section to PR template (#29368) 2025-05-22 12:07:38 -05:00
Janis Watts 0b452982a7 Update Smoke test template (#29348)
Update Smoke test template with additional load testing instructions for
performance testing migrations
2025-05-22 10:38:37 -05:00
681b5d4353 Update changelog for fleetd 1.42.0 release (#29186)
Co-authored-by: Luke Heath <luke@fleetdm.com>
Co-authored-by: Scott Gress <scott@fleetdm.com>
2025-05-19 08:22:30 -03:00
Luke Heath 7380919dc3 Organize contributor docs and establish ADR process and template (#29101) 2025-05-17 15:03:52 -05:00
Ian Littman 3434db7bce Drop QA plan checkbox in PR template now that User Story Review exists as a QA checkpoint (#29036) 2025-05-12 16:52:45 -05:00
Ian Littman f6d929861c Drop assignees from FMA automated PRs (#29049)
Due to modifications in the Fleet-maintained apps update process,
#g-software engineers are no longer the DRIs for moving update PRs
along.
2025-05-12 12:54:38 -05:00
Victor Lyuboslavsky 1ffcc21450 Reducing "waiting for mysql" timeout to 1 minute to speed up dev feedback. (#28935)
I'm seeing it takes ~10 seconds to MySQL to come up, so 1 minute should
be plenty. 5 minutes was too long to wait.
2025-05-07 16:17:22 -05:00
Victor Lyuboslavsky 2d5ac35578 Improving "Wait for mysql" in Go tests. (#28901)
For #28902

Modified the GitHub Actions workflow to prevent it from hanging at the
"waiting for mysql..." step. The updated workflow now:

- Times out after 5 minutes of unsuccessful MySQL connection attempts
- Logs all connection attempts with timestamps and error messages when a
timeout occurs
- Dumps MySQL container logs when a timeout occurs, providing valuable
diagnostic information
- Automatically stops and restarts all Docker containers using the same
command as the original "Start Infra Dependencies" step
- Retries this process up to 5 times before failing the job
2025-05-07 10:17:53 -05:00
Lucas Manuel Rodriguez bfe3b186d3 Fix detected CVEs and docker scout exit code to fail the Github Action (#28836)
For #28837.

Fixing this all of this because we got multiple reports from the
community and customers and these were also detected by Amazon
Inspector.

- Fixes CVE-2025-22871 by upgrading Go from 1.24.1 to 1.24.2.
- `docker scout` now fails the daily scheduled action if there are
CRITICAL,HIGH CVEs (we missed setting `exit-code: true`).
- Report CVE-2025-46569 as not affected by it because of our use of
OPA's go package.
- Report CVE-2024-8260 as not affected by it because Fleet doesn't run
on Windows.
- The `security/status.md` shows a lot of changes because we are now
sorting CVEs so that newest come first.

---

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [ ] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Make sure fleetd is compatible with the latest released version of
Fleet (see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/fleetd-development-and-release-strategy.md)).
- [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
- [ ] For unreleased bug fixes in a release candidate, confirmed that
the fix is not expected to adversely impact load test results or alerted
the release DRI if additional load testing is needed.
2025-05-06 13:35:27 -03:00
Noah Talerman 898648ee82 Update story template (#28793)
- Add Engineer to contact
2025-05-05 13:53:54 -04:00
Noah Talerman eec0722f3b Update story template (#28773) 2025-05-02 21:40:16 -05:00
Victor Lyuboslavsky dd10a417ec Replacing MySQL 8.4 with MySQL 9.X in our regular (every commit) tests. (#28777)
Replacing MySQL 8.4 with MySQL 9.X in our regular (every commit) tests
to speed up dev feedback. The MySQL 8.4 tests will still run nightly.

The vulnerability feed download CI fails below are not related to this
change.
2025-05-02 17:24:24 -05:00
Jordan Montgomery c97a0e2363 Fix Windows lint issues and enable linting on Windows (#28704)
For https://github.com/fleetdm/fleet/issues/9943

This will help us avoid issues like this where the log message never
worked right:
https://github.com/fleetdm/fleet/pull/28296#discussion_r2047505191

Most of the changes are no-op type changes like removing unneeded
typecast or disabling gosec on reviewed lines of code

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Make sure fleetd is compatible with the latest released version of
Fleet (see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/fleetd-development-and-release-strategy.md)).
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2025-05-02 16:11:26 -04:00
Victor Lyuboslavsky 3d3d43864a Bumping MySQL 8.4.3->8.4.5 and 9.1.0->9.3.0 in tests. (#28767)
I forced a test run on 9.3.0 (which only runs nightly be default).
2025-05-02 13:40:11 -05:00
Allen Houchins 0ec3f98dd7 Updated reviewers list (#28703)
- Removed Luke and Noah from reviewers list now that we have multiple
people reviewing changes
2025-04-30 14:24:57 -05:00
Noah Talerman 251347c6f8 Update air-guitar.md (#28683)
- Add story label
2025-04-30 09:42:46 -05:00
Noah TalermanandEugene e761f85b27 Update dogfood.md (#28603)
Remove "issue" from the name

---------

Co-authored-by: Eugene <eugene@fleetdm.com>
2025-04-28 18:29:12 +04:00
Eugene 33c3135bb5 Create dogfood.md (#28602)
Creating an issue template for dogfood stories. Product designers create
these during confirm and celebrate to test final developed stories.
2025-04-28 10:25:36 -04:00
Lucas Manuel Rodriguez 004027cca2 Add wait to fleet-and-orbit.yml until fleet and tunnel are responding (#28508)
Similar to the fix for https://github.com/fleetdm/fleet/issues/26349.
2025-04-23 19:07:36 -03:00
Lucas Manuel Rodriguez 0ebcf788ad Update SSO settings for dogfood (#28435)
- `issuer_uri` and `enable_jit_role_sync` are deprecated (see
https://github.com/fleetdm/fleet/issues/10688)
- Setting `enable_sso_idp_login` to allow testing logins initiated from
Google.
2025-04-22 10:40:34 -05:00
Lucas Manuel Rodriguez 5da0008872 Fix code scanning alert for not pinned actions (#28305)
Fixes https://github.com/fleetdm/fleet/security/code-scanning/1381.
2025-04-16 16:35:13 -05:00
Lucas Manuel Rodriguez 243ca206bf Fix tagging of fleetdm/fleet and fleetdm/fleetctl when releasing (#28251)
For #26988.
2025-04-16 15:48:47 -03:00
Lucas Manuel Rodriguez 68ee136e3b Release osqueryd 5.17.0 (#28294) 2025-04-16 15:25:26 -03:00
Lucas Manuel Rodriguez 3c86055139 Add wait until fleet is responding (#28241)
For #26349.
2025-04-16 13:11:03 -03:00
Lucas Manuel RodriguezandSharon Katz 895194d63b Add scanning to released images and process to track vulnerabilities (#28087)
For #25902.

---------

Co-authored-by: Sharon Katz <121527325+sharon-fdm@users.noreply.github.com>
2025-04-16 11:50:10 -03:00
Victor Lyuboslavsky 229b51ff5b Report aggregate results immediately after test-go matrix runs. (#28123)
Report aggregate results immediately after test-go matrix runs
2025-04-11 14:05:19 -05:00
Dante CatalfamoandLucas Rodriguez 94f6127edc Orbit for Windows ARM64 (#27882)
#27275 and #27274

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Make sure fleetd is compatible with the latest released version of
Fleet (see [Must
rule](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/fleetd-development-and-release-strategy.md)).
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Lucas Rodriguez <lucas@fleetdm.com>
2025-04-11 10:18:28 -04:00
Sam Pfluger 6d0c49d70f Create article issue template (#28040) 2025-04-10 17:55:40 -05:00
Victor Lyuboslavsky 5a549a3d03 Mark test-go failed if one test failed. (#28052) 2025-04-09 17:39:47 -05:00
Noah Talerman fcf1a73d6c Delete test feature request issue template (#28030)
- Remove test issue template
2025-04-09 10:54:01 -04:00
Marko Lisica ed9bb83352 Add feature-request.yml template (#28029)
We're testing .yml templates, so we can add default project to issue
template
2025-04-09 16:50:48 +02:00
Noah Talerman cf9759973b Create feature-request.md (#28027)
@noahtalerman: I broke the issue template by changing it to YAML
2025-04-09 10:40:56 -04:00
Noah Talerman 24677b5720 Update feature-request issue template to YAML (#28026)
For GitHub projects dry run 🤞
2025-04-09 10:36:59 -04:00
Noah Talerman bc9b4547cd Update feature-request issue template (#28025)
It's reported that the `projects:` key doesn't work in markdown (.md)
issue templates:
https://github.com/orgs/community/discussions/9687#discussioncomment-12573283
2025-04-09 10:15:44 -04:00
Noah Talerman 4686b58b89 Update feature-request.md (#28024)
No array for projects if there's 1?
2025-04-09 10:10:29 -04:00
Noah Talerman fb44c3cac8 Update feature-request.md (#28023)
Maybe the project has to be public?
2025-04-09 10:07:49 -04:00
Noah Talerman a43db3fd4a Update feature-request issue template (#28020)
Projects use IDs:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
2025-04-09 10:02:37 -04:00