Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr149] Rely on //chrome/browser/ui/test:dialog

Browse Source 
This the componentisation of these files, we do not need anymore to
include these sources ourselves in `brave_browser_tests`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/e0cd9afb25e911c62c8c096ef55816bd9e3b665e

commit e0cd9afb25e911c62c8c096ef55816bd9e3b665e
Author: Tiago Vignatti <tvignatti@igalia.com>
Date:   Thu Apr 9 07:28:31 2026 -0700

    Componentize chrome/browser/ui/test/

    This changes create chrome/browser/ui/test/BUILD.gn with dedicated
    targets for all test files in this directory, which were previously
    scattered across chrome/test/BUILD.gn and chrome/browser/ui/BUILD.gn.
    Some of the files were duplicated in multiple targets, and has now
    fixed.

    New targets:
    - :dialog — moved from //chrome/test:test_support and de-duplicated from
      browser_tests/interactive_ui_tests
    - :closed_waiter — moved from //chrome/test:test_support_ui
    - :test_support — de-duplicated and moved from browser_tests,
      interactive_ui_tests, and //chrome/browser/ui:test_support
    - :confirm_bubble — moved from //chrome/browser/ui:test_support
    - :browser_tests — browser test files
    - :interactive_ui_tests — interactive UI test files
    - :app_window — moved from //chrome/browser/ui:test_support

    Bug: 353332589
    Change-Id: I602615d0b8a96af88af82cf1caaf75a3a2184d07
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7704138
    Reviewed-by: Darryl James <dljames@chromium.org>
    Commit-Queue: Tiago Vignatti <tvignatti@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#1612208}
This commit is contained in:
Claudio DeSouza
2026-05-22 16:18:03 -04:00
committed by Max Karolinskiy
parent 0e4e07ea90
commit 3b0f99edcf
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/android_browser_tests.gni
-4
View File
@@ -50,10 +50,6 @@ android_test_exception_sources = [
"//chrome/browser/extensions/extension_browsertest.h",
"//chrome/browser/media/media_browsertest.cc",
"//chrome/browser/media/media_browsertest.h",
"//chrome/browser/ui/test/test_browser_dialog.cc",
"//chrome/browser/ui/test/test_browser_dialog.h",
"//chrome/browser/ui/test/test_browser_ui.cc",
"//chrome/browser/ui/test/test_browser_ui.h",
]
if (enable_brave_wallet) {
test/BUILD.gn
-4
View File
@@ -939,10 +939,6 @@ test("brave_browser_tests") {
"//chrome/browser/extensions/extension_browsertest.h",
"//chrome/browser/media/media_browsertest.cc",
"//chrome/browser/media/media_browsertest.h",
"//chrome/browser/ui/test/test_browser_dialog.cc",
"//chrome/browser/ui/test/test_browser_dialog.h",
"//chrome/browser/ui/test/test_browser_ui.cc",
"//chrome/browser/ui/test/test_browser_ui.h",
]
deps = [