Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr148][Android] DropdownCommonProperties removed

Browse Source 
SuggestionCommonProperties is used instead

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/fdf1ac3a145796f9cb1e3c8a72a639506d18a6e0

commit fdf1ac3a145796f9cb1e3c8a72a639506d18a6e0
Author: Charles Cai <charlesyc@google.com>
Date:   Mon Mar 30 17:42:35 2026 -0700

    Refactor Omnibox suggestion properties into a single common class

    This CL merges `DropdownCommonProperties` into
    `SuggestionCommonProperties`. This unifies the property definitions for
    Omnibox suggestions into a single location to simplify property model
    management. This is a pure data-layer refactoring that prepares the
    architecture for migrating UI elements like headers and group separators
    to ItemDecorations.

    Bug: 491220357
    Change-Id: Ie531dc38e9e53b5829060ae1a7f49c014061f409
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7708772
    Commit-Queue: Charles Cai <charlesyc@google.com>
    Reviewed-by: Tomasz Wiszkowski <ender@google.com>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1607509}
This commit is contained in:
AlexeyBarabash
2026-04-27 12:00:59 +01:00
committed by Claudio DeSouza
parent c6fa7e3e00
commit 6a680adf32
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/BraveDropdownItemViewInfoListBuilder.java
+6 -5
View File
@@ -163,16 +163,17 @@ class BraveDropdownItemViewInfoListBuilder extends DropdownItemViewInfoListBuild
viewInfoList
.get(viewInfoList.size() - 1)
.model
.set(DropdownCommonProperties.BG_BOTTOM_CORNER_ROUNDED, false);
.set(SuggestionCommonProperties.BG_BOTTOM_CORNER_ROUNDED, false);
viewInfoList
.get(viewInfoList.size() - 1)
.model
.set(DropdownCommonProperties.SHOW_DIVIDER, true);
.set(SuggestionCommonProperties.SHOW_DIVIDER, true);
}
leoModel.set(DropdownCommonProperties.BG_TOP_CORNER_ROUNDED, viewInfoList.size() == 0);
leoModel.set(DropdownCommonProperties.BG_BOTTOM_CORNER_ROUNDED, true);
leoModel.set(DropdownCommonProperties.SHOW_DIVIDER, false);
leoModel.set(
SuggestionCommonProperties.BG_TOP_CORNER_ROUNDED, viewInfoList.size() == 0);
leoModel.set(SuggestionCommonProperties.BG_BOTTOM_CORNER_ROUNDED, true);
leoModel.set(SuggestionCommonProperties.SHOW_DIVIDER, false);
viewInfoList.add(
tileNavSuggestPosition,