Disable flaky InstallableManagerBrowserTest.CheckFavicon and add ASAN filter support (#33777)
Add InstallableManagerBrowserTest.CheckFavicon to browser_tests.filter to disable this flaky upstream test. The test intermittently fails due to favicon fetch timing issues. Already disabled on Mac upstream (crbug.com/333331507). Also add ASAN filter support to getApplicableFilters() in testUtils.js, which was missing (only UBSAN and MSAN were supported). Resolves https://github.com/brave/brave-browser/issues/52659
This commit is contained in:
@@ -84,6 +84,10 @@ const getApplicableFilters = (config, suite) => {
|
||||
possibleFilters.push([suite, targetPlatform, 'ubsan'].join('-'))
|
||||
}
|
||||
|
||||
if (config.is_asan) {
|
||||
possibleFilters.push([suite, targetPlatform, 'asan'].join('-'))
|
||||
}
|
||||
|
||||
if (config.is_msan) {
|
||||
possibleFilters.push([suite, targetPlatform, 'msan'].join('-'))
|
||||
}
|
||||
|
||||
@@ -3506,3 +3506,8 @@
|
||||
# covering this - safe to disable the upstream one.
|
||||
# For more info, see https://github.com/brave/brave-browser/issues/46011
|
||||
-SecureDnsHandlerTest.OtherPoliciesSet
|
||||
|
||||
# https://github.com/brave/brave-browser/issues/52659
|
||||
# Flaky favicon fetch failure. Also disabled on Mac upstream
|
||||
# (crbug.com/333331507).
|
||||
-InstallableManagerBrowserTest.CheckFavicon
|
||||
|
||||
Reference in New Issue
Block a user