[cr146][Android] Plumb PromptOptions through PermissionPromptAndroid
Chromium change: https://source.chromium.org/chromium/chromium/src/+/d383d17c542efef6c305d73882a540caed0db057 [permissions] Plumb PromptOptions through PermissionPromptAndroid This CL is part of a chain of CLs removing PromptOptions from PermissionRequest and instead plumbing it through the code, see https://crbug.com/465377277 for more context. This CL plumbs PromptOptions through the c++ logic for the permission prompt on Android, delaying the point at which PermissionRequestManager::SetPromptOptions is called, and hence making it easier to remove that method in a later CL. Note how this change highlights immediately that the quiet prompt does not currently allow to choose between approximate and precise location: we would have noticed it right away if we had plumbed the PromptOptions through right away. Bug: 450752868, 430494523, 465377277 Change-Id: I636b8f7be61b18f3bdb6a7a555e68137d4427c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7416297
This commit is contained in:
@@ -61,7 +61,7 @@ void BraveWalletPermissionPrompt::Delegate::Closing() {
|
||||
if (!permission_prompt_) {
|
||||
return;
|
||||
}
|
||||
permission_prompt_->Dismiss();
|
||||
permission_prompt_->Dismiss(/*prompt_options=*/std::monostate());
|
||||
}
|
||||
|
||||
BraveWalletPermissionPrompt::Delegate::~Delegate() {
|
||||
|
||||
Reference in New Issue
Block a user