Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr146] Disable URL sanitizer tests on Mac due to focus-related flakiness

Browse Source 
Clipboard write access requires document focus, but waiting for document focus
is flakey on Mac. Several upstream tests are disabled on Mac due to this issue.

For example, see
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/controlled_frame/controlled_frame_permission_request_browsertest.cc;l=242-250
This commit is contained in:
Emerick Rogul
2026-02-26 14:14:52 +00:00
committed by Claudio DeSouza
parent 9bc87592f8
commit a534dfc5ec
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/url_sanitizer/url_sanitizer_browsertest.cc
+8 -2
View File
@@ -233,10 +233,16 @@ class DisabledURLSanitizerTest : public URLSanitizerTestBase {
DisabledURLSanitizerTest() : URLSanitizerTestBase(false) {}
};
IN_PROC_BROWSER_TEST_F(EnabledURLSanitizerTest, JSApi) {
// These tests require document focus, and waiting for focus is flaky on mac.
#if BUILDFLAG(IS_MAC)
#define MAYBE_JSApi DISABLED_JSApi
#else
#define MAYBE_JSApi JSApi
#endif
IN_PROC_BROWSER_TEST_F(EnabledURLSanitizerTest, MAYBE_JSApi) {
Check();
}
IN_PROC_BROWSER_TEST_F(DisabledURLSanitizerTest, JSApi) {
IN_PROC_BROWSER_TEST_F(DisabledURLSanitizerTest, MAYBE_JSApi) {
Check();
}