fix dev cert signing for non official builds

build/commands/lib/config.js

@@ -476,7 +476,7 @@ Config.prototype.buildArgs = function () {
 
 Config.prototype.shouldSign = function () {
   if (this.skip_signing ||
-    this.buildConfig !== 'Release' ||
+    this.isComponentBuild() ||
     this.targetOS === 'ios') {
     return false
   }

build/config.gni

@@ -8,7 +8,7 @@ declare_args() {
   # "nightly" for nightly channel release.
   # "" for stable channel release.
   brave_channel = ""
-  is_release_channel = true
+  is_release_channel = false
   base_sparkle_update_url = ""
   enable_sparkle = is_official_build && is_mac
 

script/signing_helper.py

@@ -143,6 +143,11 @@ def GetBraveSigningConfig(config_class, mac_provisioning_profile=None):
             """ Not chrome branded """
             return False
 
+        @property
+        def distributions(self):
+            """ Brave distribution """
+            return [model.Distribution(channel=brave_channel)]
+
     config_class = ConfigNonChromeBranded
 
     if mac_provisioning_profile is not None:
@@ -169,9 +174,4 @@ def GetBraveSigningConfig(config_class, mac_provisioning_profile=None):
             """ Run spctl check """
             return True
 
-        @property
-        def distributions(self):
-            """ Brave distribution """
-            return [model.Distribution(channel=brave_channel)]
-
     return ProvisioningProfileCodeSignConfig