Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add "no" answer to default daily metric (#33413)

Browse Source
This commit is contained in:
Darnell Andries
2026-01-26 21:25:48 +00:00
committed by GitHub
parent 4d53222381
commit b9955dbe72
4 changed files with 7 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/misc_metrics/default_browser_monitor.cc
+2 -6
View File
@@ -62,12 +62,8 @@ void DefaultBrowserMonitor::OnDefaultBrowserStateReceived(bool is_default) {
cached_default_status_ = is_default;
int typical_answer = is_default ? 1 : 0;
int express_answer = is_default ? 1 : (INT_MAX - 1);
UMA_HISTOGRAM_EXACT_LINEAR(kDefaultBrowserHistogramName, typical_answer, 2);
UMA_HISTOGRAM_EXACT_LINEAR(kDefaultBrowserDailyHistogramName, express_answer,
2);
UMA_HISTOGRAM_BOOLEAN(kDefaultBrowserHistogramName, is_default);
UMA_HISTOGRAM_BOOLEAN(kDefaultBrowserDailyHistogramName, is_default);
if (status_changed) {
for (auto& observer : observers_) {
components/misc_metrics/default_browser_monitor.h
+1 -1
View File
@@ -21,7 +21,7 @@ namespace misc_metrics {
inline constexpr char kDefaultBrowserHistogramName[] = "Brave.Core.IsDefault";
inline constexpr char kDefaultBrowserDailyHistogramName[] =
"Brave.Core.IsDefaultDaily";
"Brave.Core.IsDefaultDaily.2";
// Periodically checks if the browser is the default browser and reports the
// relevant metrics via P3A.
components/misc_metrics/default_browser_monitor_unittest.cc
+3 -6
View File
@@ -66,8 +66,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, ReportsIsNotDefaultState) {
CreateMonitor();
histogram_tester_.ExpectUniqueSample(kDefaultBrowserHistogramName, 0, 1);
histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName,
INT_MAX - 1, 1);
histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, 0, 1);
}
TEST_F(DefaultBrowserMonitorUnitTest, ReportsIsDefaultState) {
@@ -84,8 +83,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, SwitchingBetweenNoAndYesStates) {
CreateMonitor();
histogram_tester_.ExpectUniqueSample(kDefaultBrowserHistogramName, 0, 1);
histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName,
INT_MAX - 1, 1);
histogram_tester_.ExpectUniqueSample(kDefaultBrowserDailyHistogramName, 0, 1);
// Switch to "yes" state (true) and fast forward to trigger next check
SetMockedDefaultBrowserStatus(true);
@@ -103,8 +101,7 @@ TEST_F(DefaultBrowserMonitorUnitTest, SwitchingBetweenNoAndYesStates) {
#endif
histogram_tester_.ExpectBucketCount(kDefaultBrowserHistogramName, 0, 2);
histogram_tester_.ExpectBucketCount(kDefaultBrowserDailyHistogramName,
INT_MAX - 1, 2);
histogram_tester_.ExpectBucketCount(kDefaultBrowserDailyHistogramName, 0, 2);
histogram_tester_.ExpectTotalCount(kDefaultBrowserHistogramName, 3);
histogram_tester_.ExpectTotalCount(kDefaultBrowserDailyHistogramName, 3);
components/p3a/metric_names.h
+1 -1
View File
@@ -211,7 +211,7 @@ inline constexpr auto kCollectedExpressHistograms =
.attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kDateOfActivation, MetricAttribute::kVersion, MetricAttribute::kYoi, MetricAttribute::kChannel, MetricAttribute::kPlatform, MetricAttribute::kCountryCode, MetricAttribute::kWoi},
.record_activation_date = true,
}},
{"Brave.Core.IsDefaultDaily", MetricConfig{
{"Brave.Core.IsDefaultDaily.2", MetricConfig{
.attributes = MetricAttributes{MetricAttribute::kAnswerIndex, MetricAttribute::kChannel, MetricAttribute::kDateOfInstall, MetricAttribute::kDateOfActivation, MetricAttribute::kGeneralPlatform, MetricAttribute::kSubregion, MetricAttribute::kVersion},
.record_activation_date = true,
}},