* Update l10n for 1.87.x (Chromium 145). (#33691)
* Fixes l10n srcipt warning.
script\lib\l10n\grd_utils.py:443: FutureWarning: This search incorrectly ignores the root element, and will be fixed in a future version. If you rely on the current behaviour, change it to './/message'
elements = lxml.etree.parse(grd_file_path).findall('//message')
* Updated l10n for 1.87.x release.
* Rebased l10n.
Update l10n for 1.85.x (Chromium 143). (#32503)
* Fixes replacement map.
Some languages use non-breaking whitespace intead of regular space in
XTB files, so our map wasn't matching. Replaced spaces to \s in the map
patterns.
* Fixes error printing.
* Adjust ICU strings validation pattern.
* Fixes <br> -> <br/> tags.
* Updated l10n for 1.85.x release.
Update l10n for 1.84.x (Chromium 142). (#32034)
* Move comment outside of message tag.
Out l10n scripts don't handle comments inside <message> tags.
* Updated l10n for 1.84.x release.
* [Android] Suppress ImpliedQuantity warnings.
ImpliedQuantity warning show up for a number of ICU strings. For example:
--------------------
gen/chrome/android/monochrome_public_bundle__lint/RESZIPS/obj/brave/build/android/android_brave_strings_grd.resources.zip/values-lt/android_brave_strings.xml:1307: Error: The quantity 'one' matches more than one specific number in this locale (1, 21, 31, 41, 51, 61, 71, 81, 101, 1001, …), but the message did not include a formatting argument (such as %d). This is usually an internationalization error. See full issue explanation for more. [ImpliedQuantity]
<item quantity="one">"Nepavyko importuoti slaptažodžių. Vienu metu galite importuoti tik vieną slaptažodį."</item>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gen/chrome/android/monochrome_public_bundle__lint/RESZIPS/obj/brave/build/android/android_brave_strings_grd.resources.zip/values-lt/android_brave_strings.xml:1315: Error: The quantity 'one' matches more than one specific number in this locale (1, 21, 31, 41, 51, 61, 71, 81, 101, 1001, …), but the message did not include a formatting argument (such as %d). This is usually an internationalization error. See full issue explanation for more. [ImpliedQuantity]
<item quantity="one">"Sėkmingai importuotas 1 slaptažodis."</item>
-------------------
Suppress these (for now?) as upstream uses the same string patterns for 'one'.
* Fixes a missing space in a string.
* [l10n] Fixes push command not to add an empty string param.
* Updated l10n for 1.83.x release.
* fixup! [l10n] Fixes push command not to add an empty string param.
* Removes new Telugu Android translations: they cause build errors.
This is an automated change, made by set
`ERRORPRONE_CHECKS_TO_APPLY = ['FieldCanBeFinal']`
at `src/build/android/gyp/errorprone.py` and run the build with --offline flag
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4f7d0b80759a7fd39de219f56984ec686d7aa257
Android: Enable Error Prone checks: FieldCanBeStatic, FieldCanBeFinal, FieldCanBeLocal
Leaves FieldCanBeStatic off in tests, since it's arguably nicer to use
non-statics in test classes for expected values.
Bug: 40661145
Change-Id: I9fdbc6ebed5a6aa98f435dfeccb074715531be16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6543826
Chromium change:
https://chromium.googlesource.com/chromium/src/+/c909285bad37c1d74b163429512d5733f628e260
[A11y] Throttle tab closure undo snackbar while tab grid dialog visible
While the tab grid dialog is visible we disable the UndoBarController
and instead use a custom implementation of the UndoBarController in
TabGridDialogMediator to handle the undo snackbar inside the tab grid
dialog. However, when closing all the tabs shown in the tab grid
dialog we still want to show an undo snackbar using the
UndoBarController. As such the disabled state only exists while the
tab grid dialog is fully visible.
Normally this works fine. However, with recent changes to snackbar
accessibility announcements, the animation would clobber the snackbar
announcing its appearance which is a poor user experience.
This CL introduces the ability to throttle the UndoBarController.
While throttled, tab closure events are queued rather than dropped.
When the throttling is stopped all queued events are displayed. If any
tab closure events become obsolete while in the queue they are
removed from the queue.
The throttling interface is built on TokenHolder and allows multiple
concurrent throttles, only releasing when all throttling is ended.
Presently, there is no TTL for events in the queue as it isn't
necessary for the tab grid dialog case as the period in which events
are only throttled and not dropped entirely is only the duration of
an animation which is very short. Moreover, many actions on the
TabModel force clear the queue, such as opening a new tab.
In the future, if throttling is more prevalent we could elect to
implement a TTL for items in the queue to ensure tabs don't remain
in the pending closure state indefinitely. One possible implementation
is to post a delayed task to wipe an event out of the queue X seconds
after it was added.
Fixed: 39592572
* Fixed some NullAway Java warnings and suppressed some others
* Suppressed warning around ContextUtils.getAppSharedPreferences()
because we cannot depend on //chrome from //base to use ChromeSharedPreferences
Fixesbrave/brave-browser#45541
int getCurrentTabId() replaced with @Nullable Tab getCurrentTab()
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/052f94ec2a329c0bef43a949cd84fe058a32710f
[Hub] Fix Tab Pane interaction with Bottom Toolbar for non-NTP pages
Improve interaction between the tab switcher and the bottom toolbar by
animating the shrinking/expanding tab to the top of the screen
subtracting the toolbar space if bottom toolbar is in use.
The bottom toolbar area still has a somewhat unpolished transition
because the area where the bottom toolbar is remains blank during the
animation rather than something nicer like a crossfade. For now this is
still significantly better than the previous state. However, there is
probably room to improve this with help from UX. Unfortunately, the fact
Hub is layered over the rest of the UI and we are using LayoutManager to
handle the transition makes this somewhat more difficult than it might
otherwise seem.
See demo on bug.
Fixed: 385704998
Change-Id: Id22ec322a89126e319c9a5f5a5bae575eac206f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180002
Max Karolinskiy
