This improvement to this function allows us to make the moving of the
value explicit. It also allows us to remove the flag indicating the
value has been moved, and actually move this validation to profiling
tools, also known as poison-after-use.
This change also removes the unnecessary uses of `TakeBody` for cases
where a const reference were enough.
* add encodeURIComponent for WebUI data URLs in brave_wallet_ui components
It seems we shouldn't be updating chrome://favicon or brave://wallet URIs, so
this is an updated commit that addresses just the limited set of URIs that
require encodedURIComponents usage.
* Mostly working. Need to fix image rendering from untrusted frames
* Fix Market and NFT Icons
---------
Co-authored-by: Douglas Daniel <douglashdaniel@gmail.com>
fix https://github.com/brave/brave-browser/issues/43507
On macOS, previous cursor is not cleared when mouse goes out.
So, we can see resize cursor only once. To fix, clear current cursor
manually. Widget doesn't change its current cursor if it's same with
requested one.
There was some patching being done to `ffmpeg` in the past, but this has
been abandoned since `cr124` was merged.
This PR removes the unused patcher, which was generating warnings
whenever `update_patches` was being run.
Resolves https://github.com/brave/brave-browser/issues/44245
Chromium change:
https://chromium.googlesource.com/chromium/src/+/76fac7530c580e7183de4aa7ecd34b837e38fb17
Fix incorrect anchor placement for Omnibox Suggestions Dropdown
The placement of the Anchor view for the Omnibox Suggestions Dropdown
was being computed based on a view with a different on-screen origin
(different (0,0) coordinates) than the view hosting the dropdown.
This mismatch caused visible gaps in multiple scenarios.
This change ensures that the parent view, which hosts both the Omnibox
Suggestions Dropdown and the anchor view, is used for positioning.
This approach eliminates the current issue and prevents similar
alignment problems in the future.
The change directly fixes the problem with Edge To Edge Everywhere.
This PR simplifies JSON reading in several places by:
- Using `base::JSONReader::ReadDict`
- Using `base::JSONReader::ReadList`
- Using `base::test::ParseJson*`
This changes aim to make the checks around the parsing and its
expectations simpler to read.
This PR also introduces patch for `base::JSONReader::ReadList` which is
only available in M135.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/cb3669146301529c0c364a0478372fc46ddf514a
commit cb3669146301529c0c364a0478372fc46ddf514a
Author: Claudio DeSouza <cdesouza@chromium.org>
Date: Wed Feb 19 16:51:29 2025 -0800
[base] Adding `JSONReader::ReadList`
This class already provides `ReadDict`, which has proven its usefulness
in general. This change adds the corresponding implementation for
`base::Value::Dict`.
Bug: 40912723
In `cxx20`, there is a new function in associative containers called
`contains`, which should be used as a replacement to `base::Contains`.
This reland makes use of a `base::flat_set<ContentGroup>` in one test,
as this was causing build failures on x86 builds, as the compiler would
not abide to evaluate `MakeFixedFlatSet` as `constexpr`.
Resolves https://github.com/brave/brave-browser/issues/44063
Mikhail