[canary] Print json output for failed patches
This change adds an argument a command line argument to `apply_patches`,
namely `--print-patch-failures-in-json`, that allows the output of a
JSON list of files that failed to apply. This will make it easier for us
to read the output from this script when running `scritp/version_up.py`,
and with this information we can further improve the automation of the
daily canary build.
A sample output:
[
{
patchPath: 'patches/chrome-android-java-src-org-chromium-chrome-browser-sync-settings-ManageSyncSettings.java.patch',
path: 'chrome/android/java/src/org/chromium/chrome/browser/sync/settings/ManageSyncSettings.java'
},
{
patchPath: 'patches/chrome-browser-ui-views-toolbar-toolbar_view.cc.patch',
path: 'chrome/browser/ui/views/toolbar/toolbar_view.cc'
}
]
`BraveSidePanel` acts as a complete replacement to chromium's
`SidePanel` type, however the upstream type has never been properly
excluded from the build. This leads occasional breaks where new
references to `SidePanel` appear in different places, and new overrides
have to be introduced to correct those occurrences.
This change entirely removes side panel from being built by exluding the
particular headers/UT from being imported through their respective
shadow files. This will no only reduce the number of places where we
have to honour the token replacements, which means less build breakage
going foward, but it will also prevent ODR violation bugs from
occurring, which can be a particularly nasty type of UB.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/266cfa34e338c9f389a951daa62eaab0b5fa5180
commit 266cfa34e338c9f389a951daa62eaab0b5fa5180
Author: Greg Thompson <grt@chromium.org>
Date: Thu Sep 12 10:54:14 2024 +0000
[webrtc] Fix racy shutdown crash in WebRtcEventLogManagerTestHistory tests
Wait until the test fixture's dtor to shut down the browser policy
connector instead of doing so in TearDown. In the latter case, it's
possible for posted tasks (e.g., cloud reporting tasks) to try to get
the policy connector after it has been destroyed.
Change-Id: Icb3e27665ed653aced35da0743704803372906e1
Fixed: 344950309
- Use ExecJs to wait for script execution otherwise it might fail sometimes.
- Make sure only the target element exists for each test case.
- Add a test case for no content.
* Upgrade from Chromium 129.0.6668.59 to Chromium 129.0.6668.70
* Update pins list timestamp
* Add ExtensionTelemetryServiceSystemTimeTest.* to unit test filters
---------
Co-authored-by: brave-builds <brave-builds+devops@brave.com>
Serg