Reason - many errors of
```
ERROR Input to targets not generated by a dependency.
The file:
//out/android_Debug_arm/gen/brave/brave_generated_resources_af_FEMININE.pak
is listed as an input or source for the targets:
//chrome/android:chrome_apk_paks_locales_af_FEMININE
//chrome/android:chrome_bundle_module_paks_locales_af_FEMININE
//chrome/android:monochrome_apk_paks_locales_af_FEMININE
//chrome/android:monochrome_bundle_module_paks_locales_af_FEMININE
//chrome/android:trichrome_chrome_bundle_module_paks_locales_af_FEMININE
but no targets in the build generate that file.
```
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3c46aa800cbd4e21aeb08ac7c1222ce33d5c902e
Reland: Enable generation of gendered locale PAKs for Android by default.
I've submitted a change to the internal repo which should fix
the internal bot failures.
Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/6656879
Binary-Size: Adding new PAK files for gender translations.
Bug: 416291329
Change-Id: I0ed0e98ce75c58e364c0f366799462611ee15f6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6681239
This change corrects our own override of `BrowserWindowFeatures` to
match the new interface. However, it is necessary to add a patch to tag
the destructor for `BrowserWindowFeatures` as virtual again
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d578f0a6bc931f340ceee8647c8a18d217c88e28
commit d578f0a6bc931f340ceee8647c8a18d217c88e28
Author: Dana Fried <dfried@chromium.org>
Date: Mon Jun 30 12:59:20 2025 -0700
[Unowned Data] Remove test factory for BrowserWindowFeatures
Since we can do injection and substitution via UnownedUserDataHost and
UserDataFactory, there's no reason to also be able to subclass
BrowserWindowFeatures for testing. (Also nobody was actually doing it.)
This also removes the necessity for a factory method that can be
overridden in tests; BrowserWindowFeatures can simply be directly
created.
Bug: 427458853
Change-Id: I8cedee53fdd0ae740fd5a2d75e9ac12f88341d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6681570
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1480690}
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/2460bafb67b67c895e7eb21e63fcdfaac1bcfbf5
sync: Add extensions checkbox to settings on desktop Android
Support for extensions sync was recently added to desktop Android.
Update the sync settings page to add a checkbox for the sync data
type.
toggles sync data type in chrome://sync-internals
Test: added to chrome_public_test_apk
Test: manually verified checkbox appears on desktop Android and
Test: manually verified checkbox does not appear on non-desktop Android
Bug: 424217517
Change-Id: Ifd6643e1d8b013e5d5383d21ef31a51863277650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6652500
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/87eb14f2cb45876f33ed554feb7b997224242d60
Add RequestMetadata to the Android image fetcher
Expose the request_metadata available in C++ image fetcher to Java. To
do so, introduces two new structs ImageFetchResult and
ImageDataFetchResult that contain the status quo Bitmap and byte[]
objects, but also contain a RequestMetadata field.
Keeps the previous fetchImage implementation to be a less invasive
modification to the codebase. Only the AutofillImageFetcher has been
updated to use the new `fetchImageWithRequestMetadata`.
Bug: 412480717
Change-Id: I89572718a44a24b9e820a5e0557bffa628b8dddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6653481
This function is being referenced for a sanity check, but it seems to be
a minor thing to have this sanity check constrained to Linux.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/050112bb38192715d9db3e683912d7b9ed2f78be
commit 050112bb38192715d9db3e683912d7b9ed2f78be
Author: dljames <dljames@chromium.org>
Date: Fri Jun 27 10:11:48 2025 -0700
[Frame] Separate windows and linux frame view creation
Decouples the instantion of the different types of platform specific
BrowserNonClientFrameViews into platform specific functions.
The goal is that this CL makes it easier to understand which Windows or
Linux frame view will be created.
MacOs and ChromeOS are handled in separate files ensuring this one only
deals with Windows and Linux.
Change-Id: I36a2b56ac1a3b63a07b3ebf2b58da50bd721253e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680995
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Mickey Burks <mickeyburks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1479920}
This is still undergoing migration, but for now this is okay to stay as
`WTF`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/936810fb4d0e0b979b156d5325a52e5b6c40b088
commit 936810fb4d0e0b979b156d5325a52e5b6c40b088
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 26 21:07:15 2025 -0700
Switch wtf/text/string_utf8_adaptor.h to "blink" namespace
* As these files are being modified, take the opportunity to rename
StringUTF8Adaptor to StringUtf8Adaptor, aligning with the Google C++
style guide.
* Keep WTF::StringUTF8Adaptor as an alias. It will be removed later.
This CL has no behavior changes.
Bug: 422768753
Change-Id: I51cb38172140fa2ee1422403801fe0123bca6c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6681370
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1479620}
This operator has been removed, and `blink::StrCat` is now the
recommended way to do these string concats.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/53375b8ab66446520c7653e6fde7f8c218f3c705https://chromium.googlesource.com/chromium/src/+/f60a32d7b73920a0cb7082910a7775cdf52614b9
commit 53375b8ab66446520c7653e6fde7f8c218f3c705
Author: Kent Tamura <tkent@chromium.org>
Date: Wed May 28 01:16:08 2025 -0700
Fix mutual #includes of atomic_string.h and wtf_string.h
atomic_string.h and wtf_string.h include each other, probably because
- we want to provide `operator+` by wtf_string.h, and
- string_operators.h depends on AtomicString.
To fix this issue, this CL separates out AtomicString-related part of
string_operators.h to string_operators_atomic.h.
* local_frame_ukm_aggregator.h, heap_test.cc, security_origin.h, and
cross_thread_copier.cc:
Add ref_counted.h, which was included via atomic_string.h.
This CL has no behavior changes.
Bug: 419595599
Change-Id: I80a2e5ea9e83966aaacffb77bb346a6a5a6a26eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6595207
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1466337}
commit f60a32d7b73920a0cb7082910a7775cdf52614b9
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 12 01:50:37 2025 -0700
Apply blink::StrCat() to core/css/
This CL has no behavior changes.
Bug: 419595599
Change-Id: I2b64140e32ded8f52f9d159754280cd7c7f5cca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636954
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1472910}
This change corrects all overrides for `OnViewVisibilityChanged` to
include the new `visible` arg.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/36038e5d98b6590c591f94ba74110e8444daa729
commit 36038e5d98b6590c591f94ba74110e8444daa729
Author: Dana Fried <dfried@chromium.org>
Date: Mon Jun 23 08:18:27 2025 -0700
[Views] Fix ViewObserver::OnViewVisibilityChanged()
- Now behaves as it is documented to (null source for widget visibility
change)
- Now includes a boolean saying whether the source became visible or
not-visible
See attached bug for motivation. No behavior should change as a
result. Follow-up will simplify logic in ElementTrackerViews based on
the changes.
Bug: 426560497
Change-Id: I1e0c103576c3ec649b3c325fad5b47fce8c7e483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6653587
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477295}
This information is available to the caller where we make use of it, and
is being added to the callsite.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/badc704f1939da9933d904adb23bea44f93b6c5f
commit badc704f1939da9933d904adb23bea44f93b6c5f
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date: Thu Jun 26 18:34:27 2025 -0700
[WAR, DNR] Fix unsafe redirect error to web accessible resource
Error was observed on web pages that had a service worker for fetching
subresources. This caused the page to use the SharedURLLoaderFactory
which never bypasses renderer level redirect checks.
Combine that with the fact that the request's initiator was not passed
down into the renderer's redirect check + a redirect to an extension's
Web Accessible Resource that required the initiator to check if it was
a safe redirect, that led to the UNSAFE_REDIRECT error observed.
Fix involved adding the request's initiator to RedirectInfo which can
then be used in the renderer.
Bug: 375395102
Change-Id: I84a526c165847cfe390978d7133022aee25dd303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580522
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1479568}
This mirrors what has been done in upstream code.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/e4de456da7569ac8b5a091bffd9b16ba3c7bdab5
commit e4de456da7569ac8b5a091bffd9b16ba3c7bdab5
Author: Linyu He <linyuh@google.com>
Date: Thu Jun 26 13:10:15 2025 -0700
Move .cc files in browser/ui/browser_window/ to ./internal/.
Discussed with nyquist@chromium.org on code locations and this is what
the team prefers:
```
//chrome/browser/ui/browser_window
+-- public/ (public cross-platform C++ headers)
| +-- android/ (public C++ headers for Android)
| + java/src/ (public Java interfaces/classes)
|
+-- internal/ (cross-platform C++ impl)
+-- android/ (Android native impl)
+ java/src (Android Java impl)
```
Bug: 427828841
Change-Id: Ifa351705c5d57e7280515dd23f17356ca470379e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6677231
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Linyu He <linyuh@google.com>
Commit-Queue: Linyu He <linyuh@google.com>
Cr-Commit-Position: refs/heads/main@{#1479400}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3d3d75f8622c57a921e2c950a1a0242b2043fc2b
commit 3d3d75f8622c57a921e2c950a1a0242b2043fc2b
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Jun 25 17:51:22 2025 -0700
[gnrt] `aliased_deps`: Retain not only package `name`, but also `epoch`.
Before this CL it was impossible to create a `BUILD.gn` with
`aliased_deps` underneath `third_party/rust` (it only worked under
`build/rust/std` where all targets are in a single `BUILD.gn` file).
This is because `RuleDetail::aliased_deps` passed to `BUILD.gn.hbs`
would only contain package names, which was insufficient to build target
labels for crates underneath `//third_party/rust`.
After this CL, `gnrt` propagates the full `PackageId` into
`aliased_deps`. `BUILD.gn.hbs` files have been adjusted to use the new
information as needed.
Tested manually by:
* Running `tools/rust/gnrt_stdlib.py` and `tools/crates/run_gnrt.py gen`
at ToT and verifying that it results in no `BUILD.gn` changes.
* Running `tools/crates/run_gnrt.py gen` from this CL on top of
https://chromium-review.googlesource.com/c/chromium/src/+/6673416/1/third_party/rust/libafl_bolts/v0_15/BUILD.gn
and verifying that `"//third_party/rust/libafl_wide/v0_7:lib"` is
correctly emitted into `third_party/rust/libafl_bolts/v0_15/BUILD.gn`.
Fixed: 427774423
Change-Id: I99d2602a0507c4cc751c28b776cc02b4eb5c3ec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6673272
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478871}
Caused by IDS_UPDATE was defined both at
brave/components/components_strings.grd
and
brave/browser/ui/android/strings/android_brave_strings.grd
Error text
```
components_strings.xml:433: error: resource 'string/update' has a conflicting value
android_brave_strings.xml:796: note: originally defined here
```
I wasn't able to fined the Chromium commit for this
Update our page override to accomodate changes that were made to the underlying
HTML to simplify how live captions are handled.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/7189c30e9a9d8af339ea3bb56436fa1336741f36
commit 7189c30e9a9d8af339ea3bb56436fa1336741f36
Author: dpapad <dpapad@chromium.org>
Date: Mon Jun 16 15:26:48 2025 -0700
Settings: Simplify platform-specific guards in a11y_page.{ts,html}
Specifically remove `captionSettingsOpensExternally_` and
`showOverscrollHistoryNavigationToggle_` runtime checks, since these
were not tied to any feature flags and instead were determined based on
the current OS. Use more accurate <if expr> as needed and remove
unnecessary <template is="dom-if"> nodes.
Bug: 424223101
Change-Id: Ibb3a3eedf41ec9714e80152f6897ddea248a0bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6648567
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1474619}
This macro is now under `url/gurl_debug.h`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b570a3f1f6bcfa2d958226d37856c2af50ffee1b
commit b570a3f1f6bcfa2d958226d37856c2af50ffee1b
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Jun 17 13:19:22 2025 -0700
Split debugging code out of url/gurl.h and url/origin.h
In gurl.h and origin.h, there exists ScopedUrlCrashKey and
ScopedOriginCrashKey, respectively. These debugging support classes are
not commonly used, but they force the headers they live in to pull in a
bunch of //base debugging headers, which then transitively get included
all over the place.
Split the debug code out into url/gurl_debug.h and url/origin_debug.h.
For now, let gurl.h and origin.h include the new _debug headers, so this
CL can land safely without having to deal with random missing IWYU
issues.
Change-Id: I760723ddb34729a4d4ef0a97a0ecaac97855b66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6653147
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1475181}
* Add feature flag
- Add an iOS-only feature flag for using content settings for persisting Brave Shields settings.
* Update Shields default/global settings.
- Use content settings when the feature flag is enabled for default settings.
* Use content settings for shields when flag is enabled.
- Update BraveShieldsTabHelper to use content settings when the flag is enabled.
* Use core P3A when feature flag is enabled.
AlexeyBarabash