Chromium changes:
https://chromium.googlesource.com/chromium/src/+/416a61c418c152a7a7ae568d89302e5ecb6e4a3d
commit 416a61c418c152a7a7ae568d89302e5ecb6e4a3d
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Dec 2 14:13:59 2025 -0800
Android: Split ObservableSupplier into Nullable / Monotonic / NonNull variants
The goal is to use proper @Nullable annotations with
ObservableSuppliers.
To achieve this, we use interfaces that define nullness:
* (Settable)NullableObservableSupplier
* (Settable)ObservableSupplier <-- monotonic
* (Settable)NonNullObservableSupplier
And we have ObservableSupplierImpl implement all of them.
In order to make this migration manageable, I've marked the interfaces
as @NullUnmarked, and will fix annotations in batches until they
can be marked @NullMarked.
This CL includes a batch in order to test out the new interfaces (and
because many were necessary to make the change).
Monotonic suppliers are by far the most common afaict, so that's why
the non-prefixed ObservableSupplier is the monotonic one (that, and
because "Monotonic" is a mouthful).
One implication of this approach is that we'll never have:
ObservableSupplier<@Nullable Foo>
We'd have instead:
NullableObservableSupplier<Foo>
Having the nullness in the interface rather than in the generic
allows for defining toNonNull() only on monotonic suppliers, and
simplifies the implementation.
Bug: 455874046
Change-Id: Id48e235b9ff16a5b21a9c1199863150d17c22736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206746
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1553094}
Otherwise there is a build error:
Traceback (most recent call last):
File "/mnt/wd2t/projects/brave-browser-3/src/out/android_Release_arm64/../../tools/grit/grit.py", line 17, in <module>
sys.exit(grit.grit_runner.Main(sys.argv[1:]))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/mnt/wd2t/projects/brave-browser-3/src/tools/grit/grit/grit_runner.py", line 313, in Main
return toolobject.Run(options, args[1:])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/mnt/wd2t/projects/brave-browser-3/src/tools/grit/grit/tool/build.py", line 265, in Run
self.res = grd_reader.Parse(opts.input,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/mnt/wd2t/projects/brave-browser-3/src/tools/grit/grit/grd_reader.py", line 252, in Parse
handler.root.AssignFirstIds(filename_or_stream, defines)
File "/mnt/wd2t/projects/brave-browser-3/src/tools/grit/grit/node/misc.py", line 657, in AssignFirstIds
raise Exception('Please update %s and add a first id for %s (%s).' %
Exception: Please update ../../out/android_Release_arm64/gen/tools/gritsettings/default_resource_ids and add a first id for chrome/browser/glic/resources/browser_resources.grd (includes).
The removal of this accessor was causing failures to an existing
override replacing calls for `ConvertPointToTarget`, which was making
use of this accessor. This change corrects the way to how this object is
retrieved in the override.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/98134b0b68889c778dde25b32e506d3a0bb634b8
commit 98134b0b68889c778dde25b32e506d3a0bb634b8
Author: dljames <dljames@chromium.org>
Date: Mon Jan 5 12:10:46 2026 -0800
[Vertical Tabs] Remove usage of TabStrip from BrowserRootView 2
Removes usage of TabStrip from BrowserRootView entirely. The same
behavior can be achieved by using TabStripRegionView the tabstrip
agnostic interface. Making this change will utlimately remove the need
for BrowserView::tab_strip() in the future allowing the code to work
as-is when swapping between VerticalTabs and HorizontalTabs.
To achieve this, TabStripRegionView now extends
BrowserRootView::DropTarget. This allows BrowserRootView to forward drop
events through the interface and into the TabStrip implementations. This
allows tabs to appear as if they extend to the full height / width of
their container even though the bounds are stricter.
Change-Id: I1bf7948e632fe1122189eccd2dd89ea8f8679b79
Bug: 465190040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7304863
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1564542}
Upstream hardcoded the registry path for this test, but we need to use
different paths for each channel.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/17d026d2937db8a2a7126aff007d98444466799c
commit 17d026d2937db8a2a7126aff007d98444466799c
Author: Deepak Ravichandran <deepakr@google.com>
Date: Mon Dec 22 08:23:59 2025 -0800
Reland "Windows: Register custom URI schemes for branded and unbranded builds"
This is a reland of commit 84788f0a410035c0f149bf8104b8df0c746d91e4
Original change's description:
> Windows: Register custom URI schemes for branded and unbranded builds
>
> Mirror https://crrev.com/c/7087621 but on Windows by registering custom URI schemes
> (e.g., `google-chrome://`, `chromium://`) for the browser.
>
> This change:
> Updates `chrome/installer/util/shell_util.cc` to correctly register custom URI schemes,
> including `chromium://` for unbranded builds, by adding "chromium" to `kPotentialProtocolAssociations`
> and modifying `AddChromeUriSchemeWorkItems` to use `install_static::GetDirectLaunchUrlScheme()`
> for dynamic lookup during registration.
>
> Bug: b:446672134
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d5213c799a29303dcc0e9497fda72130b39af681
commit d5213c799a29303dcc0e9497fda72130b39af681
Author: Ho Cheung <hocheung@chromium.org>
Date: Tue Dec 23 17:03:39 2025 -0800
[Bookmarks] Add "Copy link" option to Android bookmark manager selection menu
Add a "Copy link" menu option to the selection mode menu in the
Android bookmarks manager. When a single bookmark is selected,
users can now copy its URL to the clipboard via the overflow menu,
providing a quick way to share bookmark URLs without opening them.
This feature:
- Appears in the three-dot overflow menu alongside "Open in new tab"
and "Open in Incognito tab" when exactly one bookmark is selected.
- Is hidden when folders are selected (folders have no URL).
- Clears the selection after copying for a cleaner UX.
- Shows a "Copied" snackbar notification to confirm the action.
- Reuses existing translated strings (@string/copy_link, @string/copied)
to avoid additional i18n overhead.
At the same time, add appropriate tests to improve code coverage and
UserAction for statistical use.
Design doc:
https://docs.google.com/document/d/1zDD-gk01xMioNgL_NTKroxvPW1HnVbPDHIxNQlF-_ZI
Bug: 448009940
Change-Id: I60fdc09a971daea4a92c64b79d3a1706502e63d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7227136
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Owners-Override: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Aaron Teo <hocheung@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1562385}
This crate was being vendored in our tree as a result of being a
transient dependency. This change updates our tree's reference to it, to
permit the use of the version vendored in upstream.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/1d1db2ee976f5f08d2778aeec2bbc8f4a7f0820d
commit 1d1db2ee976f5f08d2778aeec2bbc8f4a7f0820d
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Dec 29 20:31:16 2025 -0800
Roll serde_json: 1.0.145 => 1.0.148 in //third_party/rust.
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* serde_json: 1.0.145 => 1.0.148;
https://docs.rs/crate/serde_json/1.0.148
New crates:
* zmij@1.0.2; https://docs.rs/crate/zmij/1.0.2
Bug: None
Change-Id: I64a3620638e3151619c8e19b39a28b2e2e846fb1
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7354767
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1563312}
This function is now gone entirely, but now there's an accessor in the
model that can provide its value.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/bd1c829796ec0b3f6ea58195393b4254dc7b2f8fhttps://chromium.googlesource.com/chromium/src/+/7791541f7a7285eb8825493692d0b06431a4c3f1
commit bd1c829796ec0b3f6ea58195393b4254dc7b2f8f
Author: Dominic Austria <dominicaustria@google.com>
Date: Tue Dec 30 11:46:33 2025 -0800
[SelectionPtr]Cache the ListSelectionModel for the accessor
TabStripModel::selection_model() returns a ListSelectionModel object but
it is internally using a SelectionState, and so we need to convert this
object to a ListSelectionModel. This is linear in the number of tabs, so
it is concerning if there are clients who spam calls to
TabStripModel::selection_model(). As a precautionary measure we can
cache a ListSelectionModel object and generate it only when necessary
(when the indices of the selection are potentially updated).
There are no tests in this file since after looking at
tab_strip_model_unittest.cc, these changes are already tested by the
ones there.
Change-Id: I58e2beb7eca900f6e1d1bf19b45ffcf02ed4823a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7281804
Commit-Queue: Dominic Austria <dominicaustria@google.com>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1563457}
commit 7791541f7a7285eb8825493692d0b06431a4c3f1
Author: Dominic Austria <dominicaustria@google.com>
Date: Mon Dec 29 18:06:18 2025 -0800
[SelectionPtr]Remove the adapter and use SelectionState only
We change the type of selection_model_ to the simpler SelectionState,
instead of an adapter that implements both the API of SelectionState and
ListSelectionModel at the same time. Additionally, we move away from
using index based logic and ListSelectionModel, replacing it with
pointer based logic and the SelectionState class. This required us to
rewrite the logic of several functions in TabStripModel.
Low-Coverage-Reason:TRIVIAL_CHANGE The warning for the low coverage is
for tab_strip_internal_util.cc, and this CL only has very minor changes
to that file.
BYPASS_LARGE_CHANGE_WARNING:Large scale refactor that is easier to
review as one CL. Most of the changes are only in one file, namely the
TabStripModel.
Bug: 460121011
Change-Id: I0a21f1c3544dc7f3acf0b4413cd81c9d51a47574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7271572
Commit-Queue: Dominic Austria <dominicaustria@google.com>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1563297}
These flags are now all gated by `kSideBySide`, and with that we don't
need to test the value of these as this is the desired behaviour.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/290f338f8cafdbe7f41dc1c86640aa4c1e4f78d4
commit 290f338f8cafdbe7f41dc1c86640aa4c1e4f78d4
Author: Alison Gale <agale@chromium.org>
Date: Thu Dec 11 06:05:03 2025 -0800
[SxS] Clean up sub-flags within the split view experiment
These will mostly be gated behind the top level kSideBySide flag till I
clean that up. Getting these out of the way to simplify things.
Bug: 454347097
Change-Id: If73131d804bf85fea516952a0b4ef3a5a4b215ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7248788
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557353}
This change in upstream has affected several places where these methods
were being extended. Most changes involve now using `TabInterface`,
rather than `WebContents`.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/fdb26aae9fcf18a4065d95f88da9677b71ed6512
commit fdb26aae9fcf18a4065d95f88da9677b71ed6512
Author: Eshwar Stalin <estalin@chromium.org>
Date: Tue Dec 30 15:57:18 2025 -0800
Updating TabStripModel observer methods for consistency
Renaming some of the functions for consistency. Also switching some of
the functions from using content::WebContents to tabs::TabInterface to better align with the long term direction.
Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7350719
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1563530}
This new argument in the constructor has to be passed along with the
Brave-specific code and the Chromium new interface.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3d9be32e4f4422b9807a20f83f6e963412c367e1
commit 3d9be32e4f4422b9807a20f83f6e963412c367e1
Author: Hira Mahmood <hiramahmood@google.com>
Date: Mon Dec 29 08:50:36 2025 -0800
Add desktop_to_ios_promo_receiving_enabled to DeviceInfo
The new Desktop-to-iOS promos involve a reminder flow that allows users
to tap a button on the desktop promo to send a reminder to their iOS
device.
This CL adds a field to DeviceInfo to signal if the receiving end of the
Desktop-to-iOS promos are enabled are on the iOS device, and checks the
value of the field (in chrome/browser/ui/promos/ios_promo_controller.cc)
before displaying the desktop promo to ensure the desktop promo is only
shown if the entire flow is enabled. Once the desktop-to-iOS promo
feature is fully ramped up, the field will be removed.
More context/discussion on the experiment set-up can be found in
crbug.com/449758460
Low-Coverage-Reason: TESTS_IN_SEPARATE_CL
Fixed: 470198750
Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7276213
Reviewed-by: Jood Hajeer <jood@google.com>
Owners-Override: Hira Mahmood <hiramahmood@google.com>
Commit-Queue: Hira Mahmood <hiramahmood@google.com>
Cr-Commit-Position: refs/heads/main@{#1563145}
For now this algo is being handled as NOTREACHED for the purpose of
these functions, as there seems to be some indication that this is too
experimental still.
Chromium change:
https://boringssl.googlesource.com/boringssl/+/52b1463b45712c747a810be819a9cd41ab33fc46
commit 52b1463b45712c747a810be819a9cd41ab33fc46
Author: Nick Harper <nharper@chromium.org>
Date: Tue Sep 9 17:04:01 2025 +0000
[WIP] Support verifying signatureless MTCs.
Add support to CertPathBuilder to verify Merkle Tree Certificates as
defined in draft-davidben-tls-merkle-tree-certs-08. This only supports
"signatureless" certificates (i.e. ones that contain a Merkle Tree
inclusion proof but no RSA/ECDSA/ML-DSA signature).
Change-Id: I6f2ff82897393ca8944228fe44275bb9e91729f4
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82727
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Matt Mueller <mattm@google.com>
Our overrides seem to have degraded at some point, likely because of the
kExtensionsMenuAccessControl feature which is disabled upstream but
probably was enabled at some point.
Updated our code to just replace the icon with ours and use our colors.
Adding and removing the pin button doesn't make sense with the
kExtensionsMenuAccessControl flag disabled because there's no way to pin
the extension without the button.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/bb541027810371415e77f868a4986665a874dc14
commit bb541027810371415e77f868a4986665a874dc14
Author: EmiliaPaz <emiliapaz@chromium.org>
Date: Tue Dec 23 10:18:01 2025 -0800
[Extensions] Add ExtensionsMenuEntryView for menu under feature
With the introduction of ExtensionMenuViewModel, we aim to move
extension-related logic into the model. This CL introduces
ExtensionsMenuEntryView to serve the new menu specifically, allowing it
to evolve independently from the legacy ExtensionsMenuItemView as it
was starting to differ considerably.
Testing was updated to reflect the new name.
This CL has no functionality change.
Bug: 471045053
Change-Id: I0f4d9cb62de95177b0c7735874e894863debe402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7298432
Reviewed-by: Masa Fujita <massan@google.com>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1562238}
There have been several changes to `ExtensionMenuItemView`, but they
affect mostly how the ctor is being called, and how the override in
place is written, for our particular usecase.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/1cef5c89d45b9007798c27d3f8eea65e4967f677
commit 1cef5c89d45b9007798c27d3f8eea65e4967f677
Author: EmiliaPaz <emiliapaz@chromium.org>
Date: Sun Dec 21 17:34:22 2025 -0800
[Extensions] Move ExtensionActionViewModel ownership to ExtensionsMenuViewModel
This CL refactors the ownership model of the Extensions Menu to better
align with the MVC architecture. Previously, ExtensionMenuItemView (the
View) owned the ExtensionActionViewModel, making the View responsible for business logic lifecycle and preventing the Model from acting as the single source of truth.
This change moves the ownership of ExtensionActionViewModel from
ExtensionMenuItemView to ExtensionsMenuViewModel.
Key changes:
(1) Model Ownership: ExtensionsMenuViewModel now maintains a
vector<unique_ptr<ExtensionActionViewModel>>. It is responsible for
populating, sorting (alphabetically), and managing the lifecycle of
these models.
(2) Delegate Factory: Introduces ExtensionsMenuViewModel::Delegate to
abstract the creation of platform-specific ViewModels.
ExtensionsMenuDelegateDesktop implements this to create models backed by
Views, while the Model remains platform-agnostic.
(3) View Updates: The Model now calculates insertion/removal indices and
notifies the Delegate. This allows the View to update in O(1) time
without needing to look up items by ID or re-sort the UI manually.
(4) ExtensionMenuItemView: Updated to support a non-owning raw_ptr
constructor. During the migration (under kExtensionsMenuAccessControl),
it temporarily supports both ownership models.
This means the menu model will be able to access the action model for
information, instead of having to receive it from the View or having
to compute it given an extension id.
Bug: 449814184
Change-Id: Ica3d4f91f9d685f0445f097d544a0c50a9c29da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7265742
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561676}
This class should have not been included. This change adds a patch for a
CL that has been submitted correcting this issue.
Fix: https://crrev.com/c/7309288
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/73ea1fa74a50d59bc9ded6164c3bdf0836fb8dfa
commit 73ea1fa74a50d59bc9ded6164c3bdf0836fb8dfa
Author: Sana Akbani <sanaakbani@google.com>
Date: Fri Dec 19 10:20:20 2025 -0800
Reland "[GlicMI] Create initial GlicTabSubMenuModel for sharing tabs
with Glic through the Tab Context Menu."
This is a reland of commit da0386834b437c054c3f9d4984383896b2e541a3
which fixes the GlicTabSubMenuModelTest breaking on Windows. The FRE
pref was originally set for ChromeOS, but the BUILDFLAG is now removed
so that it is manually set for all platforms. This should allow the test
to pass on Windows.
Original change's description:
> [GlicMI] Create initial GlicTabSubMenuModel for sharing tabs
> with Glic through the Tab Context Menu.
>
> This includes one string, "Start new Chat with Gemini", which currently
> does nothing when clicked, but implementation will be added in a follow
> up.
>
> Mocks are located inside the bug.
>
> Bug: 469768350
> Change-Id: I1801a302872357525b9c0dcc24eeb153e0af031d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7268663
> Reviewed-by: Darryl James <dljames@chromium.org>
> Commit-Queue: Sana Akbani <sanaakbani@google.com>
> Cr-Commit-Position: refs/heads/main@{#1560327}
Bug: 469768350
Change-Id: I1530a36e846245c4a495d38187893fc799d7dafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7275269
Commit-Queue: Sana Akbani <sanaakbani@google.com>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561231}
Access to `web_contents()` was done before through a field, namely,
`contents_wrapper_`. This field has now been dropped, and a
`web_contents()` accessor is available now.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/5606fc836948a2716ac555557e77416dfcd82421
commit 5606fc836948a2716ac555557e77416dfcd82421
Author: yuyisi <hellofroser@gmail.com>
Date: Sun Dec 21 16:26:01 2025 -0800
FIXUP: A `raw_ptr` can be removed from `SidePanelWebUIView`
Since the `SidePanelWebUIView` itself can retrieve the `WebContents`
instance via `web_contents()`, we do not need to store it using a
separate raw pointer.
Fixed: 470115259
Change-Id: I76b12292771f3e1f15a8f5c71e08152ec350588e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7274662
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: YISI YU <hellofroser@gmail.com>
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561667}
Upstream has migrated several places from
`viz::CopyOutputBitmapWithMetadata` to this new callback. This has also
affected the rewards code, where `Bitmap` was being passed as a const
ref, but now ends up being passed by value.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/2fad3cf2b5d23a859c16cbc5a7b7273614fbd766
commit 2fad3cf2b5d23a859c16cbc5a7b7273614fbd766
Author: Tianyang Xu <xtlsheep@google.com>
Date: Fri Dec 19 09:30:13 2025 -0800
Add better error support for CopyFromSurface method
To better support error handling in CopyFromSurface, changed expecting
type of callback from
`const viz::CopyOutputBitmapWithMetadata&`
to
`const base::expected<viz::CopyOutputBitmapWithMetadata, std::string>&`
This CL is very similar to `Add wrapper struct for CopyFromSurface
output` https://crrev.com/c/7003989
Bug: 447589565
Change-Id: I684ab9ae721b681ede7acf87387b18120a2331ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7229082
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: thefrog <thefrog@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Nihar Majmudar <niharm@google.com>
Commit-Queue: Tianyang Xu <xtlsheep@google.com>
Cr-Commit-Position: refs/heads/main@{#1561205}
This pref is now deprecated and about to be deleted with the feature it
was guarding. This change removes the override for this pref, as it is
not public anymore, and the pref is set for removal.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/8dd15b8605b8f346b84304dbe2342c3333d3c540
commit 8dd15b8605b8f346b84304dbe2342c3333d3c540
Author: Damian Rogowski <drogo@google.com>
Date: Fri Dec 19 03:00:49 2025 -0800
Remove the support for CloudPrintProxyEnabled policy
This change removes the support for CloudPrintProxyEnabled policy, as
the Cloud Print feature is now deprecated.
The following changes are included:
- The CloudPrintProxyEnabled policy definition has been marked
as deprecated and its references cleaned up.
- The corresponding policy-to-preference mapping test has been deleted from CloudPrintProxyEnabled.json.
- A number of preferences related to Cloud Print have been deleted
from pref_names.h.
- kCloudPrintProxyEnabled and kCloudPrintEmail prefs have been set
to be cleared.
- The traffic annotation test cases in
tools/traffic_annotation/scripts/test_data/extractor_outputs/
good_branched_completing_annotation.txt and
tools/traffic_annotation/scripts/test_data/extractor_outputs/
good_completing_annotation.txt, which used the CloudPrintProxyEnabled
policy and a non-existent file
chrome/service/cloud_print/cloud_print_url_fetcher.cc, have been
deleted.
BUG=40268453
Change-Id: I9d1e1443b968db986cb22c3c3a906a3d555821ba
Change-Id: I9d1e1443b968db986cb22c3c3a906a3d555821ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7275885
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Damian Rogowski <drogo@google.com>
Cr-Commit-Position: refs/heads/main@{#1561054}
This change affects an override/patch for this type, which had to be
moved around.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f0679a28a42d1e167fde8f56c32463ddc89d8035
commit f0679a28a42d1e167fde8f56c32463ddc89d8035
Author: EmiliaPaz <emiliapaz@chromium.org>
Date: Thu Dec 18 19:49:12 2025 -0800
[Extensions] Change EMViewPlatformDelegateViews to EMDelegateDesktop
Per offline discussion:
- drop ViewPlatform, since it doesn't add important information to
the class
- change Views to Desktop, since Views is too close to View
potentially causing confusion
Bug: 449814184
Bypass-Check-License: renamed file
Change-Id: I64be104579d89b4484c3aa23d01f9df212882861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7264763
Reviewed-by: Masa Fujita <massan@google.com>
Commit-Queue: Masa Fujita <massan@google.com>
Auto-Submit: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560987}
Upstream already excludes most of //third_party, but because of how
ffmpeg generates includes the search path ends up going via
../../brave/chromium_src/../../third_party/ffmpeg.
Error:
In file included from ../../third_party/ffmpeg/libavformat/autorename_libavformat_aacdec.c:2:
In file included from ../../brave/chromium_src/../../third_party/ffmpeg/libavformat/aacdec.c:26:
../../brave/chromium_src/../../third_party/ffmpeg/libavformat/avio_internal.h(126,31): error: unsafe buffer access [-Werror,-Wunsafe-buffer-usage]
126 | avio_wl32(pb, MKTAG(s[0], s[1], s[2], s[3]));
| ^
../../brave/chromium_src/../../third_party/ffmpeg/libavformat/avio_internal.h(126,31): note: See //docs/unsafe_buffers.md for help.
Also, alphabetized our entries in the patch.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/9a3f20f017c15681e9e3395a079fd57aa1170484
commit 9a3f20f017c15681e9e3395a079fd57aa1170484
Author: Juan Mojica <juanmojica@google.com>
Date: Mon Nov 24 02:22:10 2025 -0800
[contextual-search] Move ContextualSearchServiceFactory to contextual_search target.
The existing "web_contents_helper" target is renamed to
"contextual_search" and now includes both the service factory and the
web contents helper. Dependencies on the old target are updated
accordingly
Chromium change:
https://chromium.googlesource.com/chromium/src/+/80a6607029d8d
commit 80a6607029d8d3ad8b2a716d7f09016d2c09fefc
Author: Eriko Kurimoto <elkurin@google.com>
Date: Tue Nov 19 05:36:56 2024 +0000
feed: Build //components/feed:feature_list as component
This CL corrects the build rules inside //components/feed:feature_list
as it's depended by components.
This is required fix for the reland of crrev.com/c/5975253.
Bug: 373908090, b:367479298
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/17d86894d67e5807756d5e437d813cc13e5ee630
commit 17d86894d67e5807756d5e437d813cc13e5ee630
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Dec 17 13:18:21 2025 -0800
[Settings Search] Let Sync pref open from search results
Sync preference in main settings either opens a fragment via
SettingsNavigation or displays a toast if it is disabled by
administration policy. This CL makes it work in the same way when
opened from search results.
For this to work, SettingsNavigation#startSettings is given an extra
parameter (EXTRA_FRAGMENT_TAG) which is given to a fragment transition
from search to result state. This allows the fragment opened via
SettingsNavigation to behave as expected for back action/tap on title.
Bug: 469676538
Change-Id: Ic84cac90a195bbfebf6734727b3367b8aeec52a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7268507
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Moe Adel <adelm@google.com>
Cr-Commit-Position: refs/heads/main@{#1560153}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/8a572f986d8d90fe1befaa2792dabff71410b4db
commit 8a572f986d8d90fe1befaa2792dabff71410b4db
Author: Abdelrahman Eed <abdoeed@google.com>
Date: Tue Dec 16 11:20:41 2025 -0800
[Clank Navigation] Add support for user-modified (Shift-Click)
This CL adds support for the user modified navigation (Shift + Left
click) to launch a new browser window or an app if one is present
depending on the navigation source, for desktop devices.
Changes (only affecting desktop Android devices, or if we are on desktop
windowing):
- Launch a new chrome window if navigating from the chrome browser
- Launch an app to handle the navigation if navigating from a CCT
NO_IFTTT=the check is not working properly, I added the changes needed
Change-Id: I480eb5b648c7da281a83e592fec2b45d52a89631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6662663
Commit-Queue: Abdelrahman Eed <abdoeed@google.com>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Auto-Submit: Abdelrahman Eed <abdoeed@google.com>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559473}
Max Karolinskiy