There was a flag from long ago that allowed you to select Crypto Wallets as your wallet. However if you did this, it no longer works. There is no one that can feasibly still be using this wallet because it hasn't worked for many versions
Addressed review comments
Remove references to 21070F3D60711361C1210B870439BE49B5D995F4
21070F3D60711361C1210B870439BE49B5D995F4 is for Ethereum Remote Client which is removed
Remove unused ReinstallAsNonComponent
Remove unused comment IsInstallationExplicitlyAllowed
Remove _permission_features.json because it's an override that only
exists because of CW extension.
Remove unused string braveWalletImportFromLegacy
Use constexpr for kMetamaskExtensionId
Remove need subscription to kDefaultEthereumWallet and OnWalletTypeChanged handler
Remove DISABLED_ImportLegacyWallet
Add Migration for people with CryptoWallets pref
Deprecate and keep CryptoWallets prefs
1
* Fix includes for `base::StringPrintf`
Upstream is doing a couple of IWYU fixes for `base::StringPrintf`, and
this will have an effect on our own uses of this function. This change
corrects all the includes we have.
This is a mechanical change, done with the following script.
```sh
remove_header_if_unused() {
files=$(git grep -l "base/strings/stringprintf.h")
for file in $files; do
if ! git grep -qE "base::StringPrintf|base::StringAppend" "$file"; then
sed -i '/base\/strings\/stringprintf.h/d' "$file"
echo "Removed 'base/strings/stringprintf.h' from $file"
fi
done
}
add_header_if_needed() {
files=$(git grep -lE "base::StringPrintf|base::StringAppend")
for file in $files; do
../tools/add_header.py --header '"base/strings/stringprintf.h"' "$file"
done
}
remove_header_if_unused
add_header_if_needed
```
* IWYU fix for `ostream` operators
This header was being pulled transiently. This caused build failures
once https://github.com/brave/brave-core/pull/29156 was merged.
This change introduces a `CWVNavigationAction` subclass and new delegate method specific to `BraveWebView` that provides the correct info from `web::WebStatePolicyDecider::RequestInfo` for determining if the navigation was done on the main frame which fixes things such as aggressive shields showing interstitials for blocked subframe navigations.
Upstream is doing a couple of IWYU fixes for `base::StringPrintf`, and
this will have an effect on our own uses of this function. This change
corrects all the includes we have.
This is a mechanical change, done with the following script.
```sh
remove_header_if_unused() {
files=$(git grep -l "base/strings/stringprintf.h")
for file in $files; do
if ! git grep -qE "base::StringPrintf|base::StringAppend" "$file"; then
sed -i '/base\/strings\/stringprintf.h/d' "$file"
echo "Removed 'base/strings/stringprintf.h' from $file"
fi
done
}
add_header_if_needed() {
files=$(git grep -lE "base::StringPrintf|base::StringAppend")
for file in $files; do
../tools/add_header.py --header '"base/strings/stringprintf.h"' "$file"
done
}
remove_header_if_unused
add_header_if_needed
```
* Remove unused and invalid namespaces from Windows ADMX
Fixesbrave/brave-browser#42956
* lint fixes
* more lint fixes
---------
Co-authored-by: Brian Clifton <brian@clifton.me>
fix https://github.com/brave/brave-browser/issues/46193
When rounded corners feature is disabled, contents separator should
be hidden when split view is opened.
TEST=SideBySideEnabledBrowserTest.BraveMultiContentsViewTest
fix https://github.com/brave/brave-browser/issues/46191
Uptream loads split view specific page when createing another tab.
We want to load NTP instead.
TEST=SplitViewLocationBarBrowserTest.URLShouldBeUpdated_WhenActiveTabChanges
1. launch browser with --enable-features=SideBySide
2. Select "Add tab to split view" from active tab's context menu
3. Check NTP is loaded in newly created tab
Mikhail