Chromium change:
https://chromium.googlesource.com/chromium/src/+/76fac7530c580e7183de4aa7ecd34b837e38fb17
Fix incorrect anchor placement for Omnibox Suggestions Dropdown
The placement of the Anchor view for the Omnibox Suggestions Dropdown
was being computed based on a view with a different on-screen origin
(different (0,0) coordinates) than the view hosting the dropdown.
This mismatch caused visible gaps in multiple scenarios.
This change ensures that the parent view, which hosts both the Omnibox
Suggestions Dropdown and the anchor view, is used for positioning.
This approach eliminates the current issue and prevents similar
alignment problems in the future.
The change directly fixes the problem with Edge To Edge Everywhere.
This PR simplifies JSON reading in several places by:
- Using `base::JSONReader::ReadDict`
- Using `base::JSONReader::ReadList`
- Using `base::test::ParseJson*`
This changes aim to make the checks around the parsing and its
expectations simpler to read.
This PR also introduces patch for `base::JSONReader::ReadList` which is
only available in M135.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/cb3669146301529c0c364a0478372fc46ddf514a
commit cb3669146301529c0c364a0478372fc46ddf514a
Author: Claudio DeSouza <cdesouza@chromium.org>
Date: Wed Feb 19 16:51:29 2025 -0800
[base] Adding `JSONReader::ReadList`
This class already provides `ReadDict`, which has proven its usefulness
in general. This change adds the corresponding implementation for
`base::Value::Dict`.
Bug: 40912723
In `cxx20`, there is a new function in associative containers called
`contains`, which should be used as a replacement to `base::Contains`.
This reland makes use of a `base::flat_set<ContentGroup>` in one test,
as this was causing build failures on x86 builds, as the compiler would
not abide to evaluate `MakeFixedFlatSet` as `constexpr`.
Resolves https://github.com/brave/brave-browser/issues/44063
Fixed crash when using new region
fix https://github.com/brave/brave-browser/issues/44181
When new region is added to timezone list and it's same with user's
timezone, vpn service tries to map it to v2's name via GetMigratedNameIfNeeded().
However, new region is not included in kV1ToV2Map, it causes crash.
When it's not in that map, use that name instead.
This alters the new "welcome focus" onboarding design to match the new refreshed version and implements the iPad column design.
This also updates the DesignSystem SwiftUI button styles to match the most up to date Figma designs (updated radius + minimum heights, updated colors in outline style)
* Fix translate onboarding to not automatically translate.
* Fix translate button not always showing correctly.
* Fix ReaderMode main-thread issue.
* Fix onboarding dismiss showing the translate button.
* Block translation requests when translation is disabled.
* Use Javascript callbacks to know when to translate.
* Add guards against displaying the translation overlay when other popups are displayed.
This fixes the following error:
../../brave/chromium_src/chrome/browser/bookmarks/android/bookmark_bridge.cc:19:10: fatal error: 'brave/build/android/jni_headers/BraveBookmarkBridge_jni.h' file not found
19 | #include "brave/build/android/jni_headers/BraveBookmarkBridge_jni.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
This PR simplifies JSON reading in several places by:
- Using `base::JSONReader::ReadDict`
- Using `base::test::ParseJson*`
This changes aim to make the checks around the parsing and its
expectations simpler to read.
Artem Samoilenko