Commit Graph
78466 Commits
Author SHA1 Message Date
Claudio DeSouza b9b1ce9657 [cr149] browser_navigator now in its own directory
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/815c5cff075fb58c5ec93d967479af57312a5894

commit 815c5cff075fb58c5ec93d967479af57312a5894
Author: Foromo Daniel Soromou <koretadaniel@chromium.org>
Date:   Thu Apr 30 18:38:51 2026 -0700

    Move browser_navigator files to a subdirectory

    Move the `browser_navigator*` files from `chrome/browser/ui/` to a new
    `chrome/browser/ui/navigator/` subdirectory to better organize the
    codebase. Update all corresponding include paths across the repository
    to reflect the new file locations.

    Bypass-Check-License: This is a file rename only.
    Bug: none
    Change-Id: I512c4119e212966e84001924ab2eb2e501a490d7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7801797
    Reviewed-by: Darryl James <dljames@chromium.org>
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Commit-Queue: Foromo Daniel Soromou <koretadaniel@chromium.org>
    Reviewed-by: Ashley Prasad <ashleydp@google.com>
    Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
    Cr-Commit-Position: refs/heads/main@{#1623653}
2026-05-22 16:57:32 -04:00
Claudio DeSouza 5fb940665f [cr149] Fix upstream changes to WindowFrameProvider/FakeLinuxUi
A few classes are being affected by these changes but they are mostly
incosequential overall.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/e0f759f728337f7df2f808ebc2c1eefffab5c5e3

commit e0f759f728337f7df2f808ebc2c1eefffab5c5e3
Author: Athul Iddya <athul@iddya.com>
Date:   Thu Apr 16 17:08:08 2026 -0700

    Add a native frame view for non-browser widgets on Linux

    Introduces NativeFrameViewLinux, a FrameViewLinux subclass that provides
    native client-side decorations for non-browser widgets on Linux. This
    class is preferred over FrameViewLinux for the GTK UI theme. Its
    implementation mirrors BrowserFrameViewLinuxNative, using
    WindowFrameProvider for frame decoration and NavButtonProvider for
    window control buttons.

    NativeFrameViewLayoutLinux similarly extends FrameViewLayoutLinux to
    override frame and button layout decisions using WindowFrameProvider and
    NavButtonProvider. Shared utilities between NativeFrameViewLinux and
    BrowserFrameViewLinuxNative are extracted into frame_view_utils_linux.

    WindowFrameProvider and NativeTheme gain options for non-browser frame
    rendering: top area height, padding and border APIs, and bottom border
    drawing in the top area, to match the appearance of native GTK dialogs.

    Bug: 396190939
    Cq-Include-Trybots: luci.chromium.try:linux-wayland-mutter-rel,linux-wayland-weston-rel
    Change-Id: Iee94d493a1751176c38d793e7efcfe47271bc909
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7615475
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Auto-Submit: Athul Iddya <athul@iddya.com>
    Reviewed-by: David Yeung <dayeung@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1616203}
2026-05-22 16:57:32 -04:00
Claudio DeSouza bd450fd91c [cr149] Fixing BraveSpecificsToModel due to last field change
This field used to be a bool, but it is now an enum. This change
corrects the implementation of `BraveSpecificsToModel`, which is
supposed to stay in sycn with `DeviceInfo`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/2beaaac13944769bdb69f50226ddb84e8e840456

commit 2beaaac13944769bdb69f50226ddb84e8e840456
Author: Theodore Olsauskas-Warren <sauski@google.com>
Date:   Thu Apr 30 10:56:48 2026 -0700

    [Glic] Move experimental triggering in DeviceInfo to use Enum

    Update the recently added bool glic_experimental_triggering_opted_in
    to use an enum, updating its name to match.

    The previously added proto entry is removed and the value reused,
    there is no practical risk of version mismatch (and bool values map to
    enum versions that are reasonably safe).

    Change-Id: I231dca339fa09a72d6b79d7a4aeb12d3e9b3b761
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7796299
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Reviewed-by: Maria Petrisor <mpetrisor@chromium.org>
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Reviewed-by: Roman Arora <romanarora@chromium.org>
    Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1623334}
2026-05-22 16:57:32 -04:00
Claudio DeSouza c40fa41402 [cr149] //chrome/browser/ui/navigator componentised
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a7ea861d95f70515cbddad5ea07b29ba144f5659

commit a7ea861d95f70515cbddad5ea07b29ba144f5659
Author: Foromo Daniel Soromou <koretadaniel@chromium.org>
Date:   Thu Apr 30 08:15:42 2026 -0700

    Extract browser navigator into a separate build target

    NOTE: This change is trivial and do not change any behavior.

    Extract the browser navigator code and its associated parameters from
    the monolithic `chrome/browser/ui` build target into a dedicated
    `chrome/browser/ui/navigator` directory and build configuration.

    This refactoring establishes a new standalone build file containing
    dedicated source sets for the navigator component. Consequently, the
    `browser_navigator_params_headers` source set and related source files
    are removed from `chrome/browser/ui/BUILD.gn`.

    Numerous build files across the `chrome/browser` directory are updated
    to replace the old dependency with the new
    `//chrome/browser/ui/navigator` target. This modularization decouples UI
    components, streamlines dependency management, and improves overall
    build structure.

    A follow up CL will move the files under c/b/ui/navigator and rename the
    include places.

    Bug: none
    Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7803848
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Reviewed-by: Kaan Alsan <alsan@chromium.org>
    Commit-Queue: Foromo Daniel Soromou <koretadaniel@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1623210}
2026-05-22 16:57:31 -04:00
Emerick Rogul c7bf5ee636 [cr149] Upgrading Apple toolchain to 26.4.1
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/287de9bad0833

commit 287de9bad083354f51374c6e1827b31e4a66ebf3
Author: Devon Loehr <dloehr@google.com>
Date:   Fri Apr 17 15:08:17 2026 -0700

    mac: Switch to Xcode 26.4.1 (17E202) and SDK 26.4 (25E251)

    Minor version bump; the metal version is unchanged.

    Change-Id: I5d12ee4666140962f92dd77851a5591d61d40bc3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7773727
    Commit-Queue: Devon Loehr <dloehr@google.com>
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1616889}
2026-05-22 16:57:31 -04:00
Artem Samoilenko 0594d11a2e [cr149][Android] Changes for AutocompleteMatch c-tor
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/46173485057d34f790cbd27eb563ca231f46e121

commit 46173485057d34f790cbd27eb563ca231f46e121
Author: Keigo Oka <oka@google.com>
Date:   Wed Apr 29 23:54:16 2026 -0700

    Site Search: Implement Starter Packs UX for Android Desktop.

    This CL implements the Starter Packs (@bookmarks, @history, etc.) UX for
    Android Desktop, focusing on the suggestion list experience while
    maintaining existing Android chip behavior.

    Key changes:
    1. Enabled FeaturedSearchProvider on Android in AutocompleteClassifier.
    2. Updated BasicSuggestionProcessor to format starter pack suggestions with
       appropriate icons (e.g., star for bookmarks, spark for @gemini) and
       combined text (e.g., '@gemini - Ask Gemini').
    3. Included GROUP_STARTER_PACK in AndroidNonZPSSection to prevent these
       matches from being culled on Android.
    4. Passed StarterPackId from C++ to Java in AutocompleteMatch to allow
       semantic icon selection in BasicSuggestionProcessor without parsing URLs.
    5. Enabled kOmniboxSiteSearch and kStarterPackExpansion by default for Android.

    Fixed: 500863504
    Change-Id: I507e7666c1b68201d178351f5aea166b8db0be46
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7784849
    Reviewed-by: Tomasz Wiszkowski <ender@google.com>
    Auto-Submit: Keigo Oka <oka@chromium.org>
    Commit-Queue: Keigo Oka <oka@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622980}
2026-05-22 16:57:31 -04:00
Artem Samoilenko 5c258d95e7 [cr149][Android] Fixes for robolectric tests 2026-05-22 16:57:31 -04:00
Max Karolinskiy 033d07fdfc [cr149] Adjusts HistoryEmbeddingsServiceTest test.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/009e12b95d04c

commit 009e12b95d04c14133718b7519809c59370fc1d2
Author: Mike Wittman <wittman@chromium.org>
Date:   Thu Apr 23 10:54:06 2026 -0700

    [embeddings] Simplify test embedding vector specification

    Many of the tests that make use of Embedding specify vectors
    of size 768, even though the code under test does not depend on
    that size. This change reduces the sizes to 3 and uses literal
    initializers where feasible to avoid unnecessary size assumptions
    and reduce complexity in the tests.

    Bug: 499323089
2026-05-22 16:57:30 -04:00
Claudio DeSouza 6280a4ab16 [WIP][cr149] SidePanel using toolbar side panel height
This change drops the use of `contents_height_side_panel_` in favour of
`toolbar_height_side_panel_`. It all changes our interface for
`SidePanel` to match the changes in upstream for how `SidePanelType` is
passed around.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/32daa3e6986fa59dc7adeca3104b17b0a0b63f63

commit 32daa3e6986fa59dc7adeca3104b17b0a0b63f63
Author: Caroline Rising <corising@chromium.org>
Date:   Wed Apr 29 11:37:34 2026 -0700

    [Side panel] Make all side panels use the toolbar height side panel view.

    This removes usage of the content height side panel view and makes the
    toolbar height side panel layout according to the current feature's
    SidePanelType. This also removes all no unnecessary uses of
    SidePanelType as a param for various side panel accessors.

    In a followup we will rename the toolbar height side panel.

    Bug: 505775465, 505776523
    Change-Id: I5fd80c00064621250619cf4b3c9df326f4bc2ea7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789262
    Commit-Queue: Caroline Rising <corising@chromium.org>
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Reviewed-by: Eshwar Stalin <estalin@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622601}
2026-05-22 16:57:30 -04:00
Claudio DeSouza 8705bfefe7 [cr149][android] Fixing SearchIndexProviderRegistry plaster imports
This class is now importing a lot of the modules that were being
referred to, which broke the plaster. This change corrects that, and
corrects our own insertion of our types to also use similar imports.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/444fafd03c31e8301faba71cf6703fe522121f57

commit 444fafd03c31e8301faba71cf6703fe522121f57
Author: Sky Malice <skym@chromium.org>
Date:   Wed Apr 29 10:39:32 2026 -0700

    Remove qualified imports from SearchIndexProviderRegistry.java.

    Bug: 505789955
    Change-Id: I5a4640575e2f1897375ce99cdf8b9be4ca9f31ff
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7797509
    Reviewed-by: Moe Adel <adelm@google.com>
    Commit-Queue: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622573}
2026-05-22 16:57:30 -04:00
Artem Samoilenko 613195b9ff [cr149][Android] Changes for optional button on LocationBar
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/2d803238f4a71a73decc73a5ec682070f1401750

commit 2d803238f4a71a73decc73a5ec682070f1401750
Author: Calder Kitagawa <ckitagawa@chromium.org>
Date:   Tue Apr 28 18:00:59 2026 -0700

    [IA] Move optional button to LocationBar

    - Create an OptionalButtonCoordinator in LocationBarCoordinator for
      phones only.
    - Add logic to show/hide new optional button dynamically.
    - Update ToolbarPhone to proxy calls into LocationBar except on the
      NTP. On the NTP the identity disk is still presented in the optional
      button. Will refactor post-launch.

    Bug: 491511644
    Change-Id: I81a485c1fa93420c661984523cb0367f737d87be
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7793280
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622145}
2026-05-22 16:57:29 -04:00
Artem Samoilenko ed83c58fa0 [cr149][Android] Changes for plus button on the ntp fakebox
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b13bf0ba6e66a140136f05cb57fdc327edbde6f8

commit b13bf0ba6e66a140136f05cb57fdc327edbde6f8
Author: Brandon Wylie <wylieb@google.com>
Date:   Tue Apr 28 20:56:23 2026 -0700

    [aim] Add plus button to the ntp fakebox

    Bug: 496955673
    Change-Id: Ic9cb8cad4489a47e795155db4712131734b87ccb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7787437
    Commit-Queue: Brandon Wylie <wylieb@google.com>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622213}
2026-05-22 16:57:29 -04:00
Artem Samoilenko da4a404f2c [cr149][Android] Changes for favicon background in StatusView
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/5ea28e703517df10083777563e9bcf2b982e4f83

commit 5ea28e703517df10083777563e9bcf2b982e4f83
Author: Sky Malice <skym@chromium.org>
Date:   Fri Apr 24 12:00:41 2026 -0700

    [AIM] Show favicon in StatusView during exact match.

    Bug: 495903036
    Change-Id: Iecff15665523280814a6ffa9b1e82e9d4fefd417
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7738777
    Reviewed-by: Tomasz Wiszkowski <ender@google.com>
    Commit-Queue: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620374}
2026-05-22 16:57:29 -04:00
Max Karolinskiy d150d7a974 [cr149] Adjusts DataTypeTest.DataTypeCounts test for a new type.
The new type is THEMES_ANDROID.

https://chromium.googlesource.com/chromium/src.git/+/0c6882b3

commit 0c6882b3eb6e3c2573c9276999817d8a3e8c6f56
Author: Xinyi Ji <xinyiji@google.com>
Date:   Fri Apr 24 06:26:48 2026 -0700

    [NTP Customization Sync] Add scaffold for THEMES_ANDROID data type

    This CL adds the initial scaffolding for the THEMES_ANDROID data type.

    - DataType enumeration entry.

    - TODOs for mapping to selectable types.

    - Histogram entries.

    Bug: 488439751
2026-05-22 16:57:29 -04:00
Claudio DeSouza aee373dd92 [cr149] RandInt removed
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/5f591f6b5e3cb8a1bd75a75a8cfb63ff4677af01

commit 5f591f6b5e3cb8a1bd75a75a8cfb63ff4677af01
Author: Elly <ellyjones@chromium.org>
Date:   Tue Apr 28 23:29:33 2026 -0700

    base: remove RandInt

    Removed all remaining calls to base::RandInt and deleted the
    function. The new blessed way to do this is base::RandIntInclusive.

    Fixed: 40283703
    Change-Id: I7b3a1737f11b7364e33d32df26caafac17981dd1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7798357
    Auto-Submit: Elly <ellyjones@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622254}
2026-05-22 16:57:28 -04:00
Max Karolinskiy 9774fe01d6 [cr149] //chrome/browser/profiles was modularized.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/f370ff5e

commit f370ff5ea61fef0acf8afe8f6e62efd35be2350e
Author: Erik Chen <erikchen@chromium.org>
Date:   Tue Apr 28 14:18:20 2026 -0700

    Modularize //chrome/browser/profiles

    Refactors the `//chrome/browser/profiles` BUILD.gn to introduce a new
    `:misc` source_set target and moves profile implementation files (e.g.,
    `profile_impl`, `off_the_record_profile_impl`,
    `bookmark_model_loaded_observer`, policy handlers, avatar/Gaia/shortcut
    helpers) out of the top-level `//chrome/browser` static library into it.
    Updates dependents across the tree (UI, tests, prefs, policy, signin,
    taskbar, etc.) to depend on `:misc` where needed, and adds
    `allow_circular_includes_from` plus `nogncheck` annotations to handle
    headers that can't yet be split out. This is a pure build-system
    reorganization with no behavioral changes.

    misc should eventually be refactored as it contains sources that likely
    should not live in the //chrome/browser/profiles directory.

    AGENT_GENERATED_CL

    Bug: 353332589
2026-05-22 16:57:28 -04:00
Artem Samoilenko bd22d2a698 [cr149][Android] Expose didAccountsFetchSucceed method in SigninManager
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3d631e64797788001eeef6d18db433496fee5fdf

commit 3d631e64797788001eeef6d18db433496fee5fdf
Author: quacksort <quacksort@google.com>
Date:   Tue Apr 28 13:25:24 2026 -0700

    [Signin][Android] Expose didAccountsFetchSucceed method in SigninManager

    This is basically a reland of https://crrev.com/c/7534279, as this
    method was reverted back to private in https://crrev.com/c/7790304.

    This CL also renames the method from didAccountFetchSucceed to
    didAccountsFetchSucceed.

    Fixed: 480076180
    Change-Id: I0003be7ec25eb5fab59ec0b807f76787e511cec6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7797164
    Reviewed-by: Łukasz Barczyński <lbarczynski@google.com>
    Commit-Queue: Lucia Giorgi <quacksort@google.com>
    Reviewed-by: Menghan Yang <myuu@google.com>
    Cr-Commit-Position: refs/heads/main@{#1622000}
2026-05-22 16:57:28 -04:00
Claudio DeSouza e575881ba7 [plaster][cr149] Converting the GetWebStoreURL into a plaster
This change reduces the use of shadow files for this customisation. In
particular, the replacements required an extra function to be overriden
to correct the replacements in the body of the source.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d959d50e90e94ec50892c3244c70cbac15e93c55

commit d959d50e90e94ec50892c3244c70cbac15e93c55
Author: Anton Bershanskyi <bershanskyi@gmail.com>
Date:   Tue Apr 28 12:47:00 2026 -0700

    [Extensions] Move manifest_url_handlers.{h,cc}

    Rename extensions/common/manifest_url_handlers.{h,cc} to
    extensions/common/manifest_handlers/manifest_url_handlers.{h,cc}.
    This commit was generated automatically by the script tool
    tools/git/move_source_file.py.

    Bug: 324534603
    Bypass-Check-License: Files moved, not created.
    Change-Id: Ia8c401b4075b0737a38ccd6074177e404c2043f7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7747370
    Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Anton Bershanskyi <bershanskyi@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#1621973}
2026-05-22 16:57:28 -04:00
Claudio DeSouza 2224d9ad60 [ts][cr149][WIP] ESlint fixes for html imports in .html.ts template
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/520291761b7f51175efa7c1a7daeaeee13adbb91

commit 520291761b7f51175efa7c1a7daeaeee13adbb91
Author: rbpotter <rbpotter@chromium.org>
Date:   Tue Apr 28 11:01:46 2026 -0700

    WebUI: Add check for html imports in CrLitElement subclass def. files

    This ensures templates are properly placed in .html.ts template files
    for such classes, so that they will get proper template validation.

    Bug: 506193591
    Change-Id: Ie0d75b9c566ce22a33c90ae21bdb878fec6762b4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7794465
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1621907}
2026-05-22 16:57:27 -04:00
Artem Samoilenko 2b1420fc06 [cr149][Android] Fixes for the [unchecked] warning
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/7d3c16b9bb778a09b643288fe47bae4c1d8e53b7

commit 7d3c16b9bb778a09b643288fe47bae4c1d8e53b7
Author: Jingping Sun <jings@microsoft.com>
Date:   Mon Apr 27 10:58:12 2026 -0700

    [Unchecked] Enable -Xlint:unchecked for Chromium-owned code

    Conditionally append -Xlint:unchecked to the base javac flags only when
    options.chromium_code is true. This makes javac fail the build on any
    new unchecked-conversion / heap-pollution / raw-type warnings in
    Chromium-owned Java code, while leaving synced third-party Java sources
    (chromium_code=false; auto-defaulted for third_party/ paths without
    org.chromium namespace) compiled silently as before.

    Why conditional, not global: Synced third-party Java code under
    third_party/{junit,google-truth}/ src/ contains unchecked-warning sites
    we cannot fix in chromium code base.

    Bug: 358366667
    Change-Id: I904b09cd4484098cee3b59e6d4aae94eba8d33ae
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7790536
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Commit-Queue: Jingping Sun <jings@microsoft.com>
    Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1621171}
2026-05-22 16:57:27 -04:00
Max Karolinskiy fab00e3f5e [cr149] Applies upstream fix to remove Mac browser test that breaks build.
Discussion in the upstream CL that broke the build: https://chromium-review.googlesource.com/c/chromium/src/+/7782806/comment/c0f5a4b4_8bc58c75/

Upstream fix that removes the test (currently only available in cr150):
https://source.chromium.org/chromium/chromium/src/+/aafaa6d08e257cd31c8dcce60cb0ef9a220c79a9

Remove ChromeInternalLogSourceTest.UpdaterDataPresent

This does not link on official builds of browser_tests on Mac. It does
not seem the original unit_test had CI/CQ coverage either (see bug), so
simply removing the test.

Bug: 510416873
Link: https://chromium-review.googlesource.com/id/I8ba0a49d20898243d679698acc67740d6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7830217
2026-05-22 16:57:27 -04:00
Max Karolinskiy 7ac7f81396 [cr149] Adds forward declaration for PermissionContextBase.
build step: cxx "./obj/components/permissions/permissions/speaker_selection_permission_context.obj"
siso_rule: clang-cl/cxx
stderr:
In file included from ../../components/permissions/contexts/speaker_selection_permission_context.cc:5:
In file included from ../../components/permissions/contexts/speaker_selection_permission_context.h:8:
In file included from ../../components/permissions/content_setting_permission_context_base.h:8:
In file included from ../../brave/chromium_src/components/permissions/permission_context_base.h:9:
../../components/permissions/permission_context_base.h(293,31): error: no class named 'PermissionContextBase' in namespace 'permissions'
  293 |   friend class ::permissions::PermissionContextBase;
      |                ~~~~~~~~~~~~~~~^
1 error generated.
2026-05-22 16:57:26 -04:00
Claudio DeSouza 75ce6e9af1 [cr149] AffiliationServiceImpl::PrefetchChangePasswordURL renamed
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a2bcd9cb8e7179613fbcf0d27595e3bc25eced78

commit a2bcd9cb8e7179613fbcf0d27595e3bc25eced78
Author: Viktor Semeniuk <vsemeniuk@google.com>
Date:   Mon Apr 27 11:21:27 2026 -0700

    Use change-pwd url received from afiliation service

    This CL updates change-pwd url fetching to avoid using stale change
    password urls from cache during automated password change.

    Fixed: 506122721
    Change-Id: I89c6e823dddcc25dcf1a489debf32f471b23a552
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7792821
    Reviewed-by: Ioana Treib <ioanap@chromium.org>
    Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
    Cr-Commit-Position: refs/heads/main@{#1621208}
2026-05-22 16:57:26 -04:00
Claudio DeSouza cd77ff9ee7 [cr149] FindBrowserWithWebContents renamed upstream.
Follow up to:

commit 72f140e852
Author: Claudio DeSouza <cdesouza@brave.com>
Date:   Wed Oct 11 17:42:49 2023 +0100

    `FindBrowserWithWebContents` renamed upstream

    This is a simple function rename with no other effects.

    Chromium change:
    https://chromium.googlesource.com/chromium/src/+/82d9bb0f98d7c88a1b2af2e267cf36125fba17c6

    commit 82d9bb0f98d7c88a1b2af2e267cf36125fba17c6
    Author: Avi Drissman <avi@chromium.org>
    Date:   Mon Oct 9 21:05:45 2023 +0000

        Rename FindBrowserWithWebContents to FindBrowserWithTab

        "WebContents" hasn't been synonymous with "tab" since the content
        split. It's confusing to have a function that says it finds a browser
        by "web contents" yet only looks at the tabs.

        Rename the function so that its name accurately reflects its function.

        Bug: none
2026-05-22 16:57:26 -04:00
Artem Samoilenko 89bcae1324 [cr149][Android] Missing dep for java unit tests 2026-05-22 16:57:26 -04:00
Artem Samoilenko 12c556e662 [cr149][Android] Changes for deleted Java ConsentLevel
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/22ad081b0184507b28bf38f8f41969b6bc47247b

commit 22ad081b0184507b28bf38f8f41969b6bc47247b
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Mon Apr 27 07:11:04 2026 -0700

    [signin/android] Delete Java ConsentLevel

    Bug: 40066949
    Include-Ci-Only-Tests: true
    Change-Id: I373dd158c0af56a7c34041ac1cec81cbe6659f5a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7785873
    Reviewed-by: Alex Ilin <alexilin@chromium.org>
    Commit-Queue: Victor Vianna <victorvianna@google.com>
    Cr-Commit-Position: refs/heads/main@{#1621063}
2026-05-22 16:57:25 -04:00
Artem Samoilenko cff097d5d3 [cr149][Android] Changes for removed isInitialSyncFeatureSetupComplete()
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d78abe4e930bc802ef45f8a9a1c5ca2919e6b4bd

commit d78abe4e930bc802ef45f8a9a1c5ca2919e6b4bd
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Mon Apr 20 05:59:44 2026 -0700

    [sync/android] Remove isInitialSyncFeatureSetupComplete()

    Along with the corresponding setter and UserActionableError::
    {kNeedsSettingsConfirmation,kUnrecoverableError}, which are unreachable
    in production code.

    OBSOLETE_HISTOGRAMS=Sync setup incomplete and unrecoverable error states were removed on Android, along with their histograms.
    NO_IFTTT=UserActionableError values are not obsoleted on all platforms.

    Bug: 40066949
    Change-Id: I903ee43392dfe960e359404338d7d3f07873f784
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7772435
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Victor Vianna <victorvianna@google.com>
    Cr-Commit-Position: refs/heads/main@{#1617442}
2026-05-22 16:57:25 -04:00
Artem Samoilenko ed80344dfe [cr149][Android] Changes for simplified SigninManager's sign-out API
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/6d2965178597282bbc9fd011e58602f4f3951d09

commit 6d2965178597282bbc9fd011e58602f4f3951d09
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Mon Apr 27 07:55:07 2026 -0700

    [signin/android] Simplify SigninManager's sign-out API

    Remove the forceWipeUserData boolean parameter, which was only set to
    true by MissingDeviceLockLauncher. Now that code path waits for sign-out
    to complete and then invokes wipeSyncUserData().

    Fixed: 506898696
    Change-Id: Ic670cf50ec4deefb4b800b34485b5314d61ee193
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789602
    Reviewed-by: Samar Chehade <samarchehade@google.com>
    Auto-Submit: Victor Vianna <victorvianna@google.com>
    Commit-Queue: Victor Vianna <victorvianna@google.com>
    Cr-Commit-Position: refs/heads/main@{#1621084}
2026-05-22 16:57:25 -04:00
Artem Samoilenko 69c29f615a [cr149][Android] Remove Page Summary toolbar shortcut option UI
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/59ca8a4f0745a332aa85097145626b8d2095c81d

commit 59ca8a4f0745a332aa85097145626b8d2095c81d
Author: Bryan Song <bryansong@google.com>
Date:   Fri Apr 24 10:19:07 2026 -0700

    Remove Page Summary toolbar shortcut option UI

    Formerly, a Page Summary adaptive toolbar option was added to test
    Chrome's AI integrations. In a previous CL (7762974), the enums
    and logic related to this feature were removed. However, the frontend
    xml component was not removed.
    This CL removes the said frontend component.

    Bug: 505609923
    Change-Id: I57511ac2dbd79ccb74f9a201dae85f2b9355505b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789242
    Commit-Queue: Bryan Song <bryansong@google.com>
    Reviewed-by: Salvador Guerrero Ramos <salg@google.com>
    Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620298}
2026-05-22 16:57:25 -04:00
Artem Samoilenko 7dd110ed3d [cr149][Android] Changes for new tab button
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4575a451d5d953949be0aaf01bffaaa64c851a26

commit 4575a451d5d953949be0aaf01bffaaa64c851a26
Author: Dan Polanco <polardz@google.com>
Date:   Sun Apr 26 14:59:20 2026 -0700

    [BottomBar] Add new tab button

    http://go/scrcast/NjY5OTkzNTY2Njc5ODU5MnxkNTRiMDY5Yi03YQ

    Fixed: 491509796
    Change-Id: Id3a3a3e697443a85dcbaf804bdad5ead7f8e2906
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7787395
    Commit-Queue: Dan Polanco <polardz@google.com>
    Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620847}
2026-05-22 16:57:24 -04:00
Claudio DeSouza ec3fc55ca2 [cr149] glic_experimental_triggering_opted_in in DeviceInfo
This change reruns the plasters, and adds an update to the call for the
constructor of `DeviceInfo` to pass the newly added argument.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/390ff11a3d7dee78459be3ad5a0f7ca614700bd7

commit 390ff11a3d7dee78459be3ad5a0f7ca614700bd7
Author: Theodore Olsauskas-Warren <sauski@google.com>
Date:   Fri Apr 24 12:04:14 2026 -0700

    [GLIC] Include experimental_triggering opt-in state in DeviceInfo

    A new function which represents the combination of GLIC FRE +
    Actuation + Experimental actuation is added to GlicEnabling, and
    the value is included in the DeviceInfo FeatureSpecificFields.

    Many test call sites which construct a DeviceInfo object are updated,
    and given we are updating these sites anyway, the singular default
    value for MobilePromoOnDesktopPromoTypeSet in the DeviceInfo
    constructor is removed and call sites updated.

    Bug: b:505510293
    Change-Id: I3943e1eddf83ae6d431cc62b8446876c1bd35105
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7783606
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620378}
2026-05-22 16:57:24 -04:00
Artem Samoilenko 48e7a587c0 [cr149][Android] Fix for status icon width
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f866d9d3f235bcae9a293dbb82867590679b8c2a

commit f866d9d3f235bcae9a293dbb82867590679b8c2a
Author: Tomasz Wiszkowski <ender@google.com>
Date:   Wed Apr 15 17:52:14 2026 -0700

    Fix StatusIcon runtime sizing and UrlBar runtime padding.

    Status icon should have a runtime size of 56dp when the url bar has
    focus. This is presently achieved by keeping status view size as
    "wrap content" and computing the "additional margin for the url bar"
    when the url bar gets focus.

    This change removes the logic computing the extra padding and ensures
    the status view has a proper size instead.

    Bumping render test revisions because text in Incognito/SearchActivity
    omnibox does not visually align with suggestions on the reference
    screenshot --example:

    Before: http://screen/3gpJKD8s5CLXxSP.png
    After: http://screen/86yBmRWEVXiMAEN.png

    Screen: https://screenshot.googleplex.com/9F5yYvygWWzUtmA.png
    Change-Id: If5730d154b6eed22a76a899e830fbe6a95084419
    Fixed: 488840224
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7759955
    Reviewed-by: Sky Malice <skym@chromium.org>
    Commit-Queue: Tomasz Wiszkowski <ender@google.com>
    Cr-Commit-Position: refs/heads/main@{#1615531}
2026-05-22 16:57:24 -04:00
Claudio DeSouza 35427a9a75 [cr149] Fixing std::vector iterator base() breakage
This breakage seems to be the result of a libc++ update.
2026-05-22 16:57:23 -04:00
Claudio DeSouza d3be5ab9f1 [cr149] Using SetHighlightedElement
This change migrates from `SetHighlightedButton` to
`SetHighlightedElement`, which expects an element id.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b382a3d424be203195b983b3d37b258786c839f8
https://chromium.googlesource.com/chromium/src/+/5c61647fa6331ad61b0173fb2780e3ce732445dd

commit b382a3d424be203195b983b3d37b258786c839f8
Author: Maks Orlovich <morlovich@chromium.org>
Date:   Fri Apr 24 11:59:39 2026 -0700

    Finish SetHighlightedButton->Element migration.

    The final user (the CrOS input overlay for games) was working around a
    bug in SetAnchorView not updating the highlight unless it also changed
    the widget (or was being set for the first time). So testcase + fix that
    bug, and remove the now unneeded call.

    With that done, the now unused SetHighlightedButton and corresponding
    code are also removed, as is some of the necessary state. The ability to
    highlight views::Buttons is still around, however, since they may be the
    anchor.

    Bug: 489349570
    Change-Id: I48f49ce05f07379db8dbf3b6614b85a66a2b165a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789255
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: Cici Ruan <cuicuiruan@google.com>
    Cr-Commit-Position: refs/heads/main@{#1620373}

commit 5c61647fa6331ad61b0173fb2780e3ce732445dd
Author: Maks Orlovich <morlovich@chromium.org>
Date:   Tue Mar 10 15:57:49 2026 -0700

    Migrate ContentSettingsImageView to SetHighlightedElement.

    This required giving all of them an ElementIdentifier, which we will
    need for the WebUI impl anyway. To support multiple implementations the
    naming was placed in the Model, and the view made to use it
    consistently.

    Loosely inspired by caraitto@'s
    https://chromium-review.googlesource.com/c/chromium/src/+/7591203

    Bug: 489349570
    Change-Id: I6993f6acd2edd1d20a12ec951a4a2e2dfee4a625
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7649608
    Reviewed-by: Andy Paicu <andypaicu@chromium.org>
    Reviewed-by: Kaan Alsan <alsan@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597382}
2026-05-22 16:57:23 -04:00
Max Karolinskiy 4d54051f35 [cr149] WebUI tab strip removed
All the code relating to this is gone in upstream, so it is also removed
in Brave.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4e272219dcf3ae5ed3d110e01741ec2ae07b13f4

commit 4e272219dcf3ae5ed3d110e01741ec2ae07b13f4
Author: Mitsuru Oshima <oshima@chromium.org>
Date:   Fri Apr 24 13:19:00 2026 -0700

    Remove UseWebUITabStrip(), kUseWebUITabStrip flag

    This removes the UseWebUITabStrip function, kUseWebUITabStrip feature
    flags and simplifies the surrounding logic since it's no longer used.

    There are still other code/files specific to WebUITabStri, and they'll
    be removed in separate CLs.

    Bug: 421465978
    Change-Id: I2278ec267fcd3cc7e5b2006bcafba9ee67525686
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7787148
    Reviewed-by: Eshwar Stalin <estalin@chromium.org>
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Georg Neis <neis@chromium.org>
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620421}
2026-05-22 16:57:23 -04:00
Claudio DeSouza 1ab3aa4ac9 [cr149] SplitTabsToolbarButton::split_tab_menu_ type changed
This method is now declared as `SplitTabMenuModel`. This required a very
smalll adjustment on how we were overriding this field.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f34139620b55ba9d211adaf6a6ae0315d1cc7aa2

commit f34139620b55ba9d211adaf6a6ae0315d1cc7aa2
Author: Russ Hamilton <behamilton@google.com>
Date:   Fri Apr 24 09:44:56 2026 -0700

    Also test WebUI in split tabs button interactive ui tests

    Bug: 493228701
    Change-Id: Ia39b010af06cc9f0ee5dc9142b65851daa00dd53
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7668981
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Reviewed-by: Qingxin Wu <qingxinwu@google.com>
    Commit-Queue: Russ Hamilton <behamilton@google.com>
    Cr-Commit-Position: refs/heads/main@{#1620272}
2026-05-22 16:25:14 -04:00
Claudio DeSouza d38d733dde [cr149] PageActionPerActionMetricsRecorder renamed
This PR fixes the plaster for `PageActionPerActionMetricsRecorder`,
which has to use the new `PageActionMetricsRecorder`. This PR also
improves the plaster to disable any `Record` functions in this class, so
we can notified when new ones are added.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/42d106dd97f5729ff8ccf50171f3dc87798d76d8

commit 42d106dd97f5729ff8ccf50171f3dc87798d76d8
Author: Kaan Alsan <alsan@chromium.org>
Date:   Fri Apr 24 14:29:50 2026 -0700

    Consolidate PageAction Metrics Recording using ScopedMultiSourceObservation

    This CL transitions the PageAction metrics recording system from
    multiple ScopedObservation-based recorders to a single
    PageActionMetricsRecorder using ScopedMultiSourceObservation.

    Previously, we had count(page actions) * count(tabs) metrics recorder
    objects, which duplicated GURLs and created many individual scoped
    observations. This CL improves efficiency by sharing navigation state
    across all actions in a tab and reducing the total number of
    observations. With local profiling (with debug parameters on), this
    saves ~100KB per tab, with 31 page actions enabled.

    Key changes:
    - Merged per-action and page-level metrics logic into a unified
      PageActionMetricsRecorder.
    - Updated PageActionModelInterface to include GetActionId() for
      identification in the consolidated recorder.
    - Refactored PageActionControllerImpl to manage the unified recorder.
    - Deleted the redundant PageActionPageMetricsRecorder.
    - Updated unit tests and test support classes to align with the new
      architecture.

    Bug: 384074251
    Change-Id: I1aeb2205b4d36de3af68d70404ce459babf1dbef
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7790756
    Commit-Queue: Kaan Alsan <alsan@chromium.org>
    Reviewed-by: Foromo Daniel Soromou <koretadaniel@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620471}
2026-05-22 16:25:14 -04:00
Artem Samoilenko ded7386ce6 [cr149][Android] Build fix for password store factory
Otherwise there is an error:
../../brave/chromium_src/components/password_manager/core/browser/password_store_factory_util.cc:18:5: error: unknown type name 'PrefService'
   18 |     PrefService* prefs) {

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/37a52a3a3a7babdf79058424bae296faa5b4a61e

commit 37a52a3a3a7babdf79058424bae296faa5b4a61e
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Wed Sep 3 11:17:38 2025 -0700

    Unify Create{Profile,Account}PasswordStoreBackend() into 1 function

    After recent changes, they are almost the same and can share code.

    Also:
    - IWYU.
    - Emit a TRACE_EVENT for the creation of the account store backend,
      not just the profile one.
    - Remove IsAccountStore parameter from PasswordStoreAndroidBackend,
      it was always IsAccountStore(true)
    - Changes in the store factories:
        * Reduce vertical space, some of these functions look a lot bigger
          than they need to be.
        * "ProfilePasswordStore", not "PasswordStore".
        * Consistently add DependsOn() for the affiliation service factory.
          I think in practice this isn't needed today because the
          AffiliatedMatchHelper is destroyed on Shutdown() [1], ahead of the
          destructor. But that could easily change. The new code is also
          more consistent (before the change, some factories listed the
          dependency and others didn't).

    [1] https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/password_store/password_store.cc;l=430;drc=391e98eeaee80326c3a9d9e9dd731570dba0981a

    Bug: None
    Change-Id: Iabccc1284135d8de0e80898da80f0e145cd3a1c5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909469
    Commit-Queue: Victor Vianna <victorvianna@google.com>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1510417}
2026-05-22 16:25:14 -04:00
Artem Samoilenko f5483833a4 [cr149][Android] Add Glic Button to MTB
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/481c8c624365ce1b5d86a8c2ad0082611239fb81

commit 481c8c624365ce1b5d86a8c2ad0082611239fb81
Author: Alexis Wu <alexiswu@google.com>
Date:   Thu Mar 26 10:48:10 2026 -0700

    [GlicSettings] Add Glic Button to MTB

    This CL adds the glic button to the selection menu for MTB. Relevant unit tests are also added.

    screenshot: https://screenshot.googleplex.com/7VMLfF5uqAenMNz

    Fixed: b:494269230
    Change-Id: I507c3b2db9437764d5de724ffce6253c1ccd491e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7695275
    Reviewed-by: Michael Wu <mklw@google.com>
    Commit-Queue: Alexis Wu <alexiswu@google.com>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1605654}
2026-05-22 16:25:14 -04:00
Artem Samoilenko 3fda3ea37a [cr149][Android] Changes for top toolbar controls visibility
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3be4aa262c2e4e73d091abf55f1ad055b9d7eddf

commit 3be4aa262c2e4e73d091abf55f1ad055b9d7eddf
Author: Calder Kitagawa <ckitagawa@chromium.org>
Date:   Fri Apr 17 11:02:08 2026 -0700

    [Clank IA] Update control visibility

    Toggle visibility of tab switcher, app menu and optional button using
    toolbar variations.

    Still to be done:
    - Move optional button location
    - Update URL & StatusView location

    Bug: 497898172
    Change-Id: Ied5f17595f38be55f28210682820d8e55825046e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7762379
    Reviewed-by: Sky Malice <skym@chromium.org>
    Reviewed-by: Dan Polanco <polardz@google.com>
    Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1616699}
2026-05-22 16:25:13 -04:00
Artem Samoilenko 8af75b3a89 [cr149][Android] Changes for NTP LegacyLogoView
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c66e45550985e3570e1cf181df0ec749ab3d80f6

commit c66e45550985e3570e1cf181df0ec749ab3d80f6
Author: Yanting Yu <yyanting@google.com>
Date:   Tue Apr 21 12:43:23 2026 -0700

    [LogoRefactor] Branch to LegacyLogoView and introduce feature flag.

    This CL branches the current LogoView implementation into LegacyLogoView
    to ensure the existing functionality remains intact while we restructure
    the new LogoView in the follow up CL.

    Changes include:
    - Branched LogoView, LogoViewBinder, layout XMLs, and corresponding unit tests into LegacyLogoView equivalents.
    - Added the ChromeFeatureList.LOGO_VIEW_REFACTOR feature flag in LogoCoordinator to dynamically switch between inflating the LogoView and the LegacyLogoView.
    - Extracted the ClickHandler interface from LogoView into LogoProperties to serve as a shared, domain-specific contract. This cleanly decouples the two views, allowing them to be fully independent while still being driven by the same PropertyModel and LogoMediator.
    - Updated new_tab_page_layout.xml to replace the `logo_holder` FrameLayout with ViewStub.

    Bug: 492453183
    Change-Id: Id0ef80f8acab9c2d15928020eb3688bd9f2afc33
    Bypass-Check-License: branched files
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7760153
    Commit-Queue: Yanting Yu <yyanting@google.com>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1618376}
2026-05-22 16:25:13 -04:00
Max Karolinskiy edd588d9b2 [cr149] Adds Sec-GPC as an exception to forbidden headers.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1917c17d0ad2fdc3e994a9aefd254b8db7bbe457

commit 1917c17d0ad2fdc3e994a9aefd254b8db7bbe457
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date:   Wed Apr 22 19:42:38 2026 -0700

    OOR-CORS: Enforce extra forbidden Sec- header checks

    This CL adds a new function ContainsForbiddenSecurityHeader in
    header_util to check for unauthorized Sec- headers from renderer.

    This function is used in both CorsURLLoaderFactory::IsValidRequest and
    CorsURLLoader::FollowRedirect to prevent renderer from injecting or
    modifying these headers, while permitting Client Hints and Sec-Purpose.

    Change-Id: Ia2923ccbddddba2657d72916a03e657c1785cd85
    Bug: 494800494
2026-05-22 16:25:13 -04:00
Artem Samoilenko bc9ae2f4c5 [cr149][Android] Changes for removed web feed feature
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/1a47ae7a5c8df3b2d7ecc1bd01a620a5a0e07e05

commit 1a47ae7a5c8df3b2d7ecc1bd01a620a5a0e07e05
Author: Yanling <yanlinghu@google.com>
Date:   Tue Apr 21 17:01:09 2026 -0700

    [Feed] Part4 of remove web feed feature: Remove bridge

    Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:android-internal-dbg
    Bug: 407797637
    Change-Id: I5136225d8f12378cccccb7668aceb5a0d294a162
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7777487
    Commit-Queue: Yanling Hu <yanlinghu@google.com>
    Reviewed-by: Theresa Wellington <twellington@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1618556}
2026-05-22 16:25:13 -04:00
Artem Samoilenko 1e4a1598f5 [cr149][Android] Introduce AutocompleteState
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/7dfb3a2d7ff70cef2b442a34fb4534a44be83b1d

commit 7dfb3a2d7ff70cef2b442a34fb4534a44be83b1d
Author: Tomasz Wiszkowski <ender@google.com>
Date:   Wed Apr 22 15:33:27 2026 -0700

    Introduce AutocompleteState.

    The new AutocompleteState clearly describes how Autocomplete stack
    responds to input changes. Three explicit states control whether user
    should see suggestions when they enter active input session.

    Change-Id: If889a3393b5ea73f23c5cd460d4b25b4926a29f0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7787032
    Reviewed-by: Sky Malice <skym@chromium.org>
    Commit-Queue: Tomasz Wiszkowski <ender@google.com>
    Cr-Commit-Position: refs/heads/main@{#1619142}
2026-05-22 16:25:12 -04:00
Artem Samoilenko 9a07605e07 [cr149][Android] Do not allow a parameter for @CalledByNative
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/30d45a378201de2f3257e86b62ed2d7089830404

commit 30d45a378201de2f3257e86b62ed2d7089830404
Author: Andrew Grieve <agrieve@chromium.org>
Date:   Wed Apr 22 14:52:19 2026 -0700

    JNI Zero: Do not allow a parameter for @CalledByNative

    All uses of it have been migrated.

    Bug: 496331306
    Change-Id: Iee57709d8b55493712acaa731403dc35617a9e94
    Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7786592
    Auto-Submit: Andrew Grieve <agrieve@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Owners-Override: Andrew Grieve <agrieve@chromium.org>
    Reviewed-by: Martin Kong <martinkong@google.com>
    Cr-Commit-Position: refs/heads/main@{#1619108}
2026-05-22 16:25:12 -04:00
Claudio DeSouza 13b76181b5 [cr149] TemplateURLTableModel::RowCount deleted
A new member `engine_count()` serves the same purpose.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/0bd93729174039f678c71990a698215207d985b5

commit 0bd93729174039f678c71990a698215207d985b5
Author: Amelie Schneider <amelies@google.com>
Date:   Thu Apr 23 08:29:23 2026 -0700

    [Search] Remove unused TemplateURLTableModel functions

    The experiment `SearchSettingsUpdate` included a refactoring to stop
    using the table model for accessing the template URL service but
    accessing it directly through the keyword controller instead. Some
    functions are already unused and can be removed, the
    TemplateURLTableModel as a whole should be removed once the flag is
    launched.

    This also excludes KeywordEditorController for Android, since it is not
    used there.

    Bug: 498543733, 490316630
    Change-Id: Ie7ab74e7eece7485c85a678b89a48f1cb15a9a94
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7768616
    Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
    Commit-Queue: Amelie Schneider <amelies@google.com>
    Cr-Commit-Position: refs/heads/main@{#1619543}
2026-05-22 16:25:12 -04:00
Claudio DeSouza 7d865d3fee [cr149] Remove unused inclusion for WatermarkView
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/88bfa4ef4b4486a2fbb00d4568973ba3291215ee

commit 88bfa4ef4b4486a2fbb00d4568973ba3291215ee
Author: Nasser Al-shawwa <alshawwa@chromium.org>
Date:   Thu Apr 23 12:49:17 2026 -0700

    [Tab Share Protection] Rename WatermarkView to DataProtectionOverlayView

    The view being renamed will be used to draw overlays other than the
    watermark, for data protection. As a result, it should be renamed to
    reflect this new use-case.

    Bug: 505461536
    Change-Id: I3c97954af81ae1de7db1dffdc5459b9d13c9bd47
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7788830
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Reviewed-by: Caroline Rising <corising@chromium.org>
    Commit-Queue: Nasser Al-shawwa <alshawwa@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Lina Ismail <ismaill@google.com>
    Cr-Commit-Position: refs/heads/main@{#1619713}
2026-05-22 16:25:12 -04:00
Claudio DeSouza 40c3d6b3dd [cr149] ContentSettingPermissionResolver dropped from request data
This changes the constructor calls, and this change corrects that. For
the only use of `PermissionDescriptor` in the constructor, a default
constructor is being used because there is no blink value for the
permission name for `RequestType::kBraveOpenAIChat`, so we set that
separately.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/35ad82c9803604df82915104d4d062cd851214f7

commit 35ad82c9803604df82915104d4d062cd851214f7
Author: Antonio Sartori <antoniosartori@chromium.org>
Date:   Thu Apr 23 10:37:35 2026 -0700

    [permissions] Refactor PermissionRequestData

    This CL refactors PermissionRequestData so that it becomes again a
    data-only struct (which can be e.g. cloned) by removing the
    PermissionResolver member. This allows simplifying
    GeolocationPermissionContextAndroid, where we don't need to recreate
    fake PermissionRequestData for the callbacks anymore.

    The refactoring unfortunately implies adapting all callsites, which
    however become more natural as they don't need to instantiate a
    PermissionResolver anymore.

    R=hempjudith@google.com

    Change-Id: Ib7883e9f7cac32ef4039ce3098275ad9018f47d3
    Bug: 443898320
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7780845
    Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
    Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
    Reviewed-by: Judith Hemp <hempjudith@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1619624}
2026-05-22 16:25:11 -04:00
Artem Samoilenko b4dd4c5554 [cr149][Android] Remove Page Summary adaptive toolbar button
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f71a274e4251ab0af4309311f1872115cce080df

commit f71a274e4251ab0af4309311f1872115cce080df
Author: Bryan Song <bryansong@google.com>
Date:   Tue Apr 21 16:45:11 2026 -0700

    Remove Page Summary adaptive toolbar button

    There's an adaptive toolbar button that was created to test Chrome's AI
    integrations. It is no longer used. Therefore, this CL removes the
    button and associated services.

    Bug: 500481129
    Change-Id: If52a300da2af950d5303e867546ee369e1042114
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7762974
    Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Salvador Guerrero Ramos <salg@google.com>
    Commit-Queue: Bryan Song <bryansong@google.com>
    Cr-Commit-Position: refs/heads/main@{#1618547}
2026-05-22 16:25:11 -04:00
Artem Samoilenko 5c644db989 [cr149][Android] Plumb LocationBarFocusScrimHandler to LocationBarMediator
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/9968c93603137808ad94865feef269431b0c6db1

commit 9968c93603137808ad94865feef269431b0c6db1
Author: Tomasz Wiszkowski <ender@google.com>
Date:   Mon Apr 20 15:03:13 2026 -0700

    Plumb LocationBarFocusScrimHandler to LocationBarMediator.

    This change should allow us to invoke Scrim when we need it.

    Bug: 485180312
    Change-Id: I0bb1f203d0e15c4948a61cedb4bb4c5e328b7d1a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7773078
    Commit-Queue: Tomasz Wiszkowski <ender@google.com>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Auto-Submit: Tomasz Wiszkowski <ender@google.com>
    Reviewed-by: Patrick Noland <pnoland@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1617792}
2026-05-22 16:25:11 -04:00