`SidePanel` forward declarations have to be corrected for this type, as
it starts to conflict with the `SidePanel` alias we have in place.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/245f12ad092ce24b4aaff054e69222639162f31f
commit 245f12ad092ce24b4aaff054e69222639162f31f
Author: Dana Fried <dfried@chromium.org>
Date: Mon Oct 27 15:07:05 2025 -0700
[Chrome Next] New browser layout (incomplete but functional)
Implements (most of) the new browser layout. There are bugs and
unhandled cases, including some separator logic and immersive
fullscreen. But the browser is ~usable.
The key design principles here are:
- Hierarchically lay out containers using local coordinates.
- Plan the entire layout before applying.
- Plan the layout of each container in priority order.
This will result in a layout that can perhaps later be decomposed into
multiple sub-layouts, simplifying things greatly (and making the
layouts modular so we can piece together different browser and PWA
layouts from the tools we create here).
Bug: 453717426
Change-Id: I50b1ff5767f34d3ae190d0d04fda31f230a1413d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081613
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536266}
This constructor now takes a `AutocompleteControllerConfig` instance,
which bundles a couple of values in it. This has not functional
difference to the use being made in brave though.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/30b2e1555c4d49007eff1bf1eb50aa8bc0490da7
commit 30b2e1555c4d49007eff1bf1eb50aa8bc0490da7
Author: manukh <manukh@chromium.org>
Date: Mon Oct 27 15:55:33 2025 -0700
[omnibox][webui] Wrap AutocompelteController cstr params in a struct
`AutocompleteController` has params to configure how it behaves.
- WebUI wants to disable IPH matches
- Lens has a longer stop timeout
- ChromeOS wants unscoped open tab matches
- chrome://omnibox/ml wants to disable ML ranking
- Many embedders and tests wants a subset of providers
This param list isn't too large but it's not very scalable to have a
bunch of optional params or overridden constructors. Especially as we
look to clean up the coupling of omnibox and autocomplete pieces.
In preparation for moving WebUI features outside of components/ which
will require configuring IPH matches via an additional constructor
param, this CL wraps all the params in a `AutocompelteControllerConfig`
struct.
No behavior change.
Bug: 454425012
Change-Id: I9acd1bef1f4d115452b4e3cc567e4182fa117cbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7082411
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Auto-Submit: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536291}
This change just moves us to the new icons used in Chromium, however
there may be follow ups to this if these icons are not adequate.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/8a1128f5e356e1d51bd7757d712d0e00ab4e6060
commit 8a1128f5e356e1d51bd7757d712d0e00ab4e6060
Author: James Leung <jamesleung@google.com>
Date: Mon Oct 27 16:10:37 2025 -0700
[omnibox] Remove unused icon files
There are icons in omnibox:: and vector_icons:: that are
no longer used outside of the vector_icon .h/.cc generated
files. Thiis CL removes the excess icons and reconfigures
the build files to reflect that.
Note: kHistoryIcon was originally requested to be removed,
and that was in ash's vector_icons, which is chromeOS, which
affects Chrome as well.
Bug: b:446964268
Change-Id: I6340fa60a21ab014b3386c24f182753c373f697e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7049644
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Commit-Queue: James Leung <jamesleung@google.com>
Cr-Commit-Position: refs/heads/main@{#1536304}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/2aae9f900497dad881577944ca244b19640e0bd4
commit 2aae9f900497dad881577944ca244b19640e0bd4
Author: Hitarth Kothari <hitarthkothari@google.com>
Date: Fri Oct 24 10:22:44 2025 -0700
[Pinned Tabs] fix blinking effect when search bar is hidden
Problem: Layout Instability and Flickering on Scroll
The primary issue stemmed from the HubLayout using a LinearLayout. When
scrolling down in the tab switcher, the search bar would hide. This
triggered a re-layout, causing the HubPane to expand upwards to fill the
newly available space. This expansion registered as an unintended scroll
event, which immediately caused the search bar to reappear, resulting in
a jarring flicker and preventing the user from scrolling properly.
Solution: Stabilize Layout with a FrameLayout
To resolve this, the root container of HubLayout was converted from a
LinearLayout to a FrameLayout.
This change stabilizes the HubPane's height, as children in a
FrameLayout are layered on top of each other (z-ordered) rather than
positioned sequentially. This prevents the pane's size from changing
when a view like the search bar is hidden, thus eliminating the flicker.
Architectural Changes & Implementation Details:
This architectural shift has the following consequences and required
these implementations:
1. Manual Toolbar Spacing: Because FrameLayout layers views from the
top, the main pane content now requires a 56dp top margin to avoid being
drawn underneath the toolbar.
2. Pane-Specific Search Bar Spacing: Each pane is now responsible for
allocating its own spacefor the search bar if it is visible.
* Tab Switcher Pane: To accommodate the search bar and its hide-on
scroll behavior, the pane's layout was wrapped in a CoordinatorLayout. A
56dp AppBarLayout was introduced to reserve space for the search bar.
This correctly implements the collapsing toolbar pattern, allowing the
tab list to scroll underneath the search bar area as it disappears.
* Tab Group List Pane: In this view, the search bar is always present.
A simpler solution was implemented by adding a 56dp paddingTop directly
to the RecyclerView. This creates the necessary static space without the
overhead of a CoordinatorLayout. The specific top margin for the first
list item (from TabGroupListItemDecoration) was also adjusted to 8dp, as
the previous value was part of an older layout calculation that is no
longer relevant with the new explicit padding model.
* Tablet & Landscape UI: The new design is flexible. For layouts where
the search bar is not present (e.g., tablets), the AppBarLayout's
visibility is simply set to GONE. The CoordinatorLayout automatically
handles this, allowing the tab list to fill the space without requiring
additional logic.
before:
https://screencast.googleplex.com/cast/NTA0NjgwMjQxOTAyMzg3MnwyNmNjMmUxZC03Ng
demo: http://screencast/cast/NTcxNTMwNTQ4ODcxMTY4MHw3N2FkNWQyOS03Mg
demo for other panes:
http://screencast/cast/NjM4MjA0MTkzNDMzMTkwNHwzYWMyYzE1My1iZQ
demo for landscape:
http://screencast/cast/NTU4MTM2NDUxNzY2NjgxNnwxNDUyNzMwMS0xZg
Bug: 449670068
Change-Id: Ie6538c179cb9f54534f95a3f5c5aa0bc15716268
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056503
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Hitarth Kothari <hitarthkothari@google.com>
Auto-Submit: Hitarth Kothari <hitarthkothari@google.com>
Cr-Commit-Position: refs/heads/main@{#1535134}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a6364151203138d43e7f3b75faf5a1c0aefebafa
commit a6364151203138d43e7f3b75faf5a1c0aefebafa
Author: Mark Schillaci <mschillaci@google.com>
Date: Thu Oct 23 10:55:10 2025 -0700
[Bookmarks Bar] Make the default location the bookmark bar when visible
This CL updates the implementation of saving bookmarks in Clank so that
when the bookmark bar is visible, we save to the bar by default instead
of the Mobile Bookmarks folder, per specs.
With the CL, we update the BookmarkUtils class to save new bookmarks
to the bookmark bar when the bookmark bar is visible and the user has
not already selected a location, i.e. we are updating the default
location only from the "Mobile" to "Desktop" (i.e. bookmark bar)
folder. This change only applies to NORMAL type bookmarks, and not
other items such as reading list or price trackers.
We update the behavior of setting the last used parent (folder) to
no longer update when the default folder is used. We do this to account
for the case where a user bookmarks a page (which goes into Mobile
Bookmarks), then shows the bookmark bar, and bookmarks a new page. If
we save the location after the first bookmark event, then the next
event with the bookmark bar visible would not save to the bookmark bar.
We do want it to save to the bookmark bar though, because the user
didn't explicitly choose the default location the previous time. Once
the user picks a new location, then that location is used going forward.
We overload the method to add new bookmarks to include a boolean for the
bookmark bar visibility, and one that mimics the original without the
parameter. For instances where this is not relevant (e.g. adding a new
bookmark from the tab list), we will not use the bookmark bar visibility
check because the bar cannot be visible in that case.
Bug: 444468570
Change-Id: I691736736a269e889b00f512efac338dc69c4947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7063535
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1534454}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/9c1c4aee59644bac9e6caf68c9615a44f2544a1a
commit 9c1c4aee59644bac9e6caf68c9615a44f2544a1a
Author: Juan Mojica <juanmojica@google.com>
Date: Fri Oct 24 18:23:40 2025 -0700
[AIM] Add visual selection thumbnail to Lens composebox
This change adds a thumbnail chip to the Lens composebox, which appears
at the top of the input area when a visual selection is active.
Key changes include:
- A new `AddFileContext` Mojo API is now used to send the thumbnail data URI and a deletability flag via an updated `SelectedFileInfo` struct to the composebox WebUI.
- `LensComposeboxController` is updated to store this visual selection context and call the Mojo API via the handler upon binding.
- WebUI components (`side_panel_app`, `composebox`) are modified to render the thumbnail in a new top-anchored carousel, adjusting the text input area accordingly.
- Existing thumbnail logic in `LensOverlayController` and `LensSearchContextualizationController` is refactored to utilize the new centralized methods in `LensSearchController`.
See bug for demo.
Bug: 450599476
Change-Id: I25e8f07858cbf018795b0274ba9d8f5dab67496d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7048844
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Marlon Facey <mfacey@chromium.org>
Reviewed-by: Duncan Mercer <mercerd@google.com>
Commit-Queue: Juan Mojica <juanmojica@google.com>
Cr-Commit-Position: refs/heads/main@{#1535431}
This has no functional change to the existing code, however these flags
have now defaults, and they are bundled together when calling this
function.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/1866a591e7a63e149e6487e0b87c8058d4a06416
commit 1866a591e7a63e149e6487e0b87c8058d4a06416
Author: David Pennington <dpenning@chromium.org>
Date: Thu Oct 23 14:19:14 2025 -0700
Fix TabGroup strokes to not overlap toolbar.
Recently we changed the way that BrowserView is laid out so that
we can simplify logic, however this seemed to have changed the order
that the Tabs and the Toolbar are painted. Because of this a paint
bug was exposed for TabGroup underline strokes which previously was not visible.
To fix this we correctly no longer paint any strokes below the tab extender.
As this was being done i also move the other optional flags in GetPath to a struct so that we dont have optionally defined parameters in virtual methods.
Bug: 454644321
Change-Id: Iba46e83354e30dd5367c631c4c0b5a201ba69147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081126
Auto-Submit: David Pennington <dpenning@chromium.org>
Reviewed-by: Alison Gale <agale@chromium.org>
Commit-Queue: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1534608}
These derived classes are now living on their respective headers under
`layout/`, which requires quite a few of the overrides to be shuffled
around under new shadow files.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/7905b0f981d5e50c6b365696377fec7498a2b2de
commit 7905b0f981d5e50c6b365696377fec7498a2b2de
Author: Dana Fried <dfried@chromium.org>
Date: Thu Oct 23 08:24:16 2025 -0700
[Chrome Next] Split out new layout class for toolbar height side panel
This moves all browser view layout classes into a new layout folder, and
splits out the old and new layout implementations into new files that
will only be used by the factory method in BrowserViewLayout and in
tests.
The new layout that supports the required UI is not fleshed out and
currently not functional. It will be implemented in follow-up CLs.
Bypass-Check-License: Moved files
Bug: 453717426
Change-Id: Ibe7f22ea88be5a56ace5586e0bc6d39fb6776930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7076757
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1534352}
Chromium change:
https://skia.googlesource.com/skia/+/21ffb380f3ab449c64e1568fef0eff7c67f1ae75
commit 21ffb380f3ab449c64e1568fef0eff7c67f1ae75
Author: Michael Reed <mike@reedtribe.org>
Date: Mon Oct 20 12:56:09 2025 -0400
Start migration off of pathref in SkPath impl : spans
With immutable paths, SkPathRef will go away (replaced by SkPathData)
This CL begins to simplify our API and internals to ease that change.
- simplify access to path spans
- eliminating a class of references to fPathRef
- (need to change interpolate() to be non-modifying)
Note: with this change, many other helpers like isLine() etc. can now
trivially be implemented by clients.
End goal:
- SkPath.cpp is for 'portable' methods -- independent of pathref/data
- SkPath_editing.cpp for pathref specifics
- SkPath_data.cpp for alt impls using SkPathData
... to make clear how to switch between the two
Change-Id: I1072e4d46d2d24f4edda830cff9a26e0caf803a1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1076305
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Mike Reed <mike@reedtribe.org>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1f78efed9ae282a0f0367b37e1c35cb2a07f0406
commit 1f78efed9ae282a0f0367b37e1c35cb2a07f0406
Author: Rafał Godlewski <rgod@google.com>
Date: Tue Oct 21 11:38:30 2025 -0700
[iOS][CPE] Use etld+1 in automatic passkey upgrade eligibility check
Adds new field to ArchivableCredential to store etld+1 for a password.
The field is only set in the browser as the required dep from //net is
disallowed in CPE.
etld+1 is used instead of serviceName for the automatic passkey upgrade
eligiblity check. With the updated logic, passkey can be automatically
created if the user has a password with the same username and the etld+1
of the password's website is a suffix of the relying party ID (or equal
to it).
Chromium change:
https://chromium.googlesource.com/chromium/src/+/697a34df14976
commit 697a34df14976d403b7dee673fae194d87b3dec7
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 21 04:56:00 2025 -0700
Componentize chrome/browser/offline_items_collection
This CL adds a BUILD.gn file to drive the compilation of
c/b/offline_items_collection.
It also allows the breaking of some existing circular dependencies
against //c/b:b (follow up CLs).
Bug: 353332589
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/6f58e0a893a94a97be13fdd3fb3c4ff1333b53e2
commit 6f58e0a893a94a97be13fdd3fb3c4ff1333b53e2
Author: Mikel Astiz <mastiz@chromium.org>
Date: Wed Oct 22 05:02:45 2025 -0700
[sync] Update URL for Sync Dashboard (behind disabled flag)
...which is currently referred to as the account data dashboard.
The new URL is considered more modern but otherwise serves the same
content as the old one.
The change is guarded behind a newly-introduced feature flag, which is
disabled by default for now. Follow-up patches plan to enable the
feature by default, and use it as a kill switch.
Bug: 447134784
Change-Id: I6caae8c67aeebc780df4ae810e36ffc119296c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7052385
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Tomek Jurkiewicz <tju@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Duong Dac <ddac@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533541}
This override was removed in upstream, to rely on whatever was being
used in the base class, however this functionality is still undesired in
brave, so this change readjusts the override for this class, to bring it
back.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/dfed004fc1e2cfd633b644b841abe6b2780b9e39
commit dfed004fc1e2cfd633b644b841abe6b2780b9e39
Author: Nicholas Roscino <nroscino@google.com>
Date: Wed Oct 22 02:53:56 2025 -0700
Avoid making request for OTR profiles
DevToolsHttpServiceHandler.Request now contains a check to make sure
not to make any request in case of no profile or OTR profiles.
Fixed: 445832340
Change-Id: I5675c1d288cd9efb4923b5c0f95b36951eeb6104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7046201
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nicholas Roscino <nroscino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533498}
This change corrects `BraveBrowserViewLayout` to work with the new
approach for the views being provided for the layout type. There are
several changes that are just analogous of what is being done in the
upstream code, however some TODOs have been added to the code, and an
issue has been logged up for follow ups.
https://github.com/brave/brave-browser/issues/50488
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/211feb59d9a5378a0707d1b5ba9223043ed1d471
commit 211feb59d9a5378a0707d1b5ba9223043ed1d471
Author: Dana Fried <dfried@chromium.org>
Date: Wed Oct 22 09:53:42 2025 -0700
[Chrome Next] Split BrowserViewLayout into multiple implementations
This creates a base class, BrowserViewLayout, and two subclasses:
- BrowserViewLayoutImplOld (current behavior, nothing should change)
- BrowserViewLayoutImpl (new behavior, not fully implemented)
Tests now test the "old" impl.
The set of views that is passed in on creation is also moved to a struct
and all of the fields being filled out is enforced via LINT.IfChange().
Follow-up:
- Make BrowserViewLayoutImpl perform minimal layout, add a flag to
switch between making them.
Bug: 453717426
Change-Id: I6483cb60d3b557248b05867664bd4cdcccfe34be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7068992
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533710}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/023128ed40ef043a55ef085be41c92ba52f366ca
commit 023128ed40ef043a55ef085be41c92ba52f366ca
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Mon Oct 20 20:31:22 2025 -0700
Fix payment Add Card fragment "cancel" stack behavior.
Opening Add Card fragment wrongly wiped the fragment back stack.
This CL add a flag to keep the stack and put the fragment on top
of the stack. Then, add the flag on opening Add Card fragment.
BUG=452828634
TEST=Tryjob. On Dut, open "Paymen methods > Add payment method",
and made sure the detailed title behavior and the cancel button.
Change-Id: Ie5caefa814f54bb3a0430350852f3ce550fe2281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053182
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1532719}
Chromium change:
https://chromium.googlesource.com/chromium/src/+/65735628a31eb4f9d04dbccea80a0287871252fc
commit 65735628a31eb4f9d04dbccea80a0287871252fc
Author: dpapad <dpapad@chromium.org>
Date: Mon Oct 20 14:54:27 2025 -0700
WebUI: Simplify Mojo bindings backend registration, part 1.
In this part updating only NewTabFooterUI, NewTabPageThirdPartyUI and
SettingsUI as examples. Remaining
RegisterWebUIControllerInterfaceBinder() calls should be migrated in
follow-up CLs.
Instead of using RegisterWebUIControllerInterfaceBinder() use
WebUIBrowserInterfaceBrokerRegistry::ForWebUI().Add() calls which are
much easier to work with. For example note how registration for
NewTabFooterUI can now be guarded by
base::FeatureList::IsEnabled(ntp_features::kNtpFooter) whereas
previously this was not possible (not practical).
Bug: 452983498
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d71ed037ed0acb08f0c4416e5673d31b047df708
commit d71ed037ed0acb08f0c4416e5673d31b047df708
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Oct 9 12:59:50 2025 -0700
Move ChromeBrowserMainParts code out of chrome_content_browser_client.cc
Currently, ChromeContentBrowserClient::CreateBrowserMainParts() does all
the work of selecting the right parts to instantiate. Move this code
into a new ChromeBrowserMainParts::Create() instead. Then
chrome_content_browser_client.cc, which is the one of the largest and
slowest to compile files in the source tree, builds about 3 seconds
faster in build time benchmarks on a physical workstation. While
chrome_browser_main.cc, which compiles in about half the time, builds
about 2.5 seconds slower. Given modern CPUs with many cores, this better
balances parallel work. Since compiling chrome_content_browser_client.cc
blocks the critical path to linking the chrome binary, this speeds up
the overall build by about 3 seconds.
Change-Id: I4223aa5fc88f615b5157397fffdc47a8b88a7d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7022412
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1527728}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/bb534fc398359fdefd2062727a054622b148b6b9
commit bb534fc398359fdefd2062727a054622b148b6b9
Author: Jon Toohill <jtoohill@google.com>
Date: Tue Oct 21 13:02:48 2025 -0700
Roll indexmap: 2.11.4 => 2.12.0 in //third_party/rust.
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* indexmap: 2.11.4 => 2.12.0; https://docs.rs/crate/indexmap/2.12.0
New crates:
* hashbrown@0.16.0; https://docs.rs/crate/hashbrown/0.16.0
Bug: 454033406
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Change-Id: I31429d9d46a70cf53f5964f49a11e664d6ac37d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7063198
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Jon Toohill <jtoohill@google.com>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533181}
This has broken the direct access to the underlying object in
`BraveBrowserView`, which now is acccessed as a browser feature.
Unfortunately with this change, the use of a new patch entry had to be
introduced, as we can't use macros to replace
`ExclusiveAccessContextImpl` methods, as the whole class is part of the
private implementation.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/21ac4ddd7e7dd32f839ffc14df5888ab8aa3e3d7
commit 21ac4ddd7e7dd32f839ffc14df5888ab8aa3e3d7
Author: Dana Fried <dfried@chromium.org>
Date: Tue Oct 21 13:35:17 2025 -0700
[Browser View] Move delegate to PImpl to reduce public API, includes
This moves ExclusiveAccessContext and ExclusiveAccessBubbleViewsContext
interfaces off of BrowserView and into a private implementation.
Benefits:
- Smaller BrowserView API and browser_view.h
- Fewer includes in browser_view.h (most consumers of BrowserView do
not need to know about these interfaces)
- Prevent downstream classes unrelated to exclusive access
inadvertently calling methods from these now-private interfaces
(Compile size shrinks by >1MB!)
Bug: 453638016
Change-Id: I9cd71f705ce1af5e0544fd3e4c68f00050eb1cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7059470
Reviewed-by: Ben Franz <bfranz@chromium.org>
Reviewed-by: Charles Meng <charlesmeng@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533208}
We have been patching the `serde` feature into this crate, and this now
requires to patch this new dependency.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/d56121611610ce64c807dad319032012bb24c963
commit d56121611610ce64c807dad319032012bb24c963
Author: Jon Toohill <jtoohill@google.com>
Date: Mon Oct 20 13:47:59 2025 -0700
Roll bitflags: 2.9.4 => 2.10.0 in //third_party/rust.
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* bitflags: 2.9.4 => 2.10.0; https://docs.rs/crate/bitflags/2.10.0
Bug: None
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Change-Id: I234ae8ee1299c632a891f4782877a76c3084d18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7063453
Commit-Queue: Julia Hansbrough <flowerhack@google.com>
Auto-Submit: Jon Toohill <jtoohill@google.com>
Reviewed-by: Julia Hansbrough <flowerhack@google.com>
Cr-Commit-Position: refs/heads/main@{#1532512}
With the call for `InspectorBackendCommands.registerCommands` moved into
`InspectorBackend.ts`, this change also move the registering of
`Network.requestAdblockInfoReceived` into the same file.
commit 3d596e46a5128e6ec41a825f4d1b12dc2534aed0
Author: Simon Zünd <szuend@chromium.org>
Date: Mon Oct 20 08:00:09 2025 +0200
[protocol] Register commands in InspectorBackend constructor
This CL moves the CDP command/event injection from ES module evaluation
time, to InspectorBackend constructor time.
R=alexrudenko@chromium.org
Bug: 453469270
Change-Id: If16cbcc2916b7e266dbf65abd169e1f1856f7da2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7061411
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
stderr:
../../brave/components/brave_wallet/browser/cardano/cardano_wallet_service_unittest.cc:208:17: error: 'DoAll<(lambda at ../../base/test/gmock_callback_support.h:81:10)>' is deprecated: Avoid using DoAll() for single actions [-Werror,-Wdeprecated-declarations]
208 | .WillOnce(DoAll(RunOnceClosure(task_environment_.QuitClosure())));
| ^
../../third_party/googletest/src/googlemock/include/gmock/gmock-actions.h:1884:1: note: 'DoAll<(lambda at ../../base/test/gmock_callback_support.h:81:10)>' has been explicitly marked deprecated here
1884 | GTEST_INTERNAL_DEPRECATE_AND_INLINE("Avoid using DoAll() for single actions")
| ^
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h:2327:5: note: expanded from macro 'GTEST_INTERNAL_DEPRECATE_AND_INLINE'
2327 | [[deprecated(msg), clang::annotate("inline-me")]]
| ^
1 error generated.
Chromium change:
https://github.com/google/googletest/commit/a05c0915074bcd1b82f232e081da9bb6c205c28d
commit a05c0915074bcd1b82f232e081da9bb6c205c28d
Author: Abseil Team <absl-team@google.com>
Date: Sat Aug 16 20:07:31 2025 -0700
Deprecate single-argument DoAll and Invoke.
PiperOrigin-RevId: 795969677
Change-Id: I56d88ec715475d91fb527a9281bc62574fb4608b
Artem Samoilenko