mkarolin
18e2621958
We were disabling these too aggressively. Re-enabling the ones that don't fail with special interest in CaptivePortal tests due verify our patch in ShouldExcludeNavigationFromUpgrades function in HttpsUpgradesInterceptor doesn't interfere with the upstream's captive portal code. Chromium change: https://source.chromium.org/chromium/chromium/src/+/6a80cd70fe4032a33af8a2367630469991bceb9f commit 6a80cd70fe4032a33af8a2367630469991bceb9f Author: Mustafa Emre Acer <meacer@chromium.org> Date: Thu Jun 27 19:57:29 2024 +0000 [HTTPS Upgrades] Disable for captive portal login URLs When Chrome detects that it's behind a captive portal, it automatically opens a new tab or popup pointing to the captive portal's login URL. Presently, HTTPS Upgrades treats this a normal tab and attempts to upgrade it. Most captive portals don't allow HTTPS requests to go through before the user logs in, so HTTPS Upgrades will fall back to the http URL as usual. However, some portals allow HTTPS. This may cause an empty page to be displayed to the user if the request is upgraded, e.g. to https://www.gstatic.com/generate_204. This CL disables upgrades on the first navigation to the captive portal login URL when a portal is detected, and the HTTPS-First Mode interstitial is not enabled. Bug: 343947168
Brave Core
Brave Core is a set of changes, APIs, and scripts used for customizing Chromium to make the Brave browser. Please also check https://github.com/brave/brave-browser
Follow @brave on Twitter for important announcements.
Resources
Community
You can ask questions and interact with the community in the following locations:
- Brave Community
communitychannel on Brave Software's Slack