Panic rather than silently continuing when ingestion for FMA manifest updates fails on an app (#30346)

Fixes #30338.

- [x] Manual QA for all new/changed functionality
This commit is contained in:
Ian Littman
2025-06-26 17:22:44 -05:00
committed by GitHub
parent 0c4af0b985
commit dbcf31d9fd
2 changed files with 2 additions and 3 deletions
+1 -1
View File
@@ -42,7 +42,7 @@ func main() {
for inputDir, ingest := range ingesters {
apps, err := ingest(ctx, logger, inputDir, *slugPtr)
if err != nil {
level.Error(logger).Log("msg", "failed to ingest apps", "error", err)
panic(err)
}
for _, app := range apps {
@@ -83,8 +83,7 @@ func IngestApps(ctx context.Context, logger kitlog.Logger, inputsPath string, sl
outApp, err := i.ingestOne(ctx, input)
if err != nil {
level.Warn(logger).Log("msg", "failed to ingest app", "err", err, "name", input.Name)
continue
return nil, ctxerr.Wrap(ctx, err, "ingesting winget app")
}
manifestApps = append(manifestApps, outApp)