Panic rather than silently continuing when ingestion for FMA manifest updates fails on an app (#30346)
Fixes #30338. - [x] Manual QA for all new/changed functionality
This commit is contained in:
@@ -42,7 +42,7 @@ func main() {
|
||||
for inputDir, ingest := range ingesters {
|
||||
apps, err := ingest(ctx, logger, inputDir, *slugPtr)
|
||||
if err != nil {
|
||||
level.Error(logger).Log("msg", "failed to ingest apps", "error", err)
|
||||
panic(err)
|
||||
}
|
||||
|
||||
for _, app := range apps {
|
||||
|
||||
@@ -83,8 +83,7 @@ func IngestApps(ctx context.Context, logger kitlog.Logger, inputsPath string, sl
|
||||
|
||||
outApp, err := i.ingestOne(ctx, input)
|
||||
if err != nil {
|
||||
level.Warn(logger).Log("msg", "failed to ingest app", "err", err, "name", input.Name)
|
||||
continue
|
||||
return nil, ctxerr.Wrap(ctx, err, "ingesting winget app")
|
||||
}
|
||||
|
||||
manifestApps = append(manifestApps, outApp)
|
||||
|
||||
Reference in New Issue
Block a user