Commit Graph
6863 Commits
Author SHA1 Message Date
Roberto Dip fb2400c966 launch Nudge using /usr/bin/open (#10051)
this accomplishes two things:

1. We're not waiting on Nudge to exit anymore, preventing issues like
https://github.com/fleetdm/fleet/issues/10044
2. Nudge is launched as a local user instead of root, which is the
recommended way to do it.
2023-02-23 14:48:40 -03:00
Mike McNeil 056437f474 Include preamble (#10061) 2023-02-23 11:30:12 -06:00
Marcos Oviedo 7e95c52213 Pushing CIS policy checks for 2.3.1.x to 2.3.7.x (#9902)
This relates to #9850
2023-02-23 14:04:23 -03:00
RachelElysia 549a7c7fd8 Fleet UI: Use currentTeam.id from app context to set teamId for API calls on Manage host page (#10053) 2023-02-23 11:37:09 -05:00
Charlie Chance c045678fe9 kebab case and remove emojis from the filename of JDs (#10054)
I think there is still work to be done with
[fleetdm.com](http://fleetdm.com/). Right now, the "jobs" button on the
website redirects folks to the handbook. It sounds like you want a new
website page created to have open positions listed with links that
direct folks to, I assuming, another page with the JD (or the GitHub
file?).
Loom for visual and demo of the current flow of events:
https://www.loom.com/share/3a2e6fa57bd343edaa00a8561affbaa2
2023-02-23 08:28:04 -07:00
Noah Talerman ecf730d9be MDM docs: Reset Mac password with recovery key (#10033)
- Update the instructions
2023-02-23 09:50:00 -05:00
Gabriel Hernandez bc27289034 fix for View all host results on the Operating Systems table. (#10006)
The `View all host` button on Operating systems table would navigate to
the host page but not show the related hosts. This fixes that issue.

If some of the following don't apply, delete the relevant line.

**Before:**

https://www.loom.com/share/a29fc7064e694fac8dbdde571b409264

**After:**

https://www.loom.com/share/3adfa9b9ab7f4f498d7112b6d1052ea1

- [x] Manual QA for all new/changed functionality
2023-02-23 14:22:09 +00:00
gillespi314 66bd7a7fb8 Reconcile API integration for MDM profile statuses in host details (#10045)
Fixes issues found during manual QA of integration for #10034 and #10019
2023-02-23 10:27:00 -03:00
Zach Wasserman 7c9454c92d Changes in Fleet server to support Fleetd for Chrome (#10047)
These are minor changes needed to support the new ChromeOS extension.
This should have no effect on non-Chrome platforms.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2023-02-23 09:18:04 -03:00
Robert Fairburn e760ce4ac5 Separate monitoring notifications per alert (#10032) 2023-02-22 21:25:25 -06:00
Benjamin Edwards c1a7b565f1 output arn & id for mdm secrets (#10046)
add outputs to mdm module to make it simple to utilize downstream
2023-02-22 21:37:46 -05:00
Jacob ShandlingandJacob Shandling bbaa225c0e Refactor macOS settings items (#10019)
# Implements

Encapsulates the specific logic for determining different UI elements
for displaying the status of mac settings in the HostSummary and
MacSettingsTable.

# Checklist for submitter
- [x] Added/updated tests

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-02-22 16:35:26 -08:00
Charlie Chance b51693b3be Charlotte chance patch 1 (#10043)
iteration of the postings. Noticed some inconsistency in headings and
call to action.
2023-02-22 16:45:28 -07:00
Charlie Chance a47df71fd5 Breezy migration last steps (#10041) 2023-02-22 16:22:29 -07:00
Charlie Chance 4ef9f1525c Creating job posting sub pages for current roles open (#10040)
Breezy migration: https://github.com/fleetdm/fleet/issues/9930

Typeform needs to be added to the bottom of the pages, did that out of
order slightly.
<!-- actually, I think it's a redirect that needs to be created --> to
add the Typeform link: https://3x3q33auqgj.typeform.com/to/upGkhYsN

Zapier works. 

Handbook is updated. 

Final step is to cancel Breezy.
2023-02-22 16:12:19 -07:00
Benjamin Edwards 1158e62e44 use the same lock id between lock and unlock (#10039)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-02-22 17:48:46 -05:00
gillespi314 e31fc889f1 Add MDM profiles to host detail in API responses (#10034)
Issue #9599 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-02-22 16:26:06 -06:00
Jarod ReyesandEric 48ca4bc26d Introducing Fleet Ultimate blog post. (#9979)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Eric <eashaw@sailsjs.com>
2023-02-22 14:11:40 -08:00
RachelElysia 1dcf9781ab Fleet UI: Select targets distributed interval tooltips (#9975) 2023-02-22 16:27:02 -05:00
Lucas Manuel RodriguezandMo Zhu f4df9b58a4 Add docs for cis benchmarks macOS 13 (#9987)
See #9974.

---------

Co-authored-by: Mo Zhu <mo@fleetdm.com>
2023-02-22 18:07:36 -03:00
Mike McNeil 86c75b706e Add positioning link (#10031) 2023-02-22 15:01:33 -06:00
Mike McNeil 9d1799e70b Add Fleet’s W-9 (#10024) 2023-02-22 14:49:30 -06:00
Noah Talerman e5437c9ff0 Activity feed UI: Update turn off MDM (#10020)
- Clarify the "Turn off MDM" activity feed item. One item tracks when an
IT admin clicked the Turn off MDM button in the UI (command was queued)
and the other item tracks when the host reported that MDM was turned off
(command ran)

More context is here in Slack (internal):
https://fleetdm.slack.com/archives/C03C41L5YEL/p1677090855479879?thread_ts=1677089154.560089&cid=C03C41L5YEL
2023-02-22 17:39:19 -03:00
Roberto Dip 8284274c3b incomplete implementation of device wipe and lock (#9947) 2023-02-22 17:11:44 -03:00
Gabriel Hernandez a410d0a8b4 fix UI style bug and showing turn off mdm action correctly (#10005) 2023-02-22 13:21:41 -06:00
Mike McNeil fed44dd9fa Fix formatting (#9990)
Was getting smooshed into the bullet
2023-02-22 13:17:22 -06:00
Lucas Manuel Rodriguez 4784217b57 Add documentation for missing fleetd tables and regenerate JSON (#9960)
Updating documentation of Fleetd tables as part of the oncall duty.

Updating the json used by Fleet using the following command:
```sh
cd website
 ./node_modules/sails/bin/sails.js run generate-merged-schema
```

Samples:
![Screenshot 2023-02-20 at 17 20
55](https://user-images.githubusercontent.com/2073526/220192112-69a116e4-badb-4328-92d3-9a2a6f8657fe.png)
![Screenshot 2023-02-20 at 17 21
09](https://user-images.githubusercontent.com/2073526/220192117-dfa06c69-2166-47d4-99c3-e108911e2084.png)


@mikermcneil @eashaw: `generate-merged-schema` generates a different
output every time it's executed. Guess: It seems it should sort the
output lexicograhically?
2023-02-22 16:05:36 -03:00
Mike McNeil 6091556b7a Fix build (#10018)
mikermcneil
  3 minutes ago
@Kathy Satterlee
 I think https://github.com/fleetdm/fleet/pull/9881 broke the build
4 replies

 .
mikermcneil
  2 minutes ago
https://github.com/fleetdm/fleet/pull/9979#issuecomment-1440604277


Zay Hanlon
  1 minute ago
Oops. That was my approval/merge on Kathy's change


Zay Hanlon
  1 minute ago
How do I fix?


mikermcneil
  < 1 minute ago
@Zay Hanlon
All good. I think we should make it so that PRs can't be merged until
they pass the CI checks. It's annoying but would prevent things like
this, which are expensive and involve multiple folks' time.
@Zach Wasserman
 
@Luke Heath
I'm going to turn on the branch protection that prevents merging when
automated CI checks are failing.
@Kathy Satterlee
 I'll follow up with a fix now.
@Jarod Reyes
 Feel free to go ahead and merge your PR in the meantime.


Zay Hanlon
:spiral_calendar_pad: [11 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677091760162369?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
Sorry 😞


mikermcneil
[10 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677091789685699?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
All good, inevitable


Zach Wasserman
[9 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677091841779269?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
FWIW turning that on will really slow down my dev process at times.


Zach Wasserman
[8 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677091942206439?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
eg. if I make one tiny change on a PR that I already know passes all the
tests then I'll have to wait 15 mins for the whole CI to run before I
can merge.


mikermcneil
[7 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677091967828479?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
it was an indentation issue:
https://github.com/fleetdm/fleet/pull/10018/files#diff-68623aac08ce48b5c1275a38ea9f42a8a730a9c2e04ab1946174cdc67f4ce686R8
:ty:
1



Luke Heath
[7 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677092006055779?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
Is it possible to conditionally enable the required CI checks?


Zach Wasserman
[6 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677092018873739?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
Maybe you can just turn on a limited set of checks that we know go
really fast and have a high true-positive rate?


Luke Heath
[6 minutes
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677092062859149?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
That's a good idea. FWIW we'll be removing e2e test runs in CI later
this week, which will reduce the CI run time by ~25 minutes.


mikermcneil
[< 1 minute
ago](https://fleetdm.slack.com/archives/C01EZVBHFHU/p1677092432337109?thread_ts=1677091575.384279&cid=C01EZVBHFHU)
This is not the first time this has happened and I'd like to put an end
to the emergency remediation that takes a chunk of the day's focus away
from multiple people each time it occurs. If it causes a drain on our
ability to move quickly, let's def change it back. If it's worth the
friction (like the PR approval restriction), then we can keep it.
I'm running into the problem of being able to select the "test-website"
job from [this
list](https://github.com/fleetdm/fleet/settings/branch_protection_rules/18283834),
likely because it is already conditional:
image.png
2023-02-22 13:00:45 -06:00
Gabriel Hernandez ba38696ada fix UI styling for custom settings page (#10016) 2023-02-22 12:56:49 -06:00
Jacob ShandlingandJacob Shandling ba34351f4b UI: Implement new activity types for macOS profiles (#9894)
# Addresses #9595

# Implements

- new Activity types:
    - CreatedMacOSProfile
    - DeletedMacOSProfile
    - EditedMacOSProfile
- Activity message depends on isPremium:
- true: '...macOS hosts with no team' or '...macOS hosts assigned to the
**Team Name** team {?via fleetctl}.'
    - false: '...{to | from | for} all macOS hosts.'
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`
- [ ] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-02-22 10:42:40 -08:00
Mike McNeil d4463bcb88 Delete #g-community (#9981) 2023-02-22 10:09:36 -08:00
Roberto Dip 262e9870e3 add a cron job to reconcile profiles (#9946)
https://github.com/fleetdm/fleet/issues/9590
2023-02-22 14:49:06 -03:00
Katheryn Satterlee 3c835ec1e3 Expand description of min_version (#9881)
Documentation only change - expanded description of `min_version`column
in the `xprotect_meta` table to include an explanation of `any`.

Resolves #9545
2023-02-22 12:39:29 -05:00
Zachary WinnermanandBenjamin Edwards 99b9c24b0a Vulnerabilities run via crontab job (#9938)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Benjamin Edwards <edwards.benw@gmail.com>
2023-02-22 12:35:40 -05:00
RachelElysia 2e870004e5 Frontend: Fix typos (#10009) 2023-02-22 12:26:24 -05:00
Mike McNeil 58837bc42e Sub-tasks (#10015) 2023-02-22 10:49:59 -06:00
Katheryn Satterlee 066a0cbe4b Update flags for plain osquery hosts (#10014)
Updated the recommended flags for osquery hosts to use unversioned
endpoint
2023-02-22 10:29:03 -06:00
Katheryn Satterlee ed20ff44c1 Update endpoints for osquery (#10012)
Added `/api/osquery` to the list of endpoints to expose to public
internet.
2023-02-22 10:22:09 -06:00
Lucas Manuel Rodriguez 407d05eab9 Workaround to set policy specs on a team (#9978)
For the CIS benchmark feature, we need a way to import a group of
policies (spec yml) into a team.
This PR adds a flag to `apply -f` to allow setting a team name to a
group of policies.

Sample:
```sh
fleetctl apply --context dogfood --policies-team "📊 CIS Benchmarks" -f ee/cis/macos-13/cis-policy-queries.yml
```

- [X] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- ~[ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)~
- ~[ ] Documented any permissions changes~
- ~[ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)~
- ~[ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.~
- [ ] Added/updated tests
- [X] Manual QA for all new/changed functionality
  - ~For Orbit and Fleet Desktop changes:~
- ~[ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.~
- ~[ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).~
2023-02-22 13:14:53 -03:00
Jacob ShandlingandJacob Shandling a578e20930 UI: Add macOS settings (profiles) indicator and modal with data table (#9809)
# Addresses #9413

# Implements
https://www.loom.com/share/d1b66a3076b94bf2add4fcf8666649a4

- macOS settings indicator on host details and device user pages. Only
displayed if (1) the host is enrolled in a Fleet MDM server and (2) the
host has at least one setting (profile) enforced.
- macOS settings modal, toggled by clicking on above indicator. Contains
a data table with the name, status, and error messages, if any, of each
enforced macOS setting on the host.

# Notes
- To aid in reviewing, you'll probably want to focus on:
-
[DeviceUserPage.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-be9f14d3cee9f345058212985c26b3452688c6d75853a5e9dcb968a69dfcbbd7)
and
[HostDetailsPage.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-72f7403682d211fc8a84a411fc39c4a33c3eb6a33549a33f1179dd7da6a893cc)
-
[HostSummary.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-435e720f1ad82e892bec00fbc9c14e01e9488b776ae293f9158500c66d85bd0d)
-
[MacSettingsIndicator.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-e23079f72b13bd34eb978eded467265dad4f366a6fece60cd52c887f355f92d1)
-
[MacSettingsModal.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-75a08aa5b66cc2b63fc616d8ba012e552376f23d3c3df01d875586857f326f53)
-
[MacSettingsTable.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-5dc441b06f770f112bb32bb618e2140e9bbccb7ebf80d86ee57c2754e067a421)
and its associated
[MacSettingsTableConfig.tsx](https://github.com/fleetdm/fleet/pull/9809/files#diff-0ab0cb34e249e2a41bf51508d38bea018dc5e683b705308250241c42549ab093)
   
- Currently using mock data. Once #9599 is completed, #9888 will change
these components to use the real data
- 2/21 - removed mock data. Until the API returns the host.mdm.profiles
data, settings indicator and modal will not render
# Checklist

- [x] Changes file added
- [x] Manual QA
- [x] Updated testing inventory

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-02-22 08:13:12 -08:00
Robert Fairburn de888d3cb3 Initial Terraform ALB Loggin Module (#10010) 2023-02-22 10:07:12 -06:00
RachelElysia 37c90502a6 Fleet UI: Select targets logic for "All hosts" to be mutually exclusive from other filters (#9992) 2023-02-22 10:32:43 -05:00
RachelElysia dbec2f85df Fleet UI: Consistent URL validation (#9806) 2023-02-22 09:05:38 -05:00
Lucas Manuel Rodriguez b3e8b6007a Update docs for device_mapping, works on all OSs (with fleetd) (#9982)
The `google_chrome_profiles` table is present in the three OSs. The one
requirement is that the user must use fleetd.
2023-02-22 08:41:50 -03:00
Gabriel Hernandez fbc3224540 update location of macOS updates page section (#9977)
Just a quick update to move the macOS updates directory to live inside
the manage controls page
2023-02-22 11:15:22 +00:00
Zach Wasserman 2a7b7100dd Update Orbit to use CGO on Linux (#9846) 2023-02-21 18:49:13 -08:00
Eric 295208a77b Website: Remove newlines from osquery schema table column decsriptions. (#10002)
Closes: #9963 

Changes:
- Updated`build-static-content` script to replace newlines in the
`description` property of osquery schema columns. This prevents
multi-line descriptions from adding additional rows when a multi-line
description is added to a Markdown table.
2023-02-21 20:20:08 -06:00
Jacob ShandlingandJacob Shandling ea414cdbb2 fix broken shell script (#9920)
Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-02-21 15:49:16 -08:00
Roberto Dip edc0324ac0 update mockimpl version to allow concurrent mock calls (#9989)
this uses the associated new version in our fork

https://github.com/fleetdm/mockimpl/commit/ecbb3041eabfc9e046a3f2e414e32c28254b75b2

to allow for concurrent access to mocks
2023-02-21 16:36:06 -03:00
Mike McNeil 033be67742 Define DRI (#9967)
point to
https://fleetdm.com/handbook/company/why-this-way#why-direct-responsibility

(mostly because this section is what comes up in algolia search if you
search the handbook for "DRI"-- this way there's a kind of breadcrumb to
the explanation. But always nice to unfold acronyms anyways)
2023-02-21 09:59:08 -08:00